Re: [PATCH 08/13] drm/omap: dpi: remove legacy data_lines

2017-05-12 Thread Laurent Pinchart 
Hi Tomi,

Thank you for the patch.

On Friday 12 May 2017 13:41:37 Tomi Valkeinen wrote:
> Remove DPI's legacy data_lines code.
> 
> Signed-off-by: Tomi Valkeinen 

Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c   |  4 
>  drivers/gpu/drm/omapdrm/displays/panel-dpi.c|  5 -
>  drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c |  5 -
>  drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c |  4 
>  drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c  |  5 -
>  drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c |  5 -
>  drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c |  4 
>  drivers/gpu/drm/omapdrm/dss/dpi.c   | 13 --
>  drivers/gpu/drm/omapdrm/dss/omapdss.h   |  6 --
>  9 files changed, 51 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
> b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c index
> 13e32d02c884..947295f9e30f 100644
> --- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
> +++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
> @@ -22,7 +22,6 @@ struct panel_drv_data {
>   struct omap_dss_device *in;
> 
>   int pd_gpio;
> - int data_lines;
> 
>   struct videomode vm;
>  };
> @@ -82,8 +81,6 @@ static int tfp410_enable(struct omap_dss_device *dssdev)
>   return 0;
> 
>   in->ops.dpi->set_timings(in, >vm);
> - if (ddata->data_lines)
> - in->ops.dpi->set_data_lines(in, ddata->data_lines);
> 
>   r = in->ops.dpi->enable(in);
>   if (r)
> @@ -226,7 +223,6 @@ static int tfp410_probe(struct platform_device *pdev)
>   dssdev->type = OMAP_DISPLAY_TYPE_DPI;
>   dssdev->output_type = OMAP_DISPLAY_TYPE_DVI;
>   dssdev->owner = THIS_MODULE;
> - dssdev->phy.dpi.data_lines = ddata->data_lines;
>   dssdev->port_num = 1;
> 
>   r = omapdss_register_output(dssdev);
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c index
> 75b98bb81de2..cc5920b476d6 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> @@ -26,8 +26,6 @@ struct panel_drv_data {
>   struct omap_dss_device dssdev;
>   struct omap_dss_device *in;
> 
> - int data_lines;
> -
>   struct videomode vm;
> 
>   struct backlight_device *backlight;
> @@ -77,8 +75,6 @@ static int panel_dpi_enable(struct omap_dss_device
> *dssdev) if (omapdss_device_is_enabled(dssdev))
>   return 0;
> 
> - if (ddata->data_lines)
> - in->ops.dpi->set_data_lines(in, ddata->data_lines);
>   in->ops.dpi->set_timings(in, >vm);
> 
>   r = in->ops.dpi->enable(in);
> @@ -257,7 +253,6 @@ static int panel_dpi_probe(struct platform_device *pdev)
> dssdev->type = OMAP_DISPLAY_TYPE_DPI;
>   dssdev->owner = THIS_MODULE;
>   dssdev->panel.vm = ddata->vm;
> - dssdev->phy.dpi.data_lines = ddata->data_lines;
> 
>   r = omapdss_register_display(dssdev);
>   if (r) {
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c index
> 43d21edb51f5..451e1608a1db 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> @@ -49,8 +49,6 @@ struct panel_drv_data {
> 
>   struct spi_device *spi;
> 
> - int data_lines;
> -
>   struct videomode vm;
> 
>   struct gpio_desc *enable_gpio;
> @@ -159,8 +157,6 @@ static int lb035q02_enable(struct omap_dss_device
> *dssdev) if (omapdss_device_is_enabled(dssdev))
>   return 0;
> 
> - if (ddata->data_lines)
> - in->ops.dpi->set_data_lines(in, ddata->data_lines);
>   in->ops.dpi->set_timings(in, >vm);
> 
>   r = in->ops.dpi->enable(in);
> @@ -289,7 +285,6 @@ static int lb035q02_panel_spi_probe(struct spi_device
> *spi) dssdev->type = OMAP_DISPLAY_TYPE_DPI;
>   dssdev->owner = THIS_MODULE;
>   dssdev->panel.vm = ddata->vm;
> - dssdev->phy.dpi.data_lines = ddata->data_lines;
> 
>   r = omapdss_register_display(dssdev);
>   if (r) {
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
> b/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c index
> 2de27ba01552..95f6702a7b4f 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
> @@ -25,8 +25,6 @@ struct panel_drv_data {
> 
>   struct videomode vm;
> 
> - int data_lines;
> -
>   int res_gpio;
>   int qvga_gpio;
> 
> @@ -153,8 +151,6 @@ static int nec_8048_enable(struct omap_dss_device
> *dssdev) if (omapdss_device_is_enabled(dssdev))
>   return 0;
> 
> - if (ddata->data_lines)
> -

[PATCH 08/13] drm/omap: dpi: remove legacy data_lines

2017-05-12 Thread Tomi Valkeinen 
Remove DPI's legacy data_lines code.

Signed-off-by: Tomi Valkeinen 
---
 drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c   |  4 
 drivers/gpu/drm/omapdrm/displays/panel-dpi.c|  5 -
 drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c |  5 -
 drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c |  4 
 drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c  |  5 -
 drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c |  5 -
 drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c |  4 
 drivers/gpu/drm/omapdrm/dss/dpi.c   | 13 -
 drivers/gpu/drm/omapdrm/dss/omapdss.h   |  6 --
 9 files changed, 51 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c 
b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
index 13e32d02c884..947295f9e30f 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
@@ -22,7 +22,6 @@ struct panel_drv_data {
struct omap_dss_device *in;
 
int pd_gpio;
-   int data_lines;
 
struct videomode vm;
 };
@@ -82,8 +81,6 @@ static int tfp410_enable(struct omap_dss_device *dssdev)
return 0;
 
in->ops.dpi->set_timings(in, >vm);
-   if (ddata->data_lines)
-   in->ops.dpi->set_data_lines(in, ddata->data_lines);
 
r = in->ops.dpi->enable(in);
if (r)
@@ -226,7 +223,6 @@ static int tfp410_probe(struct platform_device *pdev)
dssdev->type = OMAP_DISPLAY_TYPE_DPI;
dssdev->output_type = OMAP_DISPLAY_TYPE_DVI;
dssdev->owner = THIS_MODULE;
-   dssdev->phy.dpi.data_lines = ddata->data_lines;
dssdev->port_num = 1;
 
r = omapdss_register_output(dssdev);
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c 
b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
index 75b98bb81de2..cc5920b476d6 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
@@ -26,8 +26,6 @@ struct panel_drv_data {
struct omap_dss_device dssdev;
struct omap_dss_device *in;
 
-   int data_lines;
-
struct videomode vm;
 
struct backlight_device *backlight;
@@ -77,8 +75,6 @@ static int panel_dpi_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
 
-   if (ddata->data_lines)
-   in->ops.dpi->set_data_lines(in, ddata->data_lines);
in->ops.dpi->set_timings(in, >vm);
 
r = in->ops.dpi->enable(in);
@@ -257,7 +253,6 @@ static int panel_dpi_probe(struct platform_device *pdev)
dssdev->type = OMAP_DISPLAY_TYPE_DPI;
dssdev->owner = THIS_MODULE;
dssdev->panel.vm = ddata->vm;
-   dssdev->phy.dpi.data_lines = ddata->data_lines;
 
r = omapdss_register_display(dssdev);
if (r) {
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c 
b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
index 43d21edb51f5..451e1608a1db 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
@@ -49,8 +49,6 @@ struct panel_drv_data {
 
struct spi_device *spi;
 
-   int data_lines;
-
struct videomode vm;
 
struct gpio_desc *enable_gpio;
@@ -159,8 +157,6 @@ static int lb035q02_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
 
-   if (ddata->data_lines)
-   in->ops.dpi->set_data_lines(in, ddata->data_lines);
in->ops.dpi->set_timings(in, >vm);
 
r = in->ops.dpi->enable(in);
@@ -289,7 +285,6 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi)
dssdev->type = OMAP_DISPLAY_TYPE_DPI;
dssdev->owner = THIS_MODULE;
dssdev->panel.vm = ddata->vm;
-   dssdev->phy.dpi.data_lines = ddata->data_lines;
 
r = omapdss_register_display(dssdev);
if (r) {
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c 
b/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
index 2de27ba01552..95f6702a7b4f 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
@@ -25,8 +25,6 @@ struct panel_drv_data {
 
struct videomode vm;
 
-   int data_lines;
-
int res_gpio;
int qvga_gpio;
 
@@ -153,8 +151,6 @@ static int nec_8048_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
 
-   if (ddata->data_lines)
-   in->ops.dpi->set_data_lines(in, ddata->data_lines);
in->ops.dpi->set_timings(in, >vm);
 
r = in->ops.dpi->enable(in);
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c