Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables

2020-11-06 Thread Tomi Valkeinen 
On 05/11/2020 20:07, Lee Jones wrote:
> On Thu, 05 Nov 2020, Tomi Valkeinen wrote:
> 
>> On 05/11/2020 16:45, Lee Jones wrote:
>>> Fixes the following W=1 kernel build warning(s):
>>>
>>>  drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’:
>>>  drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but 
>>> not used [-Wunused-but-set-variable]
>>>  drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’:
>>>  drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set but 
>>> not used [-Wunused-but-set-variable]
>>>  drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but 
>>> not used [-Wunused-but-set-variable]
>>>
>>> Cc: Tomi Valkeinen 
>>> Cc: David Airlie 
>>> Cc: Daniel Vetter 
>>> Cc: Laurent Pinchart 
>>> Cc: dri-devel@lists.freedesktop.org
>>> Signed-off-by: Lee Jones 
>>> ---
>>>  drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++---
>>>  1 file changed, 2 insertions(+), 7 deletions(-)
>>
>> I'd use "drm/omap: dsi: " subject prefix, the current one is fine too:
>>
>> Reviewed-by: Tomi Valkeinen 
>>
>> Should I pick this up or do you want to keep the series intact?
> 
> If you are in a position to take it, please do so.
> 
> I rebase every day, so it will just vanish from my working set.

I have a 56 patch series on dsi.c that I sent yesterday, and it conflicts with 
this one. I'll pick
this one on top of my series.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables

2020-11-06 Thread Lee Jones 
On Fri, 06 Nov 2020, Tomi Valkeinen wrote:

> On 05/11/2020 20:07, Lee Jones wrote:
> > On Thu, 05 Nov 2020, Tomi Valkeinen wrote:
> > 
> >> On 05/11/2020 16:45, Lee Jones wrote:
> >>> Fixes the following W=1 kernel build warning(s):
> >>>
> >>>  drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’:
> >>>  drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but 
> >>> not used [-Wunused-but-set-variable]
> >>>  drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’:
> >>>  drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set 
> >>> but not used [-Wunused-but-set-variable]
> >>>  drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but 
> >>> not used [-Wunused-but-set-variable]
> >>>
> >>> Cc: Tomi Valkeinen 
> >>> Cc: David Airlie 
> >>> Cc: Daniel Vetter 
> >>> Cc: Laurent Pinchart 
> >>> Cc: dri-devel@lists.freedesktop.org
> >>> Signed-off-by: Lee Jones 
> >>> ---
> >>>  drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++---
> >>>  1 file changed, 2 insertions(+), 7 deletions(-)
> >>
> >> I'd use "drm/omap: dsi: " subject prefix, the current one is fine too:
> >>
> >> Reviewed-by: Tomi Valkeinen 
> >>
> >> Should I pick this up or do you want to keep the series intact?
> > 
> > If you are in a position to take it, please do so.
> > 
> > I rebase every day, so it will just vanish from my working set.
> 
> I have a 56 patch series on dsi.c that I sent yesterday, and it conflicts 
> with this one. I'll pick
> this one on top of my series.

Sounds good, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables

2020-11-05 Thread Laurent Pinchart 
Hi Lee,

Thank you for the patch.

On Thu, Nov 05, 2020 at 02:45:06PM +, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’:
>  drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but not 
> used [-Wunused-but-set-variable]
>  drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’:
>  drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set but 
> not used [-Wunused-but-set-variable]
>  drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but not 
> used [-Wunused-but-set-variable]
> 
> Cc: Tomi Valkeinen 
> Cc: David Airlie 
> Cc: Daniel Vetter 
> Cc: Laurent Pinchart 
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones 

Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++---
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c 
> b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index eeccf40bae416..5929b320b3cfa 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -1128,13 +1128,12 @@ static void dsi_runtime_put(struct dsi_data *dsi)
>  
>  static void _dsi_print_reset_status(struct dsi_data *dsi)
>  {
> - u32 l;
>   int b0, b1, b2;
>  
>   /* A dummy read using the SCP interface to any DSIPHY register is
>* required after DSIPHY reset to complete the reset of the DSI complex
>* I/O. */
> - l = dsi_read_reg(dsi, DSI_DSIPHY_CFG5);
> + dsi_read_reg(dsi, DSI_DSIPHY_CFG5);
>  
>   if (dsi->data->quirks & DSI_QUIRK_REVERSE_TXCLKESC) {
>   b0 = 28;
> @@ -3940,7 +3939,6 @@ static int dsi_update(struct omap_dss_device *dssdev, 
> int channel,
>   void (*callback)(int, void *), void *data)
>  {
>   struct dsi_data *dsi = to_dsi_data(dssdev);
> - u16 dw, dh;
>  
>   dsi_perf_mark_setup(dsi);
>  
> @@ -3949,11 +3947,8 @@ static int dsi_update(struct omap_dss_device *dssdev, 
> int channel,
>   dsi->framedone_callback = callback;
>   dsi->framedone_data = data;
>  
> - dw = dsi->vm.hactive;
> - dh = dsi->vm.vactive;
> -
>  #ifdef DSI_PERF_MEASURE
> - dsi->update_bytes = dw * dh *
> + dsi->update_bytes = dsi->vm.hactive * dsi->vm.vactive *
>   dsi_get_pixel_size(dsi->pix_fmt) / 8;
>  #endif
>   dsi_update_screen_dispc(dsi);

-- 
Regards,

Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables

2020-11-05 Thread Tomi Valkeinen 
On 05/11/2020 16:45, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’:
>  drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but not 
> used [-Wunused-but-set-variable]
>  drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’:
>  drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set but 
> not used [-Wunused-but-set-variable]
>  drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but not 
> used [-Wunused-but-set-variable]
> 
> Cc: Tomi Valkeinen 
> Cc: David Airlie 
> Cc: Daniel Vetter 
> Cc: Laurent Pinchart 
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones 
> ---
>  drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++---
>  1 file changed, 2 insertions(+), 7 deletions(-)

I'd use "drm/omap: dsi: " subject prefix, the current one is fine too:

Reviewed-by: Tomi Valkeinen 

Should I pick this up or do you want to keep the series intact?

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables

2020-11-05 Thread Lee Jones 
On Thu, 05 Nov 2020, Tomi Valkeinen wrote:

> On 05/11/2020 16:45, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> > 
> >  drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’:
> >  drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but 
> > not used [-Wunused-but-set-variable]
> >  drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’:
> >  drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set but 
> > not used [-Wunused-but-set-variable]
> >  drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but 
> > not used [-Wunused-but-set-variable]
> > 
> > Cc: Tomi Valkeinen 
> > Cc: David Airlie 
> > Cc: Daniel Vetter 
> > Cc: Laurent Pinchart 
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Lee Jones 
> > ---
> >  drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++---
> >  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> I'd use "drm/omap: dsi: " subject prefix, the current one is fine too:
> 
> Reviewed-by: Tomi Valkeinen 
> 
> Should I pick this up or do you want to keep the series intact?

If you are in a position to take it, please do so.

I rebase every day, so it will just vanish from my working set.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables

2020-11-05 Thread Lee Jones 
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’:
 drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but not 
used [-Wunused-but-set-variable]
 drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’:
 drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set but not 
used [-Wunused-but-set-variable]
 drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but not 
used [-Wunused-but-set-variable]

Cc: Tomi Valkeinen 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: Laurent Pinchart 
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones 
---
 drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c 
b/drivers/gpu/drm/omapdrm/dss/dsi.c
index eeccf40bae416..5929b320b3cfa 100644
--- a/drivers/gpu/drm/omapdrm/dss/dsi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
@@ -1128,13 +1128,12 @@ static void dsi_runtime_put(struct dsi_data *dsi)
 
 static void _dsi_print_reset_status(struct dsi_data *dsi)
 {
-   u32 l;
int b0, b1, b2;
 
/* A dummy read using the SCP interface to any DSIPHY register is
 * required after DSIPHY reset to complete the reset of the DSI complex
 * I/O. */
-   l = dsi_read_reg(dsi, DSI_DSIPHY_CFG5);
+   dsi_read_reg(dsi, DSI_DSIPHY_CFG5);
 
if (dsi->data->quirks & DSI_QUIRK_REVERSE_TXCLKESC) {
b0 = 28;
@@ -3940,7 +3939,6 @@ static int dsi_update(struct omap_dss_device *dssdev, int 
channel,
void (*callback)(int, void *), void *data)
 {
struct dsi_data *dsi = to_dsi_data(dssdev);
-   u16 dw, dh;
 
dsi_perf_mark_setup(dsi);
 
@@ -3949,11 +3947,8 @@ static int dsi_update(struct omap_dss_device *dssdev, 
int channel,
dsi->framedone_callback = callback;
dsi->framedone_data = data;
 
-   dw = dsi->vm.hactive;
-   dh = dsi->vm.vactive;
-
 #ifdef DSI_PERF_MEASURE
-   dsi->update_bytes = dw * dh *
+   dsi->update_bytes = dsi->vm.hactive * dsi->vm.vactive *
dsi_get_pixel_size(dsi->pix_fmt) / 8;
 #endif
dsi_update_screen_dispc(dsi);
-- 
2.25.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel