subject:"\[PATCH 09\/13\] drm\/omap\: remove rfbi"

Re: [PATCH 09/13] drm/omap: remove rfbi

2017-05-12 Thread Laurent Pinchart

Hi Tomi,

Thank you for the patch.

On Friday 12 May 2017 13:41:38 Tomi Valkeinen wrote:
> The RFBI driver has not worked nor compiled for many years. There are
> very few boards out there that use RFBI, and no one has stepped up to
> fix it.
> 
> So let's remove the RFBI code that doesn't even compile.
> 
> Signed-off-by: Tomi Valkeinen 

Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/omapdrm/dss/Kconfig   |   13 -
>  drivers/gpu/drm/omapdrm/dss/Makefile  |1 -
>  drivers/gpu/drm/omapdrm/dss/core.c|6 -
>  drivers/gpu/drm/omapdrm/dss/dss.h |4 -
>  drivers/gpu/drm/omapdrm/dss/omapdss.h |   32 -
>  drivers/gpu/drm/omapdrm/dss/rfbi.c| 1075 --
>  6 files changed, 1131 deletions(-)
>  delete mode 100644 drivers/gpu/drm/omapdrm/dss/rfbi.c
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/Kconfig
> b/drivers/gpu/drm/omapdrm/dss/Kconfig index f53adb944a0d..8b87d5cf45fc
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/dss/Kconfig
> @@ -49,19 +49,6 @@ config OMAP2_DSS_DPI
>   help
> DPI Interface. This is the Parallel Display Interface.
> 
> -config OMAP2_DSS_RFBI
> - bool "RFBI support"
> - depends on BROKEN
> -default n
> - help
> -   MIPI DBI support (RFBI, Remote Framebuffer Interface, in Texas
> -   Instrument's terminology).
> -
> -   DBI is a bus between the host processor and a peripheral,
> -   such as a display or a framebuffer chip.
> -
> -   See http://www.mipi.org/ for DBI specifications.
> -
>  config OMAP2_DSS_VENC
>   bool "VENC support"
>  default y
> diff --git a/drivers/gpu/drm/omapdrm/dss/Makefile
> b/drivers/gpu/drm/omapdrm/dss/Makefile index 75ec30f231c7..688195e448c5
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/Makefile
> +++ b/drivers/gpu/drm/omapdrm/dss/Makefile
> @@ -8,7 +8,6 @@ obj-$(CONFIG_OMAP2_DSS) += omapdss.o
>  omapdss-y := core.o dss.o dss_features.o dispc.o dispc_coefs.o \
>   pll.o video-pll.o
>  omapdss-$(CONFIG_OMAP2_DSS_DPI) += dpi.o
> -omapdss-$(CONFIG_OMAP2_DSS_RFBI) += rfbi.o
>  omapdss-$(CONFIG_OMAP2_DSS_VENC) += venc.o
>  omapdss-$(CONFIG_OMAP2_DSS_SDI) += sdi.o
>  omapdss-$(CONFIG_OMAP2_DSS_DSI) += dsi.o
> diff --git a/drivers/gpu/drm/omapdrm/dss/core.c
> b/drivers/gpu/drm/omapdrm/dss/core.c index f056bffcab73..bdce4bfdf6e0
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/core.c
> +++ b/drivers/gpu/drm/omapdrm/dss/core.c
> @@ -208,9 +208,6 @@ static int (*dss_output_drv_reg_funcs[])(void)
> __initdata = { #ifdef CONFIG_OMAP2_DSS_DSI
>   dsi_init_platform_driver,
>  #endif
> -#ifdef CONFIG_OMAP2_DSS_RFBI
> - rfbi_init_platform_driver,
> -#endif
>  #ifdef CONFIG_OMAP2_DSS_VENC
>   venc_init_platform_driver,
>  #endif
> @@ -232,9 +229,6 @@ static void (*dss_output_drv_unreg_funcs[])(void) = {
>  #ifdef CONFIG_OMAP2_DSS_VENC
>   venc_uninit_platform_driver,
>  #endif
> -#ifdef CONFIG_OMAP2_DSS_RFBI
> - rfbi_uninit_platform_driver,
> -#endif
>  #ifdef CONFIG_OMAP2_DSS_DSI
>   dsi_uninit_platform_driver,
>  #endif
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.h
> b/drivers/gpu/drm/omapdrm/dss/dss.h index d8bf99a97571..8dbf35f3ab23 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.h
> @@ -382,10 +382,6 @@ void hdmi4_uninit_platform_driver(void);
>  int hdmi5_init_platform_driver(void) __init;
>  void hdmi5_uninit_platform_driver(void);
> 
> -/* RFBI */
> -int rfbi_init_platform_driver(void) __init;
> -void rfbi_uninit_platform_driver(void);
> -
> 
>  #ifdef CONFIG_OMAP2_DSS_COLLECT_IRQ_STATS
>  static inline void dss_collect_irq_stats(u32 irqstatus, unsigned *irq_arr)
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> b/drivers/gpu/drm/omapdrm/dss/omapdss.h index 3cbc9e49aa5a..8eb8315a6c95
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -126,11 +126,6 @@ enum omap_dss_trans_key_type {
>   OMAP_DSS_COLOR_KEY_VID_SRC = 1,
>  };
> 
> -enum omap_rfbi_te_mode {
> - OMAP_DSS_RFBI_TE_MODE_1 = 1,
> - OMAP_DSS_RFBI_TE_MODE_2 = 2,
> -};
> -
>  enum omap_dss_signal_level {
>   OMAPDSS_SIG_ACTIVE_LOW,
>   OMAPDSS_SIG_ACTIVE_HIGH,
> @@ -220,27 +215,6 @@ enum omap_dss_output_id {
>   OMAP_DSS_OUTPUT_HDMI= 1 << 6,
>  };
> 
> -/* RFBI */
> -
> -struct rfbi_timings {
> - int cs_on_time;
> - int cs_off_time;
> - int we_on_time;
> - int we_off_time;
> - int re_on_time;
> - int re_off_time;
> - int we_cycle_time;
> - int re_cycle_time;
> - int cs_pulse_width;
> - int access_time;
> -
> - int clk_div;
> -
> - u32 tim[5]; /* set by rfbi_convert_timings() */
> -
> - int converted;
> -};
> -
>  /* DSI */
> 
>  enum omap_dss_dsi_trans_mode {
> @@ -624,11 +598,6 @@ struct omap_dss_device {
> 
>   union {
>   struct {
> - u8 channel;
> -

[PATCH 09/13] drm/omap: remove rfbi

2017-05-12 Thread Tomi Valkeinen

The RFBI driver has not worked nor compiled for many years. There are
very few boards out there that use RFBI, and no one has stepped up to
fix it.

So let's remove the RFBI code that doesn't even compile.

Signed-off-by: Tomi Valkeinen 
---
 drivers/gpu/drm/omapdrm/dss/Kconfig   |   13 -
 drivers/gpu/drm/omapdrm/dss/Makefile  |1 -
 drivers/gpu/drm/omapdrm/dss/core.c|6 -
 drivers/gpu/drm/omapdrm/dss/dss.h |4 -
 drivers/gpu/drm/omapdrm/dss/omapdss.h |   32 -
 drivers/gpu/drm/omapdrm/dss/rfbi.c| 1075 -
 6 files changed, 1131 deletions(-)
 delete mode 100644 drivers/gpu/drm/omapdrm/dss/rfbi.c

diff --git a/drivers/gpu/drm/omapdrm/dss/Kconfig 
b/drivers/gpu/drm/omapdrm/dss/Kconfig
index f53adb944a0d..8b87d5cf45fc 100644
--- a/drivers/gpu/drm/omapdrm/dss/Kconfig
+++ b/drivers/gpu/drm/omapdrm/dss/Kconfig
@@ -49,19 +49,6 @@ config OMAP2_DSS_DPI
help
  DPI Interface. This is the Parallel Display Interface.
 
-config OMAP2_DSS_RFBI
-   bool "RFBI support"
-   depends on BROKEN
-default n
-   help
- MIPI DBI support (RFBI, Remote Framebuffer Interface, in Texas
- Instrument's terminology).
-
- DBI is a bus between the host processor and a peripheral,
- such as a display or a framebuffer chip.
-
- See http://www.mipi.org/ for DBI specifications.
-
 config OMAP2_DSS_VENC
bool "VENC support"
 default y
diff --git a/drivers/gpu/drm/omapdrm/dss/Makefile 
b/drivers/gpu/drm/omapdrm/dss/Makefile
index 75ec30f231c7..688195e448c5 100644
--- a/drivers/gpu/drm/omapdrm/dss/Makefile
+++ b/drivers/gpu/drm/omapdrm/dss/Makefile
@@ -8,7 +8,6 @@ obj-$(CONFIG_OMAP2_DSS) += omapdss.o
 omapdss-y := core.o dss.o dss_features.o dispc.o dispc_coefs.o \
pll.o video-pll.o
 omapdss-$(CONFIG_OMAP2_DSS_DPI) += dpi.o
-omapdss-$(CONFIG_OMAP2_DSS_RFBI) += rfbi.o
 omapdss-$(CONFIG_OMAP2_DSS_VENC) += venc.o
 omapdss-$(CONFIG_OMAP2_DSS_SDI) += sdi.o
 omapdss-$(CONFIG_OMAP2_DSS_DSI) += dsi.o
diff --git a/drivers/gpu/drm/omapdrm/dss/core.c 
b/drivers/gpu/drm/omapdrm/dss/core.c
index f056bffcab73..bdce4bfdf6e0 100644
--- a/drivers/gpu/drm/omapdrm/dss/core.c
+++ b/drivers/gpu/drm/omapdrm/dss/core.c
@@ -208,9 +208,6 @@ static int (*dss_output_drv_reg_funcs[])(void) __initdata = 
{
 #ifdef CONFIG_OMAP2_DSS_DSI
dsi_init_platform_driver,
 #endif
-#ifdef CONFIG_OMAP2_DSS_RFBI
-   rfbi_init_platform_driver,
-#endif
 #ifdef CONFIG_OMAP2_DSS_VENC
venc_init_platform_driver,
 #endif
@@ -232,9 +229,6 @@ static void (*dss_output_drv_unreg_funcs[])(void) = {
 #ifdef CONFIG_OMAP2_DSS_VENC
venc_uninit_platform_driver,
 #endif
-#ifdef CONFIG_OMAP2_DSS_RFBI
-   rfbi_uninit_platform_driver,
-#endif
 #ifdef CONFIG_OMAP2_DSS_DSI
dsi_uninit_platform_driver,
 #endif
diff --git a/drivers/gpu/drm/omapdrm/dss/dss.h 
b/drivers/gpu/drm/omapdrm/dss/dss.h
index d8bf99a97571..8dbf35f3ab23 100644
--- a/drivers/gpu/drm/omapdrm/dss/dss.h
+++ b/drivers/gpu/drm/omapdrm/dss/dss.h
@@ -382,10 +382,6 @@ void hdmi4_uninit_platform_driver(void);
 int hdmi5_init_platform_driver(void) __init;
 void hdmi5_uninit_platform_driver(void);
 
-/* RFBI */
-int rfbi_init_platform_driver(void) __init;
-void rfbi_uninit_platform_driver(void);
-
 
 #ifdef CONFIG_OMAP2_DSS_COLLECT_IRQ_STATS
 static inline void dss_collect_irq_stats(u32 irqstatus, unsigned *irq_arr)
diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h 
b/drivers/gpu/drm/omapdrm/dss/omapdss.h
index 3cbc9e49aa5a..8eb8315a6c95 100644
--- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
+++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
@@ -126,11 +126,6 @@ enum omap_dss_trans_key_type {
OMAP_DSS_COLOR_KEY_VID_SRC = 1,
 };
 
-enum omap_rfbi_te_mode {
-   OMAP_DSS_RFBI_TE_MODE_1 = 1,
-   OMAP_DSS_RFBI_TE_MODE_2 = 2,
-};
-
 enum omap_dss_signal_level {
OMAPDSS_SIG_ACTIVE_LOW,
OMAPDSS_SIG_ACTIVE_HIGH,
@@ -220,27 +215,6 @@ enum omap_dss_output_id {
OMAP_DSS_OUTPUT_HDMI= 1 << 6,
 };
 
-/* RFBI */
-
-struct rfbi_timings {
-   int cs_on_time;
-   int cs_off_time;
-   int we_on_time;
-   int we_off_time;
-   int re_on_time;
-   int re_off_time;
-   int we_cycle_time;
-   int re_cycle_time;
-   int cs_pulse_width;
-   int access_time;
-
-   int clk_div;
-
-   u32 tim[5]; /* set by rfbi_convert_timings() */
-
-   int converted;
-};
-
 /* DSI */
 
 enum omap_dss_dsi_trans_mode {
@@ -624,11 +598,6 @@ struct omap_dss_device {
 
union {
struct {
-   u8 channel;
-   u8 data_lines;
-   } rfbi;
-
-   struct {
int module;
} dsi;
} phy;
@@ -642,7 +611,6 @@ struct omap_dss_device {
 
struct {
u8 pixel_size;
-   struct rfbi_timings rfbi_timings;
} ctrl;
 
const char *name;
diff

Re: [PATCH 09/13] drm/omap: remove rfbi

[PATCH 09/13] drm/omap: remove rfbi

2 matches

Site Navigation

Mail list logo

Footer information