[PATCH 1/1] drm: Fix comment about drm_exit which has been replaced by drm_platform_exit in 2.6.39
Hello Dave, On 10/01/13 02:57, Dave Airlie wrote: >> /** >> - * Called via drm_exit() at module unload time or when pci device is >> + * Called via drm_platform_exit() at module unload time or when pci device >> is >>* unplugged. > > Not really correct, its called from drm_pci_exit, drm_usb_exit and > drm_platform_exit now. You are totally right, just changing that bit of the comment did not fix it completely. drm_pci/usb_exit will be called on unload and disconnect of the device (which is actually quite rare on PCI). And the comment does not even mention usb. Would you like a new patch with a completely new comment? Should it be removed completely? Or will you fix it yourself when you come around to it? Thanks, Philippe
[PATCH 1/1] drm: Fix comment about drm_exit which has been replaced by drm_platform_exit in 2.6.39
On Tue, Jan 8, 2013 at 12:10 AM, Philippe De Swert wrote: > Trivial comment fix. Since drm_exit() was removed in 2.6.39 (commit 8410ea3b > ). As such the comment > is incorrect. drm_put_dev() is now called from drm_platform_exit() or when > the pci device is "unplugged". > > Signed-off-by: Philippe De Swert > --- > drivers/gpu/drm/drm_stub.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c > index 200e104..b39f591 100644 > --- a/drivers/gpu/drm/drm_stub.c > +++ b/drivers/gpu/drm/drm_stub.c > @@ -445,7 +445,7 @@ static void drm_unplug_minor(struct drm_minor *minor) > } > > /** > - * Called via drm_exit() at module unload time or when pci device is > + * Called via drm_platform_exit() at module unload time or when pci device is > * unplugged. Not really correct, its called from drm_pci_exit, drm_usb_exit and drm_platform_exit now. Dave.
Re: [PATCH 1/1] drm: Fix comment about drm_exit which has been replaced by drm_platform_exit in 2.6.39
Hello Dave, On 10/01/13 02:57, Dave Airlie wrote: /** - * Called via drm_exit() at module unload time or when pci device is + * Called via drm_platform_exit() at module unload time or when pci device is * unplugged. Not really correct, its called from drm_pci_exit, drm_usb_exit and drm_platform_exit now. You are totally right, just changing that bit of the comment did not fix it completely. drm_pci/usb_exit will be called on unload and disconnect of the device (which is actually quite rare on PCI). And the comment does not even mention usb. Would you like a new patch with a completely new comment? Should it be removed completely? Or will you fix it yourself when you come around to it? Thanks, Philippe ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/1] drm: Fix comment about drm_exit which has been replaced by drm_platform_exit in 2.6.39
On Tue, Jan 8, 2013 at 12:10 AM, Philippe De Swert philippe.desw...@jollamobile.com wrote: Trivial comment fix. Since drm_exit() was removed in 2.6.39 (commit 8410ea3b ). As such the comment is incorrect. drm_put_dev() is now called from drm_platform_exit() or when the pci device is unplugged. Signed-off-by: Philippe De Swert philippe.desw...@jollamobile.com --- drivers/gpu/drm/drm_stub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 200e104..b39f591 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -445,7 +445,7 @@ static void drm_unplug_minor(struct drm_minor *minor) } /** - * Called via drm_exit() at module unload time or when pci device is + * Called via drm_platform_exit() at module unload time or when pci device is * unplugged. Not really correct, its called from drm_pci_exit, drm_usb_exit and drm_platform_exit now. Dave. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 1/1] drm: Fix comment about drm_exit which has been replaced by drm_platform_exit in 2.6.39
Trivial comment fix. Since drm_exit() was removed in 2.6.39 (commit 8410ea3b ). As such the comment is incorrect. drm_put_dev() is now called from drm_platform_exit() or when the pci device is "unplugged". Signed-off-by: Philippe De Swert --- drivers/gpu/drm/drm_stub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 200e104..b39f591 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -445,7 +445,7 @@ static void drm_unplug_minor(struct drm_minor *minor) } /** - * Called via drm_exit() at module unload time or when pci device is + * Called via drm_platform_exit() at module unload time or when pci device is * unplugged. * * Cleans up all DRM device, calling drm_lastclose(). -- 1.7.9.5
[PATCH 1/1] drm: Fix comment about drm_exit which has been replaced by drm_platform_exit in 2.6.39
Trivial comment fix. Since drm_exit() was removed in 2.6.39 (commit 8410ea3b ). As such the comment is incorrect. drm_put_dev() is now called from drm_platform_exit() or when the pci device is unplugged. Signed-off-by: Philippe De Swert philippe.desw...@jollamobile.com --- drivers/gpu/drm/drm_stub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 200e104..b39f591 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -445,7 +445,7 @@ static void drm_unplug_minor(struct drm_minor *minor) } /** - * Called via drm_exit() at module unload time or when pci device is + * Called via drm_platform_exit() at module unload time or when pci device is * unplugged. * * Cleans up all DRM device, calling drm_lastclose(). -- 1.7.9.5 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
