Re: [PATCH 1/4] dma-buf: dma_fence_put is NULL save

2017-07-26 Thread Alex Deucher 
On Wed, Jul 26, 2017 at 9:12 AM, Christian König
 wrote:
> From: Christian König 
>
> No need to check.
>
> Signed-off-by: Christian König 

Patch title: s/save/safe/
With that fixed:
Reviewed-by: Alex Deucher 

> ---
>  drivers/dma-buf/reservation.c | 6 ++
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c
> index 9d4316d..dfcd4ef3 100644
> --- a/drivers/dma-buf/reservation.c
> +++ b/drivers/dma-buf/reservation.c
> @@ -195,8 +195,7 @@ reservation_object_add_shared_replace(struct 
> reservation_object *obj,
> if (old)
> kfree_rcu(old, rcu);
>
> -   if (old_fence)
> -   dma_fence_put(old_fence);
> +   dma_fence_put(old_fence);
>  }
>
>  /**
> @@ -258,8 +257,7 @@ void reservation_object_add_excl_fence(struct 
> reservation_object *obj,
> dma_fence_put(rcu_dereference_protected(old->shared[i],
> 
> reservation_object_held(obj)));
>
> -   if (old_fence)
> -   dma_fence_put(old_fence);
> +   dma_fence_put(old_fence);
>  }
>  EXPORT_SYMBOL(reservation_object_add_excl_fence);
>
> --
> 2.7.4
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/4] dma-buf: dma_fence_put is NULL save

2017-07-26 Thread Christian König 
From: Christian König 

No need to check.

Signed-off-by: Christian König 
---
 drivers/dma-buf/reservation.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c
index 9d4316d..dfcd4ef3 100644
--- a/drivers/dma-buf/reservation.c
+++ b/drivers/dma-buf/reservation.c
@@ -195,8 +195,7 @@ reservation_object_add_shared_replace(struct 
reservation_object *obj,
if (old)
kfree_rcu(old, rcu);
 
-   if (old_fence)
-   dma_fence_put(old_fence);
+   dma_fence_put(old_fence);
 }
 
 /**
@@ -258,8 +257,7 @@ void reservation_object_add_excl_fence(struct 
reservation_object *obj,
dma_fence_put(rcu_dereference_protected(old->shared[i],
reservation_object_held(obj)));
 
-   if (old_fence)
-   dma_fence_put(old_fence);
+   dma_fence_put(old_fence);
 }
 EXPORT_SYMBOL(reservation_object_add_excl_fence);
 
-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel