Re: [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check

[Philippe CORNU]

Dear Fabio,


On 12/18/2017 02:02 PM, Fabio Estevam wrote:
> From: Fabio Estevam 
> 
> devm_ioremap_resource() already checks if the resource is NULL, so
> remove the unnecessary platform_get_resource() error check.
> 
> Cc: Archit Taneja 
> Signed-off-by: Fabio Estevam 
> ---
>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c 
> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index d9cca4f..5db4cbb 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -860,9 +860,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
>   
>   if (!plat_data->base) {
>   res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return ERR_PTR(-ENODEV);
> -

Many thanks for this cleanup.

Reviewed-by: Philippe Cornu 

Philippe :-)

>   dsi->base = devm_ioremap_resource(dev, res);
>   if (IS_ERR(dsi->base))
>   return ERR_PTR(-ENODEV);
> 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check

[Fabio Estevam]

From: Fabio Estevam 

devm_ioremap_resource() already checks if the resource is NULL, so
remove the unnecessary platform_get_resource() error check.

Cc: Archit Taneja 
Signed-off-by: Fabio Estevam 
---
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c 
b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index d9cca4f..5db4cbb 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -860,9 +860,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
 
if (!plat_data->base) {
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-   if (!res)
-   return ERR_PTR(-ENODEV);
-
dsi->base = devm_ioremap_resource(dev, res);
if (IS_ERR(dsi->base))
return ERR_PTR(-ENODEV);
-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel