Re: [PATCH 11/13] drm/omap: remove legacy get_resolution

2017-05-12 Thread Laurent Pinchart 
Hi Tomi,

Thank you for the patch.

On Friday 12 May 2017 13:41:40 Tomi Valkeinen wrote:
> get_resolution is not used, remove it.
> 
> Signed-off-by: Tomi Valkeinen 

Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c  |  2 --
>  drivers/gpu/drm/omapdrm/displays/connector-dvi.c|  2 --
>  drivers/gpu/drm/omapdrm/displays/connector-hdmi.c   |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-dpi.c|  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c |  9 -
>  drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c  |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c |  2 --
>  drivers/gpu/drm/omapdrm/dss/display.c   | 10 --
> drivers/gpu/drm/omapdrm/dss/omapdss.h   |  5 - 12
> files changed, 42 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
> b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c index
> 8453b1103abd..542a76503fbd 100644
> --- a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
> +++ b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
> @@ -171,8 +171,6 @@ static struct omap_dss_driver tvc_driver = {
>   .get_timings= tvc_get_timings,
>   .check_timings  = tvc_check_timings,
> 
> - .get_resolution = omapdss_default_get_resolution,
> -
>   .get_wss= tvc_get_wss,
>   .set_wss= tvc_set_wss,
>  };
> diff --git a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
> b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c index
> 8720b2dcb316..05fa24a518c8 100644
> --- a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
> @@ -227,8 +227,6 @@ static struct omap_dss_driver dvic_driver = {
>   .get_timings= dvic_get_timings,
>   .check_timings  = dvic_check_timings,
> 
> - .get_resolution = omapdss_default_get_resolution,
> -
>   .read_edid  = dvic_read_edid,
>   .detect = dvic_detect,
>  };
> diff --git a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c index
> 555e193c9732..79cb69f1acf5 100644
> --- a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> @@ -195,8 +195,6 @@ static struct omap_dss_driver hdmic_driver = {
>   .get_timings= hdmic_get_timings,
>   .check_timings  = hdmic_check_timings,
> 
> - .get_resolution = omapdss_default_get_resolution,
> -
>   .read_edid  = hdmic_read_edid,
>   .detect = hdmic_detect,
>   .set_hdmi_mode  = hdmic_set_hdmi_mode,
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c index
> cc5920b476d6..49ceed7f1d11 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> @@ -159,8 +159,6 @@ static struct omap_dss_driver panel_dpi_ops = {
>   .set_timings= panel_dpi_set_timings,
>   .get_timings= panel_dpi_get_timings,
>   .check_timings  = panel_dpi_check_timings,
> -
> - .get_resolution = omapdss_default_get_resolution,
>  };
> 
>  static int panel_dpi_probe_of(struct platform_device *pdev)
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c index
> 1fbbe4c4bce6..76787a75a4dc 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> @@ -379,13 +379,6 @@ static const struct backlight_ops dsicm_bl_ops = {
>   .update_status  = dsicm_bl_update_status,
>  };
> 
> -static void dsicm_get_resolution(struct omap_dss_device *dssdev,
> - u16 *xres, u16 *yres)
> -{
> - *xres = dssdev->panel.vm.hactive;
> - *yres = dssdev->panel.vm.vactive;
> -}
> -
>  static ssize_t dsicm_num_errors_show(struct device *dev,
>   struct device_attribute *attr, char *buf)
>  {
> @@ -1116,8 +1109,6 @@ static struct omap_dss_driver dsicm_ops = {
>   .update = dsicm_update,
>   .sync   = dsicm_sync,
> 
> - .get_resolution = dsicm_get_resolution,
> -
>   .enable_te  = dsicm_enable_te,
>   .get_te = dsicm_get_te,
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c index
> 451e1608a1db..c90474afaebd 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> @@ -226,8 +226,6 @@ static struct om

[PATCH 11/13] drm/omap: remove legacy get_resolution

2017-05-12 Thread Tomi Valkeinen 
get_resolution is not used, remove it.

Signed-off-by: Tomi Valkeinen 
---
 drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c  |  2 --
 drivers/gpu/drm/omapdrm/displays/connector-dvi.c|  2 --
 drivers/gpu/drm/omapdrm/displays/connector-hdmi.c   |  2 --
 drivers/gpu/drm/omapdrm/displays/panel-dpi.c|  2 --
 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c |  9 -
 drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c |  2 --
 drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c |  2 --
 drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c  |  2 --
 drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c |  2 --
 drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c |  2 --
 drivers/gpu/drm/omapdrm/dss/display.c   | 10 --
 drivers/gpu/drm/omapdrm/dss/omapdss.h   |  5 -
 12 files changed, 42 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c 
b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
index 8453b1103abd..542a76503fbd 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
@@ -171,8 +171,6 @@ static struct omap_dss_driver tvc_driver = {
.get_timings= tvc_get_timings,
.check_timings  = tvc_check_timings,
 
-   .get_resolution = omapdss_default_get_resolution,
-
.get_wss= tvc_get_wss,
.set_wss= tvc_set_wss,
 };
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c 
b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
index 8720b2dcb316..05fa24a518c8 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
@@ -227,8 +227,6 @@ static struct omap_dss_driver dvic_driver = {
.get_timings= dvic_get_timings,
.check_timings  = dvic_check_timings,
 
-   .get_resolution = omapdss_default_get_resolution,
-
.read_edid  = dvic_read_edid,
.detect = dvic_detect,
 };
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c 
b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
index 555e193c9732..79cb69f1acf5 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
@@ -195,8 +195,6 @@ static struct omap_dss_driver hdmic_driver = {
.get_timings= hdmic_get_timings,
.check_timings  = hdmic_check_timings,
 
-   .get_resolution = omapdss_default_get_resolution,
-
.read_edid  = hdmic_read_edid,
.detect = hdmic_detect,
.set_hdmi_mode  = hdmic_set_hdmi_mode,
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c 
b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
index cc5920b476d6..49ceed7f1d11 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
@@ -159,8 +159,6 @@ static struct omap_dss_driver panel_dpi_ops = {
.set_timings= panel_dpi_set_timings,
.get_timings= panel_dpi_get_timings,
.check_timings  = panel_dpi_check_timings,
-
-   .get_resolution = omapdss_default_get_resolution,
 };
 
 static int panel_dpi_probe_of(struct platform_device *pdev)
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c 
b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
index 1fbbe4c4bce6..76787a75a4dc 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
@@ -379,13 +379,6 @@ static const struct backlight_ops dsicm_bl_ops = {
.update_status  = dsicm_bl_update_status,
 };
 
-static void dsicm_get_resolution(struct omap_dss_device *dssdev,
-   u16 *xres, u16 *yres)
-{
-   *xres = dssdev->panel.vm.hactive;
-   *yres = dssdev->panel.vm.vactive;
-}
-
 static ssize_t dsicm_num_errors_show(struct device *dev,
struct device_attribute *attr, char *buf)
 {
@@ -1116,8 +1109,6 @@ static struct omap_dss_driver dsicm_ops = {
.update = dsicm_update,
.sync   = dsicm_sync,
 
-   .get_resolution = dsicm_get_resolution,
-
.enable_te  = dsicm_enable_te,
.get_te = dsicm_get_te,
 
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c 
b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
index 451e1608a1db..c90474afaebd 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
@@ -226,8 +226,6 @@ static struct omap_dss_driver lb035q02_ops = {
.set_timings= lb035q02_set_timings,
.get_timings= lb035q02_get_timings,
.check_timings  = lb035q02_check_timings,
-
-   .get_resolution = omapdss_default_get_resolution,
 };
 
 static int lb035q02