Re: [PATCH 12/13] drm/omap: remove unused fields

2017-05-12 Thread Laurent Pinchart
Hi Tomi,

Thank you for the patch.

On Friday 12 May 2017 13:41:41 Tomi Valkeinen wrote:
> Remove unused fields in struct omap_dss_device.
> 
> Signed-off-by: Tomi Valkeinen 

Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/omapdrm/dss/omapdss.h | 17 -
>  1 file changed, 17 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> b/drivers/gpu/drm/omapdrm/dss/omapdss.h index 74408b0ece26..3cf42e5ddf3e
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -596,12 +596,6 @@ struct omap_dss_device {
>   enum omap_display_type type;
>   enum omap_display_type output_type;
> 
> - union {
> - struct {
> - int module;
> - } dsi;
> - } phy;
> -
>   struct {
>   struct videomode vm;
> 
> @@ -609,17 +603,8 @@ struct omap_dss_device {
>   enum omap_dss_dsi_mode dsi_mode;
>   } panel;
> 
> - struct {
> - u8 pixel_size;
> - } ctrl;
> -
>   const char *name;
> 
> - /* used to match device to driver */
> - const char *driver_name;
> -
> - void *data;
> -
>   struct omap_dss_driver *driver;
> 
>   union {
> @@ -655,8 +640,6 @@ struct omap_dss_device {
>   int port_num;
> 
>   /* dynamic fields */
> - struct omap_overlay_manager *manager;
> -
>   struct omap_dss_device *dst;
>  };

-- 
Regards,

Laurent Pinchart

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH 12/13] drm/omap: remove unused fields

2017-05-12 Thread Tomi Valkeinen
Remove unused fields in struct omap_dss_device.

Signed-off-by: Tomi Valkeinen 
---
 drivers/gpu/drm/omapdrm/dss/omapdss.h | 17 -
 1 file changed, 17 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h 
b/drivers/gpu/drm/omapdrm/dss/omapdss.h
index 74408b0ece26..3cf42e5ddf3e 100644
--- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
+++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
@@ -596,12 +596,6 @@ struct omap_dss_device {
enum omap_display_type type;
enum omap_display_type output_type;
 
-   union {
-   struct {
-   int module;
-   } dsi;
-   } phy;
-
struct {
struct videomode vm;
 
@@ -609,17 +603,8 @@ struct omap_dss_device {
enum omap_dss_dsi_mode dsi_mode;
} panel;
 
-   struct {
-   u8 pixel_size;
-   } ctrl;
-
const char *name;
 
-   /* used to match device to driver */
-   const char *driver_name;
-
-   void *data;
-
struct omap_dss_driver *driver;
 
union {
@@ -655,8 +640,6 @@ struct omap_dss_device {
int port_num;
 
/* dynamic fields */
-   struct omap_overlay_manager *manager;
-
struct omap_dss_device *dst;
 };
 
-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel