Re: [PATCH 12/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_write_byte_to_dpcd'

2020-11-05 Thread Sam Ravnborg
Hi Lee

On Thu, Nov 05, 2020 at 02:45:10PM +, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:571:5: warning: no 
> previous prototype for ‘analogix_dp_write_byte_to_dpcd’ [-Wmissing-prototypes]
> 
> Cc: Andrzej Hajda 
> Cc: Neil Armstrong 
> Cc: Laurent Pinchart 
> Cc: Jonas Karlman 
> Cc: Jernej Skrabec 
> Cc: David Airlie 
> Cc: Daniel Vetter 
> Cc: Jason Yan 
> Cc: Sam Ravnborg 
> Cc: Jingoo Han 
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones 

I folded in the other analogix_dp_reg.c patch when I applied this.
So we have the full removal in one patch.

Sam
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH 12/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_write_byte_to_dpcd'

2020-11-05 Thread Lee Jones
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:571:5: warning: no previous 
prototype for ‘analogix_dp_write_byte_to_dpcd’ [-Wmissing-prototypes]

Cc: Andrzej Hajda 
Cc: Neil Armstrong 
Cc: Laurent Pinchart 
Cc: Jonas Karlman 
Cc: Jernej Skrabec 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: Jason Yan 
Cc: Sam Ravnborg 
Cc: Jingoo Han 
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones 
---
 .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 44 ---
 1 file changed, 44 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c 
b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
index fafb4b492ea04..9ce45c757f8c8 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
@@ -568,50 +568,6 @@ static int analogix_dp_start_aux_transaction(struct 
analogix_dp_device *dp)
return retval;
 }
 
-int analogix_dp_write_byte_to_dpcd(struct analogix_dp_device *dp,
-  unsigned int reg_addr,
-  unsigned char data)
-{
-   u32 reg;
-   int i;
-   int retval;
-
-   for (i = 0; i < 3; i++) {
-   /* Clear AUX CH data buffer */
-   reg = BUF_CLR;
-   writel(reg, dp->reg_base + ANALOGIX_DP_BUFFER_DATA_CTL);
-
-   /* Select DPCD device address */
-   reg = AUX_ADDR_7_0(reg_addr);
-   writel(reg, dp->reg_base + ANALOGIX_DP_AUX_ADDR_7_0);
-   reg = AUX_ADDR_15_8(reg_addr);
-   writel(reg, dp->reg_base + ANALOGIX_DP_AUX_ADDR_15_8);
-   reg = AUX_ADDR_19_16(reg_addr);
-   writel(reg, dp->reg_base + ANALOGIX_DP_AUX_ADDR_19_16);
-
-   /* Write data buffer */
-   reg = (unsigned int)data;
-   writel(reg, dp->reg_base + ANALOGIX_DP_BUF_DATA_0);
-
-   /*
-* Set DisplayPort transaction and write 1 byte
-* If bit 3 is 1, DisplayPort transaction.
-* If Bit 3 is 0, I2C transaction.
-*/
-   reg = AUX_TX_COMM_DP_TRANSACTION | AUX_TX_COMM_WRITE;
-   writel(reg, dp->reg_base + ANALOGIX_DP_AUX_CH_CTL_1);
-
-   /* Start AUX transaction */
-   retval = analogix_dp_start_aux_transaction(dp);
-   if (retval == 0)
-   break;
-
-   dev_dbg(dp->dev, "%s: Aux Transaction fail!\n", __func__);
-   }
-
-   return retval;
-}
-
 void analogix_dp_set_link_bandwidth(struct analogix_dp_device *dp, u32 bwtype)
 {
u32 reg;
-- 
2.25.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel