Re: [PATCH 12/30] fbdev/mb862xxfb: Output messages with fb_dbg() and fb_err()

[Javier Martinez Canillas]

Thomas Zimmermann  writes:

> Fix cases were output helpers are called with struct fb_info.dev.
> Use fb_dbg() and fb_err() instead. Prepares fbdev for making struct
> fb_info.dev optional.
>
> Signed-off-by: Thomas Zimmermann 
> ---

Reviewed-by: Javier Martinez Canillas 

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

[PATCH 12/30] fbdev/mb862xxfb: Output messages with fb_dbg() and fb_err()

[Thomas Zimmermann]

Fix cases were output helpers are called with struct fb_info.dev.
Use fb_dbg() and fb_err() instead. Prepares fbdev for making struct
fb_info.dev optional.

Signed-off-by: Thomas Zimmermann 
---
 drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c 
b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
index b5c8fcab9940..99729611e04d 100644
--- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
+++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
@@ -112,8 +112,7 @@ static int mb862xxfb_check_var(struct fb_var_screeninfo 
*var,
 {
unsigned long tmp;
 
-   if (fbi->dev)
-   dev_dbg(fbi->dev, "%s\n", __func__);
+   fb_dbg(fbi, "%s\n", __func__);
 
/* check if these values fit into the registers */
if (var->hsync_len > 255 || var->vsync_len > 255)
@@ -290,7 +289,7 @@ static int mb862xxfb_blank(int mode, struct fb_info *fbi)
struct mb862xxfb_par  *par = fbi->par;
unsigned long reg;
 
-   dev_dbg(fbi->dev, "blank mode=%d\n", mode);
+   fb_dbg(fbi, "blank mode=%d\n", mode);
 
switch (mode) {
case FB_BLANK_POWERDOWN:
@@ -1138,7 +1137,7 @@ static void mb862xx_pci_remove(struct pci_dev *pdev)
struct mb862xxfb_par *par = fbi->par;
unsigned long reg;
 
-   dev_dbg(fbi->dev, "%s release\n", fbi->fix.id);
+   fb_dbg(fbi, "%s release\n", fbi->fix.id);
 
/* display off */
reg = inreg(disp, GC_DCM1);
-- 
2.40.1