Re: [PATCH 2/2] drm/todo: Add levels
On Tue, Oct 22, 2019 at 7:33 PM Thomas Zimmermann wrote: > > Hi > > Am 22.10.19 um 17:25 schrieb Daniel Vetter: > > Should help new people pick suitable tasks. > > > > Cc: Rodrigo Siqueira > > Cc: Manasi Navare > > Cc: Sean Paul > > Signed-off-by: Daniel Vetter > > --- > > Documentation/gpu/todo.rst | 73 ++ > > 1 file changed, 73 insertions(+) > > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > index 9ac102922712..73c51b5a0997 100644 > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -7,6 +7,22 @@ TODO list > > This section contains a list of smaller janitorial tasks in the kernel DRM > > graphics subsystem useful as newbie projects. Or for slow rainy days. > > > > +Difficulty > > +-- > > + > > +To make it easier task are categorized into different levels: > > + > > +Starter: Good tasks to get started with the DRM subsystem. > > + > > +Intermediate: Tasks which need some experience with working in the DRM > > +subsystem, or some specific GPU/display graphics knowledge. For debugging > > issue > > +it's good to have the relevant hardware (or a virtual driver set up) > > available > > +for testing. > > + > > +Advanced: Tricky tasks that need fairly good understanding of the DRM > > subsystem > > +and graphics topics. Generally need the relevant hardware for development > > and > > +testing. > > I like this idea. > > Acked-by: Thomas Zimmermann > > But please see my comment further below. > > > + > > Subsystem-wide refactorings > > === > > > > @@ -20,6 +36,8 @@ implementations), and then remove it. > > > > Contact: Daniel Vetter, respective driver maintainers > > > > +Level: Intermediate > > + > > Convert existing KMS drivers to atomic modesetting > > -- > > > > @@ -38,6 +56,8 @@ do by directly using the new atomic helper driver > > callbacks. > > > > Contact: Daniel Vetter, respective driver maintainers > > > > +Level: Advanced > > + > > Clean up the clipped coordination confusion around planes > > - > > > > @@ -50,6 +70,8 @@ helpers. > > > > Contact: Ville Syrjälä, Daniel Vetter, driver maintainers > > > > +Level: Advanced > > + > > Convert early atomic drivers to async commit helpers > > > > > > @@ -63,6 +85,8 @@ events for atomic commits correctly. But fixing these > > bugs is good anyway. > > > > Contact: Daniel Vetter, respective driver maintainers > > > > +Level: Advanced > > + > > Fallout from atomic KMS > > --- > > > > @@ -91,6 +115,8 @@ interfaces to fix these issues: > > > > Contact: Daniel Vetter > > > > +Level: Intermediate > > + > > Get rid of dev->struct_mutex from GEM drivers > > - > > > > @@ -114,6 +140,8 @@ fine-grained per-buffer object and per-context lockings > > scheme. Currently only t > > > > Contact: Daniel Vetter, respective driver maintainers > > > > +Level: Advanced > > + > > Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* > > equivalent > > > > > > > > @@ -129,6 +157,8 @@ are better. > > > > Contact: Sean Paul, Maintainer of the driver you plan to convert > > > > +Level: Starter > > + > > Convert drivers to use simple modeset suspend/resume > > > > > > @@ -139,6 +169,8 @@ of the atomic suspend/resume code in older atomic > > modeset drivers. > > > > Contact: Maintainer of the driver you plan to convert > > > > +Level: Intermediate > > + > > Convert drivers to use drm_fb_helper_fbdev_setup/teardown() > > --- > > > > @@ -157,6 +189,8 @@ probably use drm_fb_helper_fbdev_teardown(). > > > > Contact: Maintainer of the driver you plan to convert > > > > +Level: Intermediate > > + > > Clean up mmap forwarding > > > > > > @@ -166,6 +200,8 @@ There's drm_gem_prime_mmap() for this now, but still > > needs to be rolled out. > > > > Contact: Daniel Vetter > > > > +Level: Intermediate > > + > > Generic fbdev defio support > > --- > > > > @@ -196,6 +232,8 @@ Might be good to also have some igt testcases for this. > > > > Contact: Daniel Vetter, Noralf Tronnes > > > > +Level: Advanced > > + > > idr_init_base() > > --- > > > > @@ -206,6 +244,8 @@ efficient. > > > > Contact: Daniel Vetter > > > > +Level: Starter > > + > > struct drm_gem_object_funcs > > --- > > > > @@ -216,6 +256,8 @@ We also need a 2nd version of the CMA define that > > doesn't require the > > vmapping to be present (different hook for prime importing). Plus this > > needs to > > be rolled out to all drivers using their own implementations,
Re: [PATCH 2/2] drm/todo: Add levels
Hi Am 22.10.19 um 17:25 schrieb Daniel Vetter: > Should help new people pick suitable tasks. > > Cc: Rodrigo Siqueira > Cc: Manasi Navare > Cc: Sean Paul > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 73 ++ > 1 file changed, 73 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 9ac102922712..73c51b5a0997 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -7,6 +7,22 @@ TODO list > This section contains a list of smaller janitorial tasks in the kernel DRM > graphics subsystem useful as newbie projects. Or for slow rainy days. > > +Difficulty > +-- > + > +To make it easier task are categorized into different levels: > + > +Starter: Good tasks to get started with the DRM subsystem. > + > +Intermediate: Tasks which need some experience with working in the DRM > +subsystem, or some specific GPU/display graphics knowledge. For debugging > issue > +it's good to have the relevant hardware (or a virtual driver set up) > available > +for testing. > + > +Advanced: Tricky tasks that need fairly good understanding of the DRM > subsystem > +and graphics topics. Generally need the relevant hardware for development and > +testing. I like this idea. Acked-by: Thomas Zimmermann But please see my comment further below. > + > Subsystem-wide refactorings > === > > @@ -20,6 +36,8 @@ implementations), and then remove it. > > Contact: Daniel Vetter, respective driver maintainers > > +Level: Intermediate > + > Convert existing KMS drivers to atomic modesetting > -- > > @@ -38,6 +56,8 @@ do by directly using the new atomic helper driver callbacks. > > Contact: Daniel Vetter, respective driver maintainers > > +Level: Advanced > + > Clean up the clipped coordination confusion around planes > - > > @@ -50,6 +70,8 @@ helpers. > > Contact: Ville Syrjälä, Daniel Vetter, driver maintainers > > +Level: Advanced > + > Convert early atomic drivers to async commit helpers > > > @@ -63,6 +85,8 @@ events for atomic commits correctly. But fixing these bugs > is good anyway. > > Contact: Daniel Vetter, respective driver maintainers > > +Level: Advanced > + > Fallout from atomic KMS > --- > > @@ -91,6 +115,8 @@ interfaces to fix these issues: > > Contact: Daniel Vetter > > +Level: Intermediate > + > Get rid of dev->struct_mutex from GEM drivers > - > > @@ -114,6 +140,8 @@ fine-grained per-buffer object and per-context lockings > scheme. Currently only t > > Contact: Daniel Vetter, respective driver maintainers > > +Level: Advanced > + > Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* equivalent > > > @@ -129,6 +157,8 @@ are better. > > Contact: Sean Paul, Maintainer of the driver you plan to convert > > +Level: Starter > + > Convert drivers to use simple modeset suspend/resume > > > @@ -139,6 +169,8 @@ of the atomic suspend/resume code in older atomic modeset > drivers. > > Contact: Maintainer of the driver you plan to convert > > +Level: Intermediate > + > Convert drivers to use drm_fb_helper_fbdev_setup/teardown() > --- > > @@ -157,6 +189,8 @@ probably use drm_fb_helper_fbdev_teardown(). > > Contact: Maintainer of the driver you plan to convert > > +Level: Intermediate > + > Clean up mmap forwarding > > > @@ -166,6 +200,8 @@ There's drm_gem_prime_mmap() for this now, but still > needs to be rolled out. > > Contact: Daniel Vetter > > +Level: Intermediate > + > Generic fbdev defio support > --- > > @@ -196,6 +232,8 @@ Might be good to also have some igt testcases for this. > > Contact: Daniel Vetter, Noralf Tronnes > > +Level: Advanced > + > idr_init_base() > --- > > @@ -206,6 +244,8 @@ efficient. > > Contact: Daniel Vetter > > +Level: Starter > + > struct drm_gem_object_funcs > --- > > @@ -216,6 +256,8 @@ We also need a 2nd version of the CMA define that doesn't > require the > vmapping to be present (different hook for prime importing). Plus this needs > to > be rolled out to all drivers using their own implementations, too. > > +Level: Intermediate > + > Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate > - > > @@ -231,6 +273,8 @@ As a reference, take a look at the conversions already > completed in drm core. > > Contact: Sean Paul, respective driver maintainers > >
Re: [PATCH 2/2] drm/todo: Add levels
On Tue, Oct 22, 2019 at 05:25:30PM +0200, Daniel Vetter wrote: > Should help new people pick suitable tasks. > > Cc: Rodrigo Siqueira > Cc: Manasi Navare > Cc: Sean Paul Reviewed-by: Sean Paul > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 73 ++ > 1 file changed, 73 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 9ac102922712..73c51b5a0997 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -7,6 +7,22 @@ TODO list > This section contains a list of smaller janitorial tasks in the kernel DRM > graphics subsystem useful as newbie projects. Or for slow rainy days. > > +Difficulty > +-- > + > +To make it easier task are categorized into different levels: > + > +Starter: Good tasks to get started with the DRM subsystem. > + > +Intermediate: Tasks which need some experience with working in the DRM > +subsystem, or some specific GPU/display graphics knowledge. For debugging > issue > +it's good to have the relevant hardware (or a virtual driver set up) > available > +for testing. > + > +Advanced: Tricky tasks that need fairly good understanding of the DRM > subsystem > +and graphics topics. Generally need the relevant hardware for development and > +testing. > + > Subsystem-wide refactorings > === > > @@ -20,6 +36,8 @@ implementations), and then remove it. > > Contact: Daniel Vetter, respective driver maintainers > > +Level: Intermediate > + > Convert existing KMS drivers to atomic modesetting > -- > > @@ -38,6 +56,8 @@ do by directly using the new atomic helper driver callbacks. > > Contact: Daniel Vetter, respective driver maintainers > > +Level: Advanced > + > Clean up the clipped coordination confusion around planes > - > > @@ -50,6 +70,8 @@ helpers. > > Contact: Ville Syrjälä, Daniel Vetter, driver maintainers > > +Level: Advanced > + > Convert early atomic drivers to async commit helpers > > > @@ -63,6 +85,8 @@ events for atomic commits correctly. But fixing these bugs > is good anyway. > > Contact: Daniel Vetter, respective driver maintainers > > +Level: Advanced > + > Fallout from atomic KMS > --- > > @@ -91,6 +115,8 @@ interfaces to fix these issues: > > Contact: Daniel Vetter > > +Level: Intermediate > + > Get rid of dev->struct_mutex from GEM drivers > - > > @@ -114,6 +140,8 @@ fine-grained per-buffer object and per-context lockings > scheme. Currently only t > > Contact: Daniel Vetter, respective driver maintainers > > +Level: Advanced > + > Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* equivalent > > > @@ -129,6 +157,8 @@ are better. > > Contact: Sean Paul, Maintainer of the driver you plan to convert > > +Level: Starter > + > Convert drivers to use simple modeset suspend/resume > > > @@ -139,6 +169,8 @@ of the atomic suspend/resume code in older atomic modeset > drivers. > > Contact: Maintainer of the driver you plan to convert > > +Level: Intermediate > + > Convert drivers to use drm_fb_helper_fbdev_setup/teardown() > --- > > @@ -157,6 +189,8 @@ probably use drm_fb_helper_fbdev_teardown(). > > Contact: Maintainer of the driver you plan to convert > > +Level: Intermediate > + > Clean up mmap forwarding > > > @@ -166,6 +200,8 @@ There's drm_gem_prime_mmap() for this now, but still > needs to be rolled out. > > Contact: Daniel Vetter > > +Level: Intermediate > + > Generic fbdev defio support > --- > > @@ -196,6 +232,8 @@ Might be good to also have some igt testcases for this. > > Contact: Daniel Vetter, Noralf Tronnes > > +Level: Advanced > + > idr_init_base() > --- > > @@ -206,6 +244,8 @@ efficient. > > Contact: Daniel Vetter > > +Level: Starter > + > struct drm_gem_object_funcs > --- > > @@ -216,6 +256,8 @@ We also need a 2nd version of the CMA define that doesn't > require the > vmapping to be present (different hook for prime importing). Plus this needs > to > be rolled out to all drivers using their own implementations, too. > > +Level: Intermediate > + > Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate > - > > @@ -231,6 +273,8 @@ As a reference, take a look at the conversions already > completed in drm core. > > Contact: Sean Paul, respective driver maintainers > > +Level: Starter > + > Rename CMA helpers to DMA
[PATCH 2/2] drm/todo: Add levels
Should help new people pick suitable tasks. Cc: Rodrigo Siqueira Cc: Manasi Navare Cc: Sean Paul Signed-off-by: Daniel Vetter --- Documentation/gpu/todo.rst | 73 ++ 1 file changed, 73 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 9ac102922712..73c51b5a0997 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -7,6 +7,22 @@ TODO list This section contains a list of smaller janitorial tasks in the kernel DRM graphics subsystem useful as newbie projects. Or for slow rainy days. +Difficulty +-- + +To make it easier task are categorized into different levels: + +Starter: Good tasks to get started with the DRM subsystem. + +Intermediate: Tasks which need some experience with working in the DRM +subsystem, or some specific GPU/display graphics knowledge. For debugging issue +it's good to have the relevant hardware (or a virtual driver set up) available +for testing. + +Advanced: Tricky tasks that need fairly good understanding of the DRM subsystem +and graphics topics. Generally need the relevant hardware for development and +testing. + Subsystem-wide refactorings === @@ -20,6 +36,8 @@ implementations), and then remove it. Contact: Daniel Vetter, respective driver maintainers +Level: Intermediate + Convert existing KMS drivers to atomic modesetting -- @@ -38,6 +56,8 @@ do by directly using the new atomic helper driver callbacks. Contact: Daniel Vetter, respective driver maintainers +Level: Advanced + Clean up the clipped coordination confusion around planes - @@ -50,6 +70,8 @@ helpers. Contact: Ville Syrjälä, Daniel Vetter, driver maintainers +Level: Advanced + Convert early atomic drivers to async commit helpers @@ -63,6 +85,8 @@ events for atomic commits correctly. But fixing these bugs is good anyway. Contact: Daniel Vetter, respective driver maintainers +Level: Advanced + Fallout from atomic KMS --- @@ -91,6 +115,8 @@ interfaces to fix these issues: Contact: Daniel Vetter +Level: Intermediate + Get rid of dev->struct_mutex from GEM drivers - @@ -114,6 +140,8 @@ fine-grained per-buffer object and per-context lockings scheme. Currently only t Contact: Daniel Vetter, respective driver maintainers +Level: Advanced + Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* equivalent @@ -129,6 +157,8 @@ are better. Contact: Sean Paul, Maintainer of the driver you plan to convert +Level: Starter + Convert drivers to use simple modeset suspend/resume @@ -139,6 +169,8 @@ of the atomic suspend/resume code in older atomic modeset drivers. Contact: Maintainer of the driver you plan to convert +Level: Intermediate + Convert drivers to use drm_fb_helper_fbdev_setup/teardown() --- @@ -157,6 +189,8 @@ probably use drm_fb_helper_fbdev_teardown(). Contact: Maintainer of the driver you plan to convert +Level: Intermediate + Clean up mmap forwarding @@ -166,6 +200,8 @@ There's drm_gem_prime_mmap() for this now, but still needs to be rolled out. Contact: Daniel Vetter +Level: Intermediate + Generic fbdev defio support --- @@ -196,6 +232,8 @@ Might be good to also have some igt testcases for this. Contact: Daniel Vetter, Noralf Tronnes +Level: Advanced + idr_init_base() --- @@ -206,6 +244,8 @@ efficient. Contact: Daniel Vetter +Level: Starter + struct drm_gem_object_funcs --- @@ -216,6 +256,8 @@ We also need a 2nd version of the CMA define that doesn't require the vmapping to be present (different hook for prime importing). Plus this needs to be rolled out to all drivers using their own implementations, too. +Level: Intermediate + Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate - @@ -231,6 +273,8 @@ As a reference, take a look at the conversions already completed in drm core. Contact: Sean Paul, respective driver maintainers +Level: Starter + Rename CMA helpers to DMA helpers - @@ -241,6 +285,9 @@ no one knows what that means) since underneath they just use dma_alloc_coherent. Contact: Laurent Pinchart, Daniel Vetter +Level: Intermediate (mostly because it is a huge tasks without good partial +milestones, not technically itself that challenging) + Convert direct mode.vrefresh accesses to use drm_mode_vrefresh()
