[PATCH 2/3] drm/radeon: no need to check all relocs for dublicates

2011-10-26 Thread Paul Menzel 
Am Dienstag, den 25.10.2011, 17:04 +0200 schrieb Christian K?nig:
> Only check the previusly checked relocs for

previ*o*usly

> dublicates.

du*p*licates (also in commit summary)

> Also leaving the handle uninitialized isn't such a good idea.
> 
> Signed-off-by: Christian K?nig 
> ---
>  drivers/gpu/drm/radeon/radeon_cs.c |5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c 
> b/drivers/gpu/drm/radeon/radeon_cs.c
> index fae00c0..7b6e98a 100644
> --- a/drivers/gpu/drm/radeon/radeon_cs.c
> +++ b/drivers/gpu/drm/radeon/radeon_cs.c
> @@ -58,7 +58,7 @@ int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
>  
>   duplicate = false;
>   r = (struct drm_radeon_cs_reloc *)>kdata[i*4];
> - for (j = 0; j < p->nrelocs; j++) {
> + for (j = 0; j < i; j++) {
>   if (r->handle == p->relocs[j].handle) {
>   p->relocs_ptr[i] = >relocs[j];
>   duplicate = true;
> @@ -84,7 +84,8 @@ int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
>   p->relocs[i].flags = r->flags;
>   radeon_bo_list_add_object(>relocs[i].lobj,
> >validated);
> - }
> + } else
> + p->relocs[i].handle = 0;
>   }
>   return radeon_bo_list_validate(>validated);
>  }


Thanks,

Paul
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL:

Re: [PATCH 2/3] drm/radeon: no need to check all relocs for dublicates

2011-10-26 Thread Paul Menzel 
Am Dienstag, den 25.10.2011, 17:04 +0200 schrieb Christian König:
 Only check the previusly checked relocs for

previ*o*usly

 dublicates.

du*p*licates (also in commit summary)

 Also leaving the handle uninitialized isn't such a good idea.
 
 Signed-off-by: Christian König deathsim...@vodafone.de
 ---
  drivers/gpu/drm/radeon/radeon_cs.c |5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/gpu/drm/radeon/radeon_cs.c 
 b/drivers/gpu/drm/radeon/radeon_cs.c
 index fae00c0..7b6e98a 100644
 --- a/drivers/gpu/drm/radeon/radeon_cs.c
 +++ b/drivers/gpu/drm/radeon/radeon_cs.c
 @@ -58,7 +58,7 @@ int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
  
   duplicate = false;
   r = (struct drm_radeon_cs_reloc *)chunk-kdata[i*4];
 - for (j = 0; j  p-nrelocs; j++) {
 + for (j = 0; j  i; j++) {
   if (r-handle == p-relocs[j].handle) {
   p-relocs_ptr[i] = p-relocs[j];
   duplicate = true;
 @@ -84,7 +84,8 @@ int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
   p-relocs[i].flags = r-flags;
   radeon_bo_list_add_object(p-relocs[i].lobj,
 p-validated);
 - }
 + } else
 + p-relocs[i].handle = 0;
   }
   return radeon_bo_list_validate(p-validated);
  }


Thanks,

Paul


signature.asc
Description: This is a digitally signed message part
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/3] drm/radeon: no need to check all relocs for dublicates

2011-10-25 Thread Christian König 
Only check the previusly checked relocs for
dublicates. Also leaving the handle uninitialized
isn't such a good idea.

Signed-off-by: Christian K?nig 
---
 drivers/gpu/drm/radeon/radeon_cs.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_cs.c 
b/drivers/gpu/drm/radeon/radeon_cs.c
index fae00c0..7b6e98a 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -58,7 +58,7 @@ int radeon_cs_parser_relocs(struct radeon_cs_parser *p)

duplicate = false;
r = (struct drm_radeon_cs_reloc *)>kdata[i*4];
-   for (j = 0; j < p->nrelocs; j++) {
+   for (j = 0; j < i; j++) {
if (r->handle == p->relocs[j].handle) {
p->relocs_ptr[i] = >relocs[j];
duplicate = true;
@@ -84,7 +84,8 @@ int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
p->relocs[i].flags = r->flags;
radeon_bo_list_add_object(>relocs[i].lobj,
  >validated);
-   }
+   } else
+   p->relocs[i].handle = 0;
}
return radeon_bo_list_validate(>validated);
 }
-- 
1.7.5.4

[PATCH 2/3] drm/radeon: no need to check all relocs for dublicates

2011-10-25 Thread Christian König 
Only check the previusly checked relocs for
dublicates. Also leaving the handle uninitialized
isn't such a good idea.

Signed-off-by: Christian König deathsim...@vodafone.de
---
 drivers/gpu/drm/radeon/radeon_cs.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_cs.c 
b/drivers/gpu/drm/radeon/radeon_cs.c
index fae00c0..7b6e98a 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -58,7 +58,7 @@ int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
 
duplicate = false;
r = (struct drm_radeon_cs_reloc *)chunk-kdata[i*4];
-   for (j = 0; j  p-nrelocs; j++) {
+   for (j = 0; j  i; j++) {
if (r-handle == p-relocs[j].handle) {
p-relocs_ptr[i] = p-relocs[j];
duplicate = true;
@@ -84,7 +84,8 @@ int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
p-relocs[i].flags = r-flags;
radeon_bo_list_add_object(p-relocs[i].lobj,
  p-validated);
-   }
+   } else
+   p-relocs[i].handle = 0;
}
return radeon_bo_list_validate(p-validated);
 }
-- 
1.7.5.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel