Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-10-11 Thread Sam Ravnborg 
On Wed, Oct 06, 2021 at 09:47:12AM +0200, Alexander Stein wrote:
> Add a VCC regulator which needs to be enabled before the EN pin is
> released.
> 
> Signed-off-by: Alexander Stein 

Looks good,
Reviewed-by: Sam Ravnborg 

When you resend please put bindings patches first, we should not commit
code changes that uses undocumented bindings. On principle.

Sam

AW: (EXT) Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-10-06 Thread Alexander Stein 
On Wed, Oct 6, 2021 at 3:21 PM Rob Herring
 wrote:

> On Wed, Oct 6, 2021 at 2:47 AM Alexander Stein
>  wrote:
> >
> > Add a VCC regulator which needs to be enabled before the EN pin is
> > released.
> >
> > Signed-off-by: Alexander Stein 
> > ---
> >  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 5 +
> >  1 file changed, 5 insertions(+)
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > index 07b20383cbca..149cff3233c2 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > @@ -32,6 +32,9 @@ properties:
> >  maxItems: 1
> >  description: GPIO specifier for bridge_en pin (active high).
> >
> > +  vcc-supply:
> > +    description: A 1.8V power supply (see regulator/regulator.yaml).
> > +
> >    ports:
> >  $ref: /schemas/graph.yaml#/properties/ports
> >
> > @@ -94,6 +97,7 @@ required:
> >    - compatible
> >    - reg
> >    - enable-gpios
> > +  - vcc-supply
>
> You generally can't make added properties required unless all DT files
> already had this property. It breaks compatibility.

I agree, but AFAICS none of the in-kernel DT files uses this binding. I used
'grep -re "ti,sn65dsi8[34]" arch/*/boot/dts' to check. Only
ti,sn65dsi86 is used on some qcom boards, but this is a completly different
binding and driver.

Best regards,
Alexander

[PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-10-06 Thread Alexander Stein 
Add a VCC regulator which needs to be enabled before the EN pin is
released.

Signed-off-by: Alexander Stein 
---
 .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 5 +
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml 
b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
index 07b20383cbca..149cff3233c2 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
@@ -32,6 +32,9 @@ properties:
 maxItems: 1
 description: GPIO specifier for bridge_en pin (active high).
 
+  vcc-supply:
+description: A 1.8V power supply (see regulator/regulator.yaml).
+
   ports:
 $ref: /schemas/graph.yaml#/properties/ports
 
@@ -94,6 +97,7 @@ required:
   - compatible
   - reg
   - enable-gpios
+  - vcc-supply
   - ports
 
 allOf:
@@ -135,6 +139,7 @@ examples:
 reg = <0x2d>;
 
 enable-gpios = < 1 GPIO_ACTIVE_HIGH>;
+vcc-supply = <_sn65dsi83_1v8>;
 
 ports {
 #address-cells = <1>;
-- 
2.25.1

Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-10-06 Thread Rob Herring 
On Wed, Oct 6, 2021 at 2:47 AM Alexander Stein
 wrote:
>
> Add a VCC regulator which needs to be enabled before the EN pin is
> released.
>
> Signed-off-by: Alexander Stein 
> ---
>  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git 
> a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml 
> b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> index 07b20383cbca..149cff3233c2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -32,6 +32,9 @@ properties:
>  maxItems: 1
>  description: GPIO specifier for bridge_en pin (active high).
>
> +  vcc-supply:
> +description: A 1.8V power supply (see regulator/regulator.yaml).
> +
>ports:
>  $ref: /schemas/graph.yaml#/properties/ports
>
> @@ -94,6 +97,7 @@ required:
>- compatible
>- reg
>- enable-gpios
> +  - vcc-supply

You generally can't make added properties required unless all DT files
already had this property. It breaks compatibility.

Rob