[PATCH 2/5] ARM: tegra: of: add GK20A device tree binding
On Tue, May 20, 2014 at 6:14 AM, Stephen Warren
wrote:
> On 05/19/2014 03:24 AM, Alexandre Courbot wrote:
>> Add the device tree binding documentation for the GK20A GPU used in
>> Tegra K1 SoCs.
>
> A few minor nits, but otherwise,
> Acked-by: Stephen Warren
>
>> diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
>> b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
>
>> +Required properties:
>> +- compatible: "nvidia,-"
>> + Currently recognized values:
>> + - nvidia,tegra124-gk20a
>> +- reg: Physical base address and length of the controller's registers.
>> + Must contain two entries:
>> + - first entry for bar0
>> + - second entry for bar1
>> +- interrupts: The interrupt outputs from the controller.
>
> To be consistent with the clocks and resets properties, it'd be nice to
> reword that as:
>
> interrupts: Must contain an entry for each entry in interrupt-names.
>
>> +- interrupt-names: Must include the following entries:
>
> ... and add the following here:
>
> See ../interrupt-controller/interrupts.txt
>
>> +/ {
>
> No need to wrap a root node around this in the example.
>
>> + gpu at 0,5700 {
> ...
>> + };
>> +
>
> Extra blank line here.
>
>> +};
>
All fixed and acked-by added to the commit log.
Thanks,
Alex.
[PATCH 2/5] ARM: tegra: of: add GK20A device tree binding
Add the device tree binding documentation for the GK20A GPU used in
Tegra K1 SoCs.
Signed-off-by: Alexandre Courbot
---
.../devicetree/bindings/gpu/nvidia,gk20a.txt | 45 ++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
new file mode 100644
index ..eda04c963af0
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
@@ -0,0 +1,45 @@
+NVIDIA GK20A Graphics Processing Unit
+
+Required properties:
+- compatible: "nvidia,-"
+ Currently recognized values:
+ - nvidia,tegra124-gk20a
+- reg: Physical base address and length of the controller's registers.
+ Must contain two entries:
+ - first entry for bar0
+ - second entry for bar1
+- interrupts: The interrupt outputs from the controller.
+- interrupt-names: Must include the following entries:
+ - stall
+ - nonstall
+- vdd-supply: regulator for supply voltage.
+- clocks: Must contain an entry for each entry in clock-names.
+ See ../clocks/clock-bindings.txt for details.
+- clock-names: Must include the following entries:
+ - gpu
+ - pll
+- resets: Must contain an entry for each entry in reset-names.
+ See ../reset/reset.txt for details.
+- reset-names: Must include the following entries:
+ - gpu
+
+Example:
+
+/ {
+ gpu at 0,5700 {
+ compatible = "nvidia,gk20a";
+ reg = <0x0 0x5700 0x0 0x0100>,
+ <0x0 0x5800 0x0 0x0100>;
+ interrupts = ,
+;
+ interrupt-names = "stall", "nonstall";
+ vdd-supply = <&vdd_gpu>;
+ clocks = <&tegra_car TEGRA124_CLK_GPU>,
+<&tegra_car TEGRA124_CLK_PLL_P_OUT5>;
+ clock-names = "gpu", "pll";
+ resets = <&tegra_car 184>;
+ reset-names = "gpu";
+ status = "disabled";
+ };
+
+};
--
1.9.2
[PATCH 2/5] ARM: tegra: of: add GK20A device tree binding
On 05/19/2014 03:24 AM, Alexandre Courbot wrote:
> Add the device tree binding documentation for the GK20A GPU used in
> Tegra K1 SoCs.
A few minor nits, but otherwise,
Acked-by: Stephen Warren
> diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
> b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
> +Required properties:
> +- compatible: "nvidia,-"
> + Currently recognized values:
> + - nvidia,tegra124-gk20a
> +- reg: Physical base address and length of the controller's registers.
> + Must contain two entries:
> + - first entry for bar0
> + - second entry for bar1
> +- interrupts: The interrupt outputs from the controller.
To be consistent with the clocks and resets properties, it'd be nice to
reword that as:
interrupts: Must contain an entry for each entry in interrupt-names.
> +- interrupt-names: Must include the following entries:
... and add the following here:
See ../interrupt-controller/interrupts.txt
> +/ {
No need to wrap a root node around this in the example.
> + gpu at 0,5700 {
...
> + };
> +
Extra blank line here.
> +};
