Re: [PATCH 23/40] drm/amd/display/dc/dce110/dce110_mem_input_v: Make local functions static

2021-01-12 Thread Alex Deucher 
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones  wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:471:6: 
> warning: no previous prototype for ‘dce_mem_input_v_is_surface_pending’ 
> [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:486:6: 
> warning: no previous prototype for 
> ‘dce_mem_input_v_program_surface_flip_and_addr’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:563:6: 
> warning: no previous prototype for ‘dce_mem_input_v_program_pte_vm’ 
> [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:636:6: 
> warning: no previous prototype for ‘dce_mem_input_v_program_surface_config’ 
> [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:922:6: 
> warning: no previous prototype for ‘dce_mem_input_v_program_display_marks’ 
> [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:945:6: 
> warning: no previous prototype for 
> ‘dce_mem_input_program_chroma_display_marks’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:966:6: 
> warning: no previous prototype for ‘dce110_allocate_mem_input_v’ 
> [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:1008:6: 
> warning: no previous prototype for ‘dce110_free_mem_input_v’ 
> [-Wmissing-prototypes]
>
> Cc: Harry Wentland 
> Cc: Leo Li 
> Cc: Alex Deucher 
> Cc: "Christian König" 
> Cc: David Airlie 
> Cc: Daniel Vetter 
> Cc: amd-...@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones 

Applied.  Thanks!

Alex

> ---
>  .../amd/display/dc/dce110/dce110_mem_input_v.c   | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c 
> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
> index d54172d88f5f3..19b1976139b69 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
> @@ -468,7 +468,7 @@ static void program_pixel_format(
> }
>  }
>
> -bool dce_mem_input_v_is_surface_pending(struct mem_input *mem_input)
> +static bool dce_mem_input_v_is_surface_pending(struct mem_input *mem_input)
>  {
> struct dce_mem_input *mem_input110 = TO_DCE_MEM_INPUT(mem_input);
> uint32_t value;
> @@ -483,7 +483,7 @@ bool dce_mem_input_v_is_surface_pending(struct mem_input 
> *mem_input)
> return false;
>  }
>
> -bool dce_mem_input_v_program_surface_flip_and_addr(
> +static bool dce_mem_input_v_program_surface_flip_and_addr(
> struct mem_input *mem_input,
> const struct dc_plane_address *address,
> bool flip_immediate)
> @@ -560,7 +560,7 @@ static const unsigned int *get_dvmm_hw_setting(
> }
>  }
>
> -void dce_mem_input_v_program_pte_vm(
> +static void dce_mem_input_v_program_pte_vm(
> struct mem_input *mem_input,
> enum surface_pixel_format format,
> union dc_tiling_info *tiling_info,
> @@ -633,7 +633,7 @@ void dce_mem_input_v_program_pte_vm(
> dm_write_reg(mem_input110->base.ctx, mmUNP_DVMM_PTE_ARB_CONTROL_C, 
> value);
>  }
>
> -void dce_mem_input_v_program_surface_config(
> +static void dce_mem_input_v_program_surface_config(
> struct mem_input *mem_input,
> enum surface_pixel_format format,
> union dc_tiling_info *tiling_info,
> @@ -919,7 +919,7 @@ static void program_nbp_watermark_c(
> marks);
>  }
>
> -void dce_mem_input_v_program_display_marks(
> +static void dce_mem_input_v_program_display_marks(
> struct mem_input *mem_input,
> struct dce_watermarks nbp,
> struct dce_watermarks stutter,
> @@ -942,7 +942,7 @@ void dce_mem_input_v_program_display_marks(
>
>  }
>
> -void dce_mem_input_program_chroma_display_marks(
> +static void dce_mem_input_program_chroma_display_marks(
> struct mem_input *mem_input,
> struct dce_watermarks nbp,
> struct dce_watermarks stutter,
> @@ -963,7 +963,7 @@ void dce_mem_input_program_chroma_display_marks(
> stutter);
>  }
>
> -void dce110_allocate_mem_input_v(
> +static void dce110_allocate_mem_input_v(
> struct mem_input *mi,
> uint32_t h_total,/* for current stream */
> uint32_t v_total,/* for current stream */
> @@ -1005,7 +1005,7 @@ void dce110_allocate_mem_input_v(
>
>  }
>
> -void dce110_free_mem_input_v(
> +static void dce110_free_mem_input_v(
> struct mem_input *mi,
> uint32_t total_stream_num)
>  {
> --
> 2.25.1
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
>

[PATCH 23/40] drm/amd/display/dc/dce110/dce110_mem_input_v: Make local functions static

2021-01-11 Thread Lee Jones 
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:471:6: 
warning: no previous prototype for ‘dce_mem_input_v_is_surface_pending’ 
[-Wmissing-prototypes]
 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:486:6: 
warning: no previous prototype for 
‘dce_mem_input_v_program_surface_flip_and_addr’ [-Wmissing-prototypes]
 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:563:6: 
warning: no previous prototype for ‘dce_mem_input_v_program_pte_vm’ 
[-Wmissing-prototypes]
 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:636:6: 
warning: no previous prototype for ‘dce_mem_input_v_program_surface_config’ 
[-Wmissing-prototypes]
 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:922:6: 
warning: no previous prototype for ‘dce_mem_input_v_program_display_marks’ 
[-Wmissing-prototypes]
 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:945:6: 
warning: no previous prototype for ‘dce_mem_input_program_chroma_display_marks’ 
[-Wmissing-prototypes]
 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:966:6: 
warning: no previous prototype for ‘dce110_allocate_mem_input_v’ 
[-Wmissing-prototypes]
 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:1008:6: 
warning: no previous prototype for ‘dce110_free_mem_input_v’ 
[-Wmissing-prototypes]

Cc: Harry Wentland 
Cc: Leo Li 
Cc: Alex Deucher 
Cc: "Christian König" 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: amd-...@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones 
---
 .../amd/display/dc/dce110/dce110_mem_input_v.c   | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c 
b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
index d54172d88f5f3..19b1976139b69 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
@@ -468,7 +468,7 @@ static void program_pixel_format(
}
 }
 
-bool dce_mem_input_v_is_surface_pending(struct mem_input *mem_input)
+static bool dce_mem_input_v_is_surface_pending(struct mem_input *mem_input)
 {
struct dce_mem_input *mem_input110 = TO_DCE_MEM_INPUT(mem_input);
uint32_t value;
@@ -483,7 +483,7 @@ bool dce_mem_input_v_is_surface_pending(struct mem_input 
*mem_input)
return false;
 }
 
-bool dce_mem_input_v_program_surface_flip_and_addr(
+static bool dce_mem_input_v_program_surface_flip_and_addr(
struct mem_input *mem_input,
const struct dc_plane_address *address,
bool flip_immediate)
@@ -560,7 +560,7 @@ static const unsigned int *get_dvmm_hw_setting(
}
 }
 
-void dce_mem_input_v_program_pte_vm(
+static void dce_mem_input_v_program_pte_vm(
struct mem_input *mem_input,
enum surface_pixel_format format,
union dc_tiling_info *tiling_info,
@@ -633,7 +633,7 @@ void dce_mem_input_v_program_pte_vm(
dm_write_reg(mem_input110->base.ctx, mmUNP_DVMM_PTE_ARB_CONTROL_C, 
value);
 }
 
-void dce_mem_input_v_program_surface_config(
+static void dce_mem_input_v_program_surface_config(
struct mem_input *mem_input,
enum surface_pixel_format format,
union dc_tiling_info *tiling_info,
@@ -919,7 +919,7 @@ static void program_nbp_watermark_c(
marks);
 }
 
-void dce_mem_input_v_program_display_marks(
+static void dce_mem_input_v_program_display_marks(
struct mem_input *mem_input,
struct dce_watermarks nbp,
struct dce_watermarks stutter,
@@ -942,7 +942,7 @@ void dce_mem_input_v_program_display_marks(
 
 }
 
-void dce_mem_input_program_chroma_display_marks(
+static void dce_mem_input_program_chroma_display_marks(
struct mem_input *mem_input,
struct dce_watermarks nbp,
struct dce_watermarks stutter,
@@ -963,7 +963,7 @@ void dce_mem_input_program_chroma_display_marks(
stutter);
 }
 
-void dce110_allocate_mem_input_v(
+static void dce110_allocate_mem_input_v(
struct mem_input *mi,
uint32_t h_total,/* for current stream */
uint32_t v_total,/* for current stream */
@@ -1005,7 +1005,7 @@ void dce110_allocate_mem_input_v(
 
 }
 
-void dce110_free_mem_input_v(
+static void dce110_free_mem_input_v(
struct mem_input *mi,
uint32_t total_stream_num)
 {
-- 
2.25.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel