Re: [PATCH 26/40] drm/amd/display/dc/dce110/dce110_timing_generator: Demote kernel-doc abuses to standard function headers
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:79: > warning: Cannot understand > * > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:124: > warning: Function parameter or member 'tg' not described in > 'dce110_timing_generator_enable_crtc' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:179: > warning: Cannot understand > * > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:233: > warning: Function parameter or member 'tg' not described in > 'dce110_timing_generator_disable_crtc' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:258: > warning: Function parameter or member 'tg' not described in > 'program_horz_count_by_2' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:258: > warning: Function parameter or member 'timing' not described in > 'program_horz_count_by_2' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:284: > warning: Function parameter or member 'tg' not described in > 'dce110_timing_generator_program_timing_generator' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:284: > warning: Function parameter or member 'dc_crtc_timing' not described in > 'dce110_timing_generator_program_timing_generator' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:356: > warning: Cannot understand > * > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:525: > warning: Cannot understand > * > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:561: > warning: Cannot understand > * > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1118: > warning: Function parameter or member 'tg' not described in > 'dce110_timing_generator_validate_timing' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1118: > warning: Function parameter or member 'timing' not described in > 'dce110_timing_generator_validate_timing' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1118: > warning: Function parameter or member 'signal' not described in > 'dce110_timing_generator_validate_timing' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1174: > warning: Function parameter or member 'tg' not described in > 'dce110_timing_generator_wait_for_vblank' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1198: > warning: Function parameter or member 'tg' not described in > 'dce110_timing_generator_wait_for_vactive' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1208: > warning: Cannot understand > * > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1386: > warning: Cannot understand > * > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1768: > warning: Cannot understand > * > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1801: > warning: Function parameter or member 'tg' not described in > 'dce110_timing_generator_disable_vga' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1851: > warning: Function parameter or member 'tg' not described in > 'dce110_timing_generator_set_overscan_color_black' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1851: > warning: Function parameter or member 'color' not described in > 'dce110_timing_generator_set_overscan_color_black' > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1851: > warning: Excess function parameter 'param' description in > 'dce110_timing_generator_set_overscan_color_black' > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Anthony Koo > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > .../dc/dce110/dce110_timing_generator.c | 71 +-- > 1 file changed, 34
[PATCH 26/40] drm/amd/display/dc/dce110/dce110_timing_generator: Demote kernel-doc abuses to standard function headers
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:79: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:124: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_enable_crtc' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:179: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:233: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_disable_crtc' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:258: warning: Function parameter or member 'tg' not described in 'program_horz_count_by_2' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:258: warning: Function parameter or member 'timing' not described in 'program_horz_count_by_2' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:284: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_program_timing_generator' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:284: warning: Function parameter or member 'dc_crtc_timing' not described in 'dce110_timing_generator_program_timing_generator' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:356: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:525: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:561: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1118: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_validate_timing' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1118: warning: Function parameter or member 'timing' not described in 'dce110_timing_generator_validate_timing' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1118: warning: Function parameter or member 'signal' not described in 'dce110_timing_generator_validate_timing' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1174: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_wait_for_vblank' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1198: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_wait_for_vactive' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1208: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1386: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1768: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1801: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_disable_vga' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1851: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_set_overscan_color_black' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1851: warning: Function parameter or member 'color' not described in 'dce110_timing_generator_set_overscan_color_black' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1851: warning: Excess function parameter 'param' description in 'dce110_timing_generator_set_overscan_color_black' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Anthony Koo Cc: amd-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../dc/dce110/dce110_timing_generator.c | 71 +-- 1 file changed, 34 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator.c index 9a6c411bb7fe6..d88a74559edd7 100644 --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator.c +++
