Re: [PATCH 27/40] drm/amd/display/dc/dce110/dce110_compressor: Strip out unused function 'controller_id_to_index'

[Alex Deucher]

On Mon, Jan 11, 2021 at 2:20 PM Lee Jones  wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:429:14: 
> warning: no previous prototype for ‘controller_id_to_index’ 
> [-Wmissing-prototypes]
>
> Cc: Harry Wentland 
> Cc: Leo Li 
> Cc: Alex Deucher 
> Cc: "Christian König" 
> Cc: David Airlie 
> Cc: Daniel Vetter 
> Cc: Lee Jones 
> Cc: amd-...@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones 

Applied. Thanks!

Alex


> ---
>  .../amd/display/dc/dce110/dce110_compressor.c | 25 ---
>  1 file changed, 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c 
> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
> index 18b0a69b0b1e8..44564a4742b52 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
> @@ -425,31 +425,6 @@ void get_max_support_fbc_buffersize(unsigned int *max_x, 
> unsigned int *max_y)
>  */
>  }
>
> -
> -unsigned int controller_id_to_index(enum controller_id controller_id)
> -{
> -   unsigned int index = 0;
> -
> -   switch (controller_id) {
> -   case CONTROLLER_ID_D0:
> -   index = 0;
> -   break;
> -   case CONTROLLER_ID_D1:
> -   index = 1;
> -   break;
> -   case CONTROLLER_ID_D2:
> -   index = 2;
> -   break;
> -   case CONTROLLER_ID_D3:
> -   index = 3;
> -   break;
> -   default:
> -   break;
> -   }
> -   return index;
> -}
> -
> -
>  static const struct compressor_funcs dce110_compressor_funcs = {
> .power_up_fbc = dce110_compressor_power_up_fbc,
> .enable_fbc = dce110_compressor_enable_fbc,
> --
> 2.25.1
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 27/40] drm/amd/display/dc/dce110/dce110_compressor: Strip out unused function 'controller_id_to_index'

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:429:14: 
warning: no previous prototype for ‘controller_id_to_index’ 
[-Wmissing-prototypes]

Cc: Harry Wentland 
Cc: Leo Li 
Cc: Alex Deucher 
Cc: "Christian König" 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: Lee Jones 
Cc: amd-...@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones 
---
 .../amd/display/dc/dce110/dce110_compressor.c | 25 ---
 1 file changed, 25 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c 
b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
index 18b0a69b0b1e8..44564a4742b52 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
@@ -425,31 +425,6 @@ void get_max_support_fbc_buffersize(unsigned int *max_x, 
unsigned int *max_y)
 */
 }
 
-
-unsigned int controller_id_to_index(enum controller_id controller_id)
-{
-   unsigned int index = 0;
-
-   switch (controller_id) {
-   case CONTROLLER_ID_D0:
-   index = 0;
-   break;
-   case CONTROLLER_ID_D1:
-   index = 1;
-   break;
-   case CONTROLLER_ID_D2:
-   index = 2;
-   break;
-   case CONTROLLER_ID_D3:
-   index = 3;
-   break;
-   default:
-   break;
-   }
-   return index;
-}
-
-
 static const struct compressor_funcs dce110_compressor_funcs = {
.power_up_fbc = dce110_compressor_power_up_fbc,
.enable_fbc = dce110_compressor_enable_fbc,
-- 
2.25.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel