Re: [PATCH 3/6] drm/mgag200: Remove disable handling from atomic_update

[Javier Martinez Canillas]

Thomas Zimmermann  writes:

> This mail never made it to dri-devel.
>

Oh, sorry about that. It seems that your response wasn't enough for
patchwork to pick the tag, so:

Reviewed-by: Javier Martinez Canillas 

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

Re: [PATCH 3/6] drm/mgag200: Remove disable handling from atomic_update

[Thomas Zimmermann]

This mail never made it to dri-devel.

Am 17.02.23 um 14:26 schrieb Javier Martinez Canillas:

Thomas Zimmermann  writes:


The primary plane has the atomic_disable helper set, so atomic_update
won't be called if the plane gets disabled. Remove the respective branch
from the helper.

Signed-off-by: Thomas Zimmermann 
---


Reviewed-by: Javier Martinez Canillas 

Best regards,
Javier



--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev


OpenPGP_signature
Description: OpenPGP digital signature

[PATCH 3/6] drm/mgag200: Remove disable handling from atomic_update

[Thomas Zimmermann]

The primary plane has the atomic_disable helper set, so atomic_update
won't be called if the plane gets disabled. Remove the respective branch
from the helper.

Signed-off-by: Thomas Zimmermann 
---
 drivers/gpu/drm/mgag200/mgag200_mode.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c 
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 0a5aaf78172a..47e86eadb239 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -503,9 +503,6 @@ void mgag200_primary_plane_helper_atomic_update(struct 
drm_plane *plane,
struct drm_rect damage;
u8 seq1;
 
-   if (!fb)
-   return;
-
drm_atomic_helper_damage_iter_init(, old_plane_state, plane_state);
drm_atomic_for_each_plane_damage(, ) {
mgag200_handle_damage(mdev, shadow_plane_state->data, fb, 
);
-- 
2.39.1