Re: [PATCH 4/4] accel/ivpu: Fix old dma_buf api usage

[Jeffrey Hugo]

On 2/2/2023 2:21 AM, Stanislaw Gruszka wrote:

Update according to new dma-buf locking scheme.

Remove redundant WARN_ON()'s, dma_buf functions internally
have the same warnings already.

Signed-off-by: Stanislaw Gruszka 


Reviewed-by: Jeffrey Hugo 

[PATCH 4/4] accel/ivpu: Fix old dma_buf api usage

[Stanislaw Gruszka]

Update according to new dma-buf locking scheme.

Remove redundant WARN_ON()'s, dma_buf functions internally
have the same warnings already.

Signed-off-by: Stanislaw Gruszka 
---
 drivers/accel/ivpu/ivpu_gem.c | 8 ++--
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
index d1f923971b4c..01d47d3bad5b 100644
--- a/drivers/accel/ivpu/ivpu_gem.c
+++ b/drivers/accel/ivpu/ivpu_gem.c
@@ -42,9 +42,7 @@ static int prime_map_pages_locked(struct ivpu_bo *bo)
struct ivpu_device *vdev = ivpu_bo_to_vdev(bo);
struct sg_table *sgt;
 
-   WARN_ON(!bo->base.import_attach);
-
-   sgt = dma_buf_map_attachment(bo->base.import_attach, DMA_BIDIRECTIONAL);
+   sgt = dma_buf_map_attachment_unlocked(bo->base.import_attach, 
DMA_BIDIRECTIONAL);
if (IS_ERR(sgt)) {
ivpu_err(vdev, "Failed to map attachment: %ld\n", PTR_ERR(sgt));
return PTR_ERR(sgt);
@@ -56,9 +54,7 @@ static int prime_map_pages_locked(struct ivpu_bo *bo)
 
 static void prime_unmap_pages_locked(struct ivpu_bo *bo)
 {
-   WARN_ON(!bo->base.import_attach);
-
-   dma_buf_unmap_attachment(bo->base.import_attach, bo->sgt, 
DMA_BIDIRECTIONAL);
+   dma_buf_unmap_attachment_unlocked(bo->base.import_attach, bo->sgt, 
DMA_BIDIRECTIONAL);
bo->sgt = NULL;
 }
 
-- 
2.25.1