Re: [kbuild-all] Re: [PATCH 4/4] drm: pl111: Update documentation
On 6/12/20 8:40 PM, Philip Li wrote: On Fri, Jun 12, 2020 at 01:04:02PM +0200, Linus Walleij wrote: On Wed, Jun 10, 2020 at 9:38 AM kernel test robot wrote: I love your patch! Perhaps something to improve: [auto build test WARNING on drm-exynos/exynos-drm-next] [also build test WARNING on drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200609] [cannot apply to drm-tip/drm-tip drm/drm-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-pl111-Credit-where-credit-is-due/20200610-041025 base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next reproduce: make htmldocs If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot What on earth was that. The robot reports on a patch only adding a few lines of comments as breaking the whole universe, and none of these systems even use the PL111. Thanks for feedback, this is supposed to check make htmldocs. We will double check this to fix issue. Sorry for noise. Hi Linus, We won't show unrelated htmldocs warnings in the future, but the warning (with prefix '>>') was found in this patch, could you take a look? drivers/gpu/drm/pl111/pl111_drv.c:1: warning: 'ARM PrimeCell PL111 CLCD Driver' not found Best Regards, Rong Chen ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 4/4] drm: pl111: Update documentation
On Tue, Jun 16, 2020 at 05:12:51PM +0100, Emil Velikov wrote: > Hi all, > > Inspired by Linus and my personal confusion with the report, allow me > to put some suggestions. Followed by an illustrative example. thanks for all the suggestions, we will take them into consideration to gradually improve the report. > > On Wed, 10 Jun 2020 at 08:38, kernel test robot wrote: > > > > Hi Linus, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on drm-exynos/exynos-drm-next] > > [also build test WARNING on drm-intel/for-linux-next > > tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200609] > One thing which was always inclear me - is the warning identical in > all the branches listed. yes, they contain same warning, we will clarify this. > > > [cannot apply to drm-tip/drm-tip drm/drm-next] > > [if your patch is applied to the wrong git tree, please drop us a note to > > help > > improve the system. BTW, we also suggest to use '--base' option to specify > > the > > base tree in git format-patch, please see > > https://stackoverflow.com/a/37406982] > > > Reference to the manual tends to be better than an old SO thread. got it, we will refer to your later example to enhance here. > > > url: > > https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-pl111-Credit-where-credit-is-due/20200610-041025 > > base: > > https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git > > exynos-drm-next > > reproduce: make htmldocs > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>, old ones prefixed by <<): > > > Please do not list old warnings/errors. They only distract and dilute > what/where the problem is. early on, there's a request to view the old warning of modpost related issue in case it is a false positive due to modpost output format changing. we will think of this to limit to modpost only. > > > > vim +1 drivers/gpu/drm/pl111/pl111_drv.c > > > > e559355a9da60a Thomas Gleixner 2019-06-01 @1 // SPDX-License-Identifier: > > GPL-2.0-only > > bed41005e6174d Tom Cooksey 2017-04-12 2 /* > > bed41005e6174d Tom Cooksey 2017-04-12 3 * (C) COPYRIGHT 2012-2013 > > ARM Limited. All rights reserved. > > bed41005e6174d Tom Cooksey 2017-04-12 4 * > > bed41005e6174d Tom Cooksey 2017-04-12 5 * Parts of this file were > > based on sources as follows: > > bed41005e6174d Tom Cooksey 2017-04-12 6 * > > bed41005e6174d Tom Cooksey 2017-04-12 7 * Copyright (c) 2006-2008 > > Intel Corporation > > bed41005e6174d Tom Cooksey 2017-04-12 8 * Copyright (c) 2007 Dave > > Airlie > > bed41005e6174d Tom Cooksey 2017-04-12 9 * Copyright (C) 2011 Texas > > Instruments > > bed41005e6174d Tom Cooksey 2017-04-12 10 */ > > bed41005e6174d Tom Cooksey 2017-04-12 11 > > > > :: The code at line 1 was first introduced by commit > > :: e559355a9da60a2388893d9e9da66c79fd604b9a treewide: Replace GPLv2 > > boilerplate/reference with SPDX - rule 443 > > > > :: TO: Thomas Gleixner > > :: CC: Greg Kroah-Hartman > > > All of this seems useful when debugging the kernel test robot itself. > Which in this case is misleading as hell. thanks, we will check above 4 lines with : to adjust if needed. > > > Here is something which is much shorter, with clearer structure and > reads much easier. this is very helpful and can provide a different perspective for how the report is. We will learn from it to imporve the report. > > --- > Hi Linus, > > This is an automated message from your friendly test robot. > We've noticed some issues with your patch although being a robot, > kindly double-check the results. > > Branches: > [if the warning/errors are the same group them, otherwise split them > in separate sections] > > - drm-exynos/exynos-drm-next [1]: WARNING > - drm-intel/for-linux-next [2]: WARNING > - : WARNING > drivers/gpu/drm/pl111/pl111_drv.c:1: warning: 'ARM PrimeCell PL111 > CLCD Driver' not found > - tegra-drm/drm/tegra/for-next [3]: WARNING > some other warning > - drm-tip/drm-tip [4] drm/drm-next [5]: cannot apply series > > Note: when submitting patches, please use `--base` as documented in > https://git-scm.com/docs/git-format-patch. > > > To reproduce: > - wget https://url/to/build/toolchain // when applicable > - wget https://url/to/config // when applicable > - make htmldocs // use explicit make command instead of magic shell > script, as seen in the cross build reports > > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > Thank you > The LKP team > > [1] URI to the drm-exynos/exynos-drm-next repo > [2] URI to the drm-intel/for-linux-next repo > [3] URI to the ... > ___ dri-devel mailing list dri-devel@lists.freedesktop.org
Re: [PATCH 4/4] drm: pl111: Update documentation
Hi all, Inspired by Linus and my personal confusion with the report, allow me to put some suggestions. Followed by an illustrative example. On Wed, 10 Jun 2020 at 08:38, kernel test robot wrote: > > Hi Linus, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on drm-exynos/exynos-drm-next] > [also build test WARNING on drm-intel/for-linux-next > tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200609] One thing which was always inclear me - is the warning identical in all the branches listed. > [cannot apply to drm-tip/drm-tip drm/drm-next] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see > https://stackoverflow.com/a/37406982] > Reference to the manual tends to be better than an old SO thread. > url: > https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-pl111-Credit-where-credit-is-due/20200610-041025 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git > exynos-drm-next > reproduce: make htmldocs > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>, old ones prefixed by <<): > Please do not list old warnings/errors. They only distract and dilute what/where the problem is. > vim +1 drivers/gpu/drm/pl111/pl111_drv.c > > e559355a9da60a Thomas Gleixner 2019-06-01 @1 // SPDX-License-Identifier: > GPL-2.0-only > bed41005e6174d Tom Cooksey 2017-04-12 2 /* > bed41005e6174d Tom Cooksey 2017-04-12 3 * (C) COPYRIGHT 2012-2013 ARM > Limited. All rights reserved. > bed41005e6174d Tom Cooksey 2017-04-12 4 * > bed41005e6174d Tom Cooksey 2017-04-12 5 * Parts of this file were > based on sources as follows: > bed41005e6174d Tom Cooksey 2017-04-12 6 * > bed41005e6174d Tom Cooksey 2017-04-12 7 * Copyright (c) 2006-2008 > Intel Corporation > bed41005e6174d Tom Cooksey 2017-04-12 8 * Copyright (c) 2007 Dave > Airlie > bed41005e6174d Tom Cooksey 2017-04-12 9 * Copyright (C) 2011 Texas > Instruments > bed41005e6174d Tom Cooksey 2017-04-12 10 */ > bed41005e6174d Tom Cooksey 2017-04-12 11 > > :: The code at line 1 was first introduced by commit > :: e559355a9da60a2388893d9e9da66c79fd604b9a treewide: Replace GPLv2 > boilerplate/reference with SPDX - rule 443 > > :: TO: Thomas Gleixner > :: CC: Greg Kroah-Hartman > All of this seems useful when debugging the kernel test robot itself. Which in this case is misleading as hell. Here is something which is much shorter, with clearer structure and reads much easier. --- Hi Linus, This is an automated message from your friendly test robot. We've noticed some issues with your patch although being a robot, kindly double-check the results. Branches: [if the warning/errors are the same group them, otherwise split them in separate sections] - drm-exynos/exynos-drm-next [1]: WARNING - drm-intel/for-linux-next [2]: WARNING - : WARNING drivers/gpu/drm/pl111/pl111_drv.c:1: warning: 'ARM PrimeCell PL111 CLCD Driver' not found - tegra-drm/drm/tegra/for-next [3]: WARNING some other warning - drm-tip/drm-tip [4] drm/drm-next [5]: cannot apply series Note: when submitting patches, please use `--base` as documented in https://git-scm.com/docs/git-format-patch. To reproduce: - wget https://url/to/build/toolchain // when applicable - wget https://url/to/config // when applicable - make htmldocs // use explicit make command instead of magic shell script, as seen in the cross build reports If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Thank you The LKP team [1] URI to the drm-exynos/exynos-drm-next repo [2] URI to the drm-intel/for-linux-next repo [3] URI to the ... ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [kbuild-all] Re: [PATCH 4/4] drm: pl111: Update documentation
On Fri, Jun 12, 2020 at 01:04:02PM +0200, Linus Walleij wrote: > On Wed, Jun 10, 2020 at 9:38 AM kernel test robot wrote: > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on drm-exynos/exynos-drm-next] > > [also build test WARNING on drm-intel/for-linux-next > > tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200609] > > [cannot apply to drm-tip/drm-tip drm/drm-next] > > [if your patch is applied to the wrong git tree, please drop us a note to > > help > > improve the system. BTW, we also suggest to use '--base' option to specify > > the > > base tree in git format-patch, please see > > https://stackoverflow.com/a/37406982] > > > > url: > > https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-pl111-Credit-where-credit-is-due/20200610-041025 > > base: > > https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git > > exynos-drm-next > > reproduce: make htmldocs > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > What on earth was that. The robot reports on a patch only adding a few lines > of comments as breaking the whole universe, and none of these systems > even use the PL111. Thanks for feedback, this is supposed to check make htmldocs. We will double check this to fix issue. Sorry for noise. > > Yours, > Linus Walleij > ___ > kbuild-all mailing list -- kbuild-...@lists.01.org > To unsubscribe send an email to kbuild-all-le...@lists.01.org ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 4/4] drm: pl111: Update documentation
Hi Linus. On Fri, Jun 12, 2020 at 01:04:02PM +0200, Linus Walleij wrote: > On Wed, Jun 10, 2020 at 9:38 AM kernel test robot wrote: > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on drm-exynos/exynos-drm-next] > > [also build test WARNING on drm-intel/for-linux-next > > tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200609] > > [cannot apply to drm-tip/drm-tip drm/drm-next] > > [if your patch is applied to the wrong git tree, please drop us a note to > > help > > improve the system. BTW, we also suggest to use '--base' option to specify > > the > > base tree in git format-patch, please see > > https://stackoverflow.com/a/37406982] > > > > url: > > https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-pl111-Credit-where-credit-is-due/20200610-041025 > > base: > > https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git > > exynos-drm-next > > reproduce: make htmldocs > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > What on earth was that. The robot reports on a patch only adding a few lines > of comments as breaking the whole universe, and none of these systems > even use the PL111. The patch changes this: /** - * DOC: ARM PrimeCell PL111 CLCD Driver + * DOC: ARM PrimeCell PL110 and PL111 CLCD Driver The "DOC: ARM PrimeCell PL111 CLCD Driver" is used by kernel-doc to match the DOC section. So this patch caused a new warning when one odes "make htmldocs". See Documentation/gpu/pl111.rst Sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 4/4] drm: pl111: Update documentation
On Wed, Jun 10, 2020 at 9:38 AM kernel test robot wrote: > I love your patch! Perhaps something to improve: > > [auto build test WARNING on drm-exynos/exynos-drm-next] > [also build test WARNING on drm-intel/for-linux-next > tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200609] > [cannot apply to drm-tip/drm-tip drm/drm-next] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see > https://stackoverflow.com/a/37406982] > > url: > https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-pl111-Credit-where-credit-is-due/20200610-041025 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git > exynos-drm-next > reproduce: make htmldocs > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot What on earth was that. The robot reports on a patch only adding a few lines of comments as breaking the whole universe, and none of these systems even use the PL111. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 4/4] drm: pl111: Update documentation
Hi Linus, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-exynos/exynos-drm-next] [also build test WARNING on drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master v5.7 next-20200609] [cannot apply to drm-tip/drm-tip drm/drm-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-pl111-Credit-where-credit-is-due/20200610-041025 base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next reproduce: make htmldocs If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>, old ones prefixed by <<): include/kunit/test.h:182: warning: Function parameter or member 'debugfs' not described in 'kunit_suite' include/kunit/test.h:182: warning: Function parameter or member 'log' not described in 'kunit_suite' include/kunit/test.h:268: warning: Excess function parameter 'suites' description in 'kunit_test_suites' include/net/mac80211.h:832: warning: Enum value 'IEEE80211_TX_CTRL_HW_80211_ENCAP' not described in enum 'mac80211_tx_control_flags' net/mac80211/sta_info.h:104: warning: Enum value 'WLAN_STA_USES_ENCRYPTION' not described in enum 'ieee80211_sta_info_flags' drivers/dma-buf/dma-buf.c:678: warning: Function parameter or member 'importer_ops' not described in 'dma_buf_dynamic_attach' drivers/dma-buf/dma-buf.c:678: warning: Function parameter or member 'importer_priv' not described in 'dma_buf_dynamic_attach' include/linux/dma-buf.h:347: warning: Incorrect use of kernel-doc format: * @move_notify include/linux/gpio/driver.h:499: warning: Function parameter or member 'gc' not described in 'gpiochip_add_data' include/linux/gpio/driver.h:499: warning: Excess function parameter 'chip' description in 'gpiochip_add_data' include/linux/iio/iio.h:574: warning: Function parameter or member 'read_buf' not described in 'iio_dev' include/linux/iio/iio.h:574: warning: Function parameter or member 'read_buf_len' not described in 'iio_dev' drivers/infiniband/core/umem_odp.c:161: warning: Function parameter or member 'ops' not described in 'ib_umem_odp_alloc_child' drivers/infiniband/core/umem_odp.c:225: warning: Function parameter or member 'ops' not described in 'ib_umem_odp_get' drivers/infiniband/ulp/iser/iscsi_iser.h:401: warning: Function parameter or member 'all_list' not described in 'iser_fr_desc' drivers/infiniband/ulp/iser/iscsi_iser.h:415: warning: Function parameter or member 'all_list' not described in 'iser_fr_pool' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd0' not described in 'opa_vesw_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd1' not described in 'opa_vesw_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd2' not described in 'opa_vesw_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd3' not described in 'opa_vesw_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd4' not described in 'opa_vesw_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd0' not described in 'opa_per_veswport_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd1' not described in 'opa_per_veswport_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd2' not described in 'opa_per_veswport_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd3' not described in 'opa_per_veswport_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:342: warning: Function parameter or member 'reserved' not described in 'opa_veswport_summary_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd0' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd1' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd2' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd3' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd4' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function
Re: [PATCH 4/4] drm: pl111: Update documentation
On Tue, Jun 9, 2020 at 1:17 PM Linus Walleij wrote: > > On Tue, Jun 9, 2020 at 10:11 PM Eric Anholt wrote: > > > FWIW, series is Reviewed-by: Eric Anholt > > Thanks Eric, do I remember correct that you were using this > driver for something like a clock display? Are you still using it > for that? > > Nowadays the biggest user is arguably the ARM FVP emulator > which is running a full Android stack using this driver. I've since moved on from Broadcom (now working at Google on open source qualcomm graphics) but as far as I know the HW team at broadcom making those phones will still be using this driver in combination with vc4. I had ported their phone as a vehicle to get vc4 onto more versions of the graphics chip and hopefully get more of bcm invested in open source graphics. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 4/4] drm: pl111: Update documentation
On Tue, Jun 9, 2020 at 10:11 PM Eric Anholt wrote: > FWIW, series is Reviewed-by: Eric Anholt Thanks Eric, do I remember correct that you were using this driver for something like a clock display? Are you still using it for that? Nowadays the biggest user is arguably the ARM FVP emulator which is running a full Android stack using this driver. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 4/4] drm: pl111: Update documentation
On Tue, Jun 9, 2020 at 1:08 PM Linus Walleij wrote: > > Remove notes about migrating from the old driver which is > retired as all users are now migrated. > > Update the text to reflect that we support PL110 and PL111 > alike. > > Drop the bullet on memory bandwidth scaling: this has been > implemented. > > Cc: Russell King > Signed-off-by: Linus Walleij FWIW, series is Reviewed-by: Eric Anholt ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 4/4] drm: pl111: Update documentation
Remove notes about migrating from the old driver which is retired as all users are now migrated. Update the text to reflect that we support PL110 and PL111 alike. Drop the bullet on memory bandwidth scaling: this has been implemented. Cc: Russell King Signed-off-by: Linus Walleij --- drivers/gpu/drm/pl111/pl111_drv.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c index 96e58fda75d8..46b0d1c4a16c 100644 --- a/drivers/gpu/drm/pl111/pl111_drv.c +++ b/drivers/gpu/drm/pl111/pl111_drv.c @@ -10,18 +10,11 @@ */ /** - * DOC: ARM PrimeCell PL111 CLCD Driver + * DOC: ARM PrimeCell PL110 and PL111 CLCD Driver * - * The PL111 is a simple LCD controller that can support TFT and STN - * displays. This driver exposes a standard KMS interface for them. - * - * This driver uses the same Device Tree binding as the fbdev CLCD - * driver. While the fbdev driver supports panels that may be - * connected to the CLCD internally to the CLCD driver, in DRM the - * panels get split out to drivers/gpu/drm/panels/. This means that, - * in converting from using fbdev to using DRM, you also need to write - * a panel driver (which may be as simple as an entry in - * panel-simple.c). + * The PL110/PL111 is a simple LCD controller that can support TFT + * and STN displays. This driver exposes a standard KMS interface + * for them. * * The driver currently doesn't expose the cursor. The DRM API for * cursors requires support for 64x64 ARGB cursor images, while @@ -29,16 +22,13 @@ * cursors. While one could imagine trying to hack something together * to look at the ARGB and program reasonable in monochrome, we * just don't expose the cursor at all instead, and leave cursor - * support to the X11 software cursor layer. + * support to the application software cursor layer. * * TODO: * * - Fix race between setting plane base address and getting IRQ for * vsync firing the pageflip completion. * - * - Use the "max-memory-bandwidth" DT property to filter the - * supported formats. - * * - Read back hardware state at boot to skip reprogramming the * hardware when doing a no-op modeset. * -- 2.25.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
