Re: [PATCH 4/8] drm/sun4i: Add optional 'mode' property to TCON

[Maxime Ripard]

Hi,

On Sat, Feb 11, 2017 at 07:44:01PM +0200, Priit Laes wrote:
> Add variable to enable either 'rgb' or 'lvds' output.
> 
> Signed-off-by: Priit Laes 
> ---
>  Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt 
> b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> index b82c004..c367ede 100644
> --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> @@ -43,6 +43,9 @@ Required properties:
>   - reset-names: the reset names mentioned above
>   - clock-output-names: Name of the pixel clock created
>  
> +- mode: Defines which encoder will be enabled. Values are 'rgb', 'lvds'.
> +  Defaults to 'rgb' if not set.
> +

Unfortunately, this won't really work. You could very well have two
panels and switch from one to another by changing the pin muxing, so
we have to use an enpoint for that.

This is pretty much the same case that we have with the A10s where we
need to have two output endpoints for the TV Encoder and HDMI,
something we cannot support right now in our binding, since we assume
that we have the two channels that only have one user, which turned
out to be wrong.

I guess an easy way would be to have an extra property defining which
channel the endpoint is attached to.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/8] drm/sun4i: Add optional 'mode' property to TCON

[Philippe Fouquet]

First way thank for this work
But I can't use it, I'm explain myself.

My LVDS connexion works fine because I display correctly the console under 
uboot (I work with CONFIG_VIDEO_LCD_MODE)

I use the wiki : http://linux-sunxi.org/LCD to convert my fex config to 
CONFIG_VIDEO_LCD_MODE for the uboot all work fine

But for the kernel nothing, I have some crazy line or black screen.

   - I add my lcd configuration into simple_panel.c (
   http://linux-sunxi.org/LCD)
   - I can seen the debug ligne came from LVDS driver.
   - My LCD screen is a dlc070ddg 7' 800x480 LVDS 18bits.
   - I work with a Olimex_A20-OLinuXino-Micro 
   .

I don't know where I can search If some body have a idea?

Thanks 

Le samedi 11 février 2017 18:44:59 UTC+1, Priit Laes a écrit :
>
> Add variable to enable either 'rgb' or 'lvds' output. 
>
> Signed-off-by: Priit Laes > 
> --- 
>  Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 3 +++ 
>  1 file changed, 3 insertions(+) 
>
> diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt 
> b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt 
> index b82c004..c367ede 100644 
> --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt 
> +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt 
> @@ -43,6 +43,9 @@ Required properties: 
>   - reset-names: the reset names mentioned above 
>   - clock-output-names: Name of the pixel clock created 
>   
> +- mode: Defines which encoder will be enabled. Values are 'rgb', 'lvds'. 
> +  Defaults to 'rgb' if not set. 
> + 
>  - ports: A ports node with endpoint definitions as defined in 
>Documentation/devicetree/bindings/media/video-interfaces.txt. The 
>first port should be the input endpoint, the second one the output 
> -- 
> 2.9.3 
>
>___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 4/8] drm/sun4i: Add optional 'mode' property to TCON

[Priit Laes]

Add variable to enable either 'rgb' or 'lvds' output.

Signed-off-by: Priit Laes 
---
 Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt 
b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
index b82c004..c367ede 100644
--- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
+++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
@@ -43,6 +43,9 @@ Required properties:
  - reset-names: the reset names mentioned above
  - clock-output-names: Name of the pixel clock created
 
+- mode: Defines which encoder will be enabled. Values are 'rgb', 'lvds'.
+  Defaults to 'rgb' if not set.
+
 - ports: A ports node with endpoint definitions as defined in
   Documentation/devicetree/bindings/media/video-interfaces.txt. The
   first port should be the input endpoint, the second one the output
-- 
2.9.3

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel