>-Original Message-
>From: Intel-gfx On Behalf Of Ville
>Syrjala
>Sent: Thursday, June 20, 2019 7:57 PM
>To: dri-devel@lists.freedesktop.org
>Cc: intel-...@lists.freedesktop.org; Ilia Mirkin
>Subject: [Intel-gfx] [PATCH 5/5] drm/i915: Drop redundant aspec ratio prop
>value
>initialization
>
>From: Ville Syrjälä
>
>HDMI_PICTURE_ASPECT_NONE is zero and the connector state is kzalloc()'d so no
>need to initialize conn_state->picture_aspect_ratio with it.
Looks good to me.
Reviewed-by: Uma Shankar
>Cc: Ilia Mirkin
>Signed-off-by: Ville Syrjälä
>---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 1 -
>drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
> 2 files changed, 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
>b/drivers/gpu/drm/i915/display/intel_hdmi.c
>index 6a4650b44ac6..f95f3db5ecb8 100644
>--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>@@ -2809,7 +2809,6 @@ intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi,
>struct drm_connector *c
> intel_attach_colorspace_property(connector);
>
> drm_connector_attach_content_type_property(connector);
>- connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
>
> if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
> drm_object_attach_property(&connector->base,
>diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c
>b/drivers/gpu/drm/i915/display/intel_sdvo.c
>index 5cb619613157..c471fcce59f8 100644
>--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
>+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
>@@ -2624,7 +2624,6 @@ intel_sdvo_add_hdmi_properties(struct intel_sdvo
>*intel_sdvo,
> intel_attach_broadcast_rgb_property(&connector->base.base);
> }
> intel_attach_aspect_ratio_property(&connector->base.base);
>- connector->base.base.state->picture_aspect_ratio =
>HDMI_PICTURE_ASPECT_NONE;
> }
>
> static struct intel_sdvo_connector *intel_sdvo_connector_alloc(void)
>--
>2.21.0
>
>___
>Intel-gfx mailing list
>intel-...@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
