[PATCH 5/6] accel/habanalabs: remove duplicated disable pci msg

2023-03-23 Thread Oded Gabbay
From: Tal Cohen 

The disable pci message is sent in reset device. It informs the FW not
to raise more EQs. The Driver may ignore received EQs, when the device
is in disabled mode.
The duplication happens when hard reset is scheduled during compute
reset and also performs 'escalate_reset_flow'.

Signed-off-by: Tal Cohen 
Reviewed-by: Oded Gabbay 
Signed-off-by: Oded Gabbay 
---
 drivers/accel/habanalabs/common/device.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/accel/habanalabs/common/device.c 
b/drivers/accel/habanalabs/common/device.c
index 2fb1e2ec3a83..c36de13d6729 100644
--- a/drivers/accel/habanalabs/common/device.c
+++ b/drivers/accel/habanalabs/common/device.c
@@ -1822,9 +1822,7 @@ int hl_device_reset(struct hl_device *hdev, u32 flags)
dev_info(hdev->dev, "Performing hard reset scheduled 
during compute reset\n");
flags = hdev->reset_info.hard_reset_schedule_flags;
hdev->reset_info.hard_reset_schedule_flags = 0;
-   hdev->disabled = true;
hard_reset = true;
-   handle_reset_trigger(hdev, flags);
goto escalate_reset_flow;
}
}
-- 
2.40.0



Re: [PATCH 5/6] accel/habanalabs: remove duplicated disable pci msg

2023-03-24 Thread Stanislaw Gruszka
On Thu, Mar 23, 2023 at 01:35:24PM +0200, Oded Gabbay wrote:
> From: Tal Cohen 
> 
> The disable pci message is sent in reset device. It informs the FW not
> to raise more EQs. The Driver may ignore received EQs, when the device
> is in disabled mode.
> The duplication happens when hard reset is scheduled during compute
> reset and also performs 'escalate_reset_flow'.
> 
> Signed-off-by: Tal Cohen 
> Reviewed-by: Oded Gabbay 
> Signed-off-by: Oded Gabbay 
Reviewed-by: Stanislaw Gruszka