Re: [PATCH 5/8] accel/ivpu: Improve clarity of MMU error messages

[Jeffrey Hugo]

On 4/2/2024 4:49 AM, Jacek Lawrynowicz wrote:

From: "Wachowski, Karol" 

This patch improves readability and clarity of MMU error messages.
Previously, the error strings were somewhat confusing and could lead to
ambiguous interpretations, making it difficult to diagnose issues.

Signed-off-by: Wachowski, Karol 
Signed-off-by: Jacek Lawrynowicz 


Reviewed-by: Jeffrey Hugo 

[PATCH 5/8] accel/ivpu: Improve clarity of MMU error messages

[Jacek Lawrynowicz]

From: "Wachowski, Karol" 

This patch improves readability and clarity of MMU error messages.
Previously, the error strings were somewhat confusing and could lead to
ambiguous interpretations, making it difficult to diagnose issues.

Signed-off-by: Wachowski, Karol 
Signed-off-by: Jacek Lawrynowicz 
---
 drivers/accel/ivpu/ivpu_mmu.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/accel/ivpu/ivpu_mmu.c b/drivers/accel/ivpu/ivpu_mmu.c
index 91bd640655ab..2e46b322c450 100644
--- a/drivers/accel/ivpu/ivpu_mmu.c
+++ b/drivers/accel/ivpu/ivpu_mmu.c
@@ -278,7 +278,7 @@ static const char *ivpu_mmu_event_to_str(u32 cmd)
case IVPU_MMU_EVT_F_VMS_FETCH:
return "Fetch of VMS caused external abort";
default:
-   return "Unknown CMDQ command";
+   return "Unknown event";
}
 }
 
@@ -286,15 +286,15 @@ static const char *ivpu_mmu_cmdq_err_to_str(u32 err)
 {
switch (err) {
case IVPU_MMU_CERROR_NONE:
-   return "No CMDQ Error";
+   return "No error";
case IVPU_MMU_CERROR_ILL:
return "Illegal command";
case IVPU_MMU_CERROR_ABT:
-   return "External abort on CMDQ read";
+   return "External abort on command queue read";
case IVPU_MMU_CERROR_ATC_INV_SYNC:
return "Sync failed to complete ATS invalidation";
default:
-   return "Unknown CMDQ Error";
+   return "Unknown error";
}
 }
 
-- 
2.43.2