Re: [PATCH 5/8] drm/tilcdc: Drop drm_gem_fb_create wrapper

2019-11-19 Thread Daniel Vetter 
On Fri, Nov 15, 2019 at 03:21:20PM +0200, Jyri Sarha wrote:
> On 15/11/2019 11:21, Daniel Vetter wrote:
> > Doesn't do anything.
> > 
> > Signed-off-by: Daniel Vetter 
> > Cc: Jyri Sarha 
> > Cc: Tomi Valkeinen 
> 
> Acked-by: Jyri Sarha 

Thanks for taking a look, pushed to drm-misc-next.
-Daniel

> 
> > ---
> >  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 8 +---
> >  1 file changed, 1 insertion(+), 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c 
> > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> > index 2a9e67597375..a160880bea0a 100644
> > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> > @@ -64,12 +64,6 @@ void tilcdc_module_cleanup(struct tilcdc_module *mod)
> >  
> >  static struct of_device_id tilcdc_of_match[];
> >  
> > -static struct drm_framebuffer *tilcdc_fb_create(struct drm_device *dev,
> > -   struct drm_file *file_priv, const struct drm_mode_fb_cmd2 
> > *mode_cmd)
> > -{
> > -   return drm_gem_fb_create(dev, file_priv, mode_cmd);
> > -}
> > -
> >  static int tilcdc_atomic_check(struct drm_device *dev,
> >struct drm_atomic_state *state)
> >  {
> > @@ -140,7 +134,7 @@ static int tilcdc_commit(struct drm_device *dev,
> >  }
> >  
> >  static const struct drm_mode_config_funcs mode_config_funcs = {
> > -   .fb_create = tilcdc_fb_create,
> > +   .fb_create = drm_gem_fb_create,
> > .atomic_check = tilcdc_atomic_check,
> > .atomic_commit = tilcdc_commit,
> >  };
> > 
> 
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 5/8] drm/tilcdc: Drop drm_gem_fb_create wrapper

2019-11-15 Thread Jyri Sarha 
On 15/11/2019 11:21, Daniel Vetter wrote:
> Doesn't do anything.
> 
> Signed-off-by: Daniel Vetter 
> Cc: Jyri Sarha 
> Cc: Tomi Valkeinen 

Acked-by: Jyri Sarha 

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 8 +---
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c 
> b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 2a9e67597375..a160880bea0a 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -64,12 +64,6 @@ void tilcdc_module_cleanup(struct tilcdc_module *mod)
>  
>  static struct of_device_id tilcdc_of_match[];
>  
> -static struct drm_framebuffer *tilcdc_fb_create(struct drm_device *dev,
> - struct drm_file *file_priv, const struct drm_mode_fb_cmd2 
> *mode_cmd)
> -{
> - return drm_gem_fb_create(dev, file_priv, mode_cmd);
> -}
> -
>  static int tilcdc_atomic_check(struct drm_device *dev,
>  struct drm_atomic_state *state)
>  {
> @@ -140,7 +134,7 @@ static int tilcdc_commit(struct drm_device *dev,
>  }
>  
>  static const struct drm_mode_config_funcs mode_config_funcs = {
> - .fb_create = tilcdc_fb_create,
> + .fb_create = drm_gem_fb_create,
>   .atomic_check = tilcdc_atomic_check,
>   .atomic_commit = tilcdc_commit,
>  };
> 


-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 5/8] drm/tilcdc: Drop drm_gem_fb_create wrapper

2019-11-15 Thread Daniel Vetter 
Doesn't do anything.

Signed-off-by: Daniel Vetter 
Cc: Jyri Sarha 
Cc: Tomi Valkeinen 
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c 
b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 2a9e67597375..a160880bea0a 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -64,12 +64,6 @@ void tilcdc_module_cleanup(struct tilcdc_module *mod)
 
 static struct of_device_id tilcdc_of_match[];
 
-static struct drm_framebuffer *tilcdc_fb_create(struct drm_device *dev,
-   struct drm_file *file_priv, const struct drm_mode_fb_cmd2 
*mode_cmd)
-{
-   return drm_gem_fb_create(dev, file_priv, mode_cmd);
-}
-
 static int tilcdc_atomic_check(struct drm_device *dev,
   struct drm_atomic_state *state)
 {
@@ -140,7 +134,7 @@ static int tilcdc_commit(struct drm_device *dev,
 }
 
 static const struct drm_mode_config_funcs mode_config_funcs = {
-   .fb_create = tilcdc_fb_create,
+   .fb_create = drm_gem_fb_create,
.atomic_check = tilcdc_atomic_check,
.atomic_commit = tilcdc_commit,
 };
-- 
2.24.0

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel