Re: [PATCH 6/6] accel/habanalabs: send disable pci when compute ctx is active

[Stanislaw Gruszka]

On Thu, Mar 23, 2023 at 01:35:25PM +0200, Oded Gabbay wrote:
> From: Tal Cohen 
> 
> Fix an issue in hard reset flow in which the driver didn't send a
> disable pci message if there was an active compute context.
> In hard reset, disable pci message should be sent no matter if
> a compute context exists or not.
> 
> Signed-off-by: Tal Cohen 
> Reviewed-by: Oded Gabbay 
> Signed-off-by: Oded Gabbay 
Reviewed-by: Stanislaw Gruszka 

[PATCH 6/6] accel/habanalabs: send disable pci when compute ctx is active

[Oded Gabbay]

From: Tal Cohen 

Fix an issue in hard reset flow in which the driver didn't send a
disable pci message if there was an active compute context.
In hard reset, disable pci message should be sent no matter if
a compute context exists or not.

Signed-off-by: Tal Cohen 
Reviewed-by: Oded Gabbay 
Signed-off-by: Oded Gabbay 
---
 drivers/accel/habanalabs/common/device.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/accel/habanalabs/common/device.c 
b/drivers/accel/habanalabs/common/device.c
index c36de13d6729..3c1af9d43b65 100644
--- a/drivers/accel/habanalabs/common/device.c
+++ b/drivers/accel/habanalabs/common/device.c
@@ -1386,7 +1386,7 @@ static void handle_reset_trigger(struct hl_device *hdev, 
u32 flags)
 
/* No consecutive mechanism when user context exists */
if (hdev->is_compute_ctx_active)
-   return;
+   goto disable_pci;
 
/*
 * 'reset cause' is being updated here, because getting here
@@ -1425,6 +1425,8 @@ static void handle_reset_trigger(struct hl_device *hdev, 
u32 flags)
 * If F/W is performing the reset, no need to send it a message to 
disable
 * PCI access
 */
+
+disable_pci:
if ((flags & HL_DRV_RESET_HARD) &&
!(flags & (HL_DRV_RESET_HEARTBEAT | 
HL_DRV_RESET_BYPASS_REQ_TO_FW))) {
/* Disable PCI access from device F/W so he won't send
-- 
2.40.0