Re: [PATCH 6/7] drm/tda998x: Don't set dpms hook
On Fri, Jan 11, 2019 at 11:22 PM Russell King - ARM Linux
wrote:
> On Fri, Jan 11, 2019 at 10:55:42PM +0100, Daniel Vetter wrote:
> > On Fri, Jan 11, 2019 at 04:41:21PM +0100, Noralf Trønnes wrote:
> > > Den 17.12.2018 20.43, skrev Daniel Vetter:
> > > > Doesn't do anything for atomic drivers.
> > > >
> > > > Signed-off-by: Daniel Vetter
> > > > Cc: Russell King
> > > > ---
> > > > drivers/gpu/drm/i2c/tda998x_drv.c | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
> > > > b/drivers/gpu/drm/i2c/tda998x_drv.c
> > > > index a7c39f39793f..f8a1d70a31c7 100644
> > > > --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> > > > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> > > > @@ -1122,7 +1122,6 @@ static void tda998x_connector_destroy(struct
> > > > drm_connector *connector)
> > > > }
> > > >
> > > > static const struct drm_connector_funcs tda998x_connector_funcs = {
> > > > - .dpms = drm_helper_connector_dpms,
> > > > .reset = drm_atomic_helper_connector_reset,
> > > > .fill_modes = drm_helper_probe_single_connector_modes,
> > > > .detect = tda998x_connector_detect,
> > > >
> > >
> > > Acked-by: Noralf Trønnes
> >
> > Thanks for taking a look. The next patch unfortunately needs a lot more
> > work, and quite some coordination with other trees, due to all the
> > in-flight drmP.h cleanups. I think I'll wait a bit before resending that
> > one again.
>
> Are there any dependencies that would affect where the above patch can
> be applied?
It's all prep work for the drm_probe_helper.h split-out, which is why
I'm stuffing all these into drm-misc-next. There's also good conflict
potential with other ongoing header cleanup around drmP.h, which is
also going in through drm-misc-next. If all goes well this should all
have settled into drm-next in 1-2 weeks latest.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 6/7] drm/tda998x: Don't set dpms hook
On Fri, Jan 11, 2019 at 10:55:42PM +0100, Daniel Vetter wrote:
> On Fri, Jan 11, 2019 at 04:41:21PM +0100, Noralf Trønnes wrote:
> > Den 17.12.2018 20.43, skrev Daniel Vetter:
> > > Doesn't do anything for atomic drivers.
> > >
> > > Signed-off-by: Daniel Vetter
> > > Cc: Russell King
> > > ---
> > > drivers/gpu/drm/i2c/tda998x_drv.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
> > > b/drivers/gpu/drm/i2c/tda998x_drv.c
> > > index a7c39f39793f..f8a1d70a31c7 100644
> > > --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> > > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> > > @@ -1122,7 +1122,6 @@ static void tda998x_connector_destroy(struct
> > > drm_connector *connector)
> > > }
> > >
> > > static const struct drm_connector_funcs tda998x_connector_funcs = {
> > > - .dpms = drm_helper_connector_dpms,
> > > .reset = drm_atomic_helper_connector_reset,
> > > .fill_modes = drm_helper_probe_single_connector_modes,
> > > .detect = tda998x_connector_detect,
> > >
> >
> > Acked-by: Noralf Trønnes
>
> Thanks for taking a look. The next patch unfortunately needs a lot more
> work, and quite some coordination with other trees, due to all the
> in-flight drmP.h cleanups. I think I'll wait a bit before resending that
> one again.
Are there any dependencies that would affect where the above patch can
be applied?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 6/7] drm/tda998x: Don't set dpms hook
On Fri, Jan 11, 2019 at 04:41:21PM +0100, Noralf Trønnes wrote:
> Den 17.12.2018 20.43, skrev Daniel Vetter:
> > Doesn't do anything for atomic drivers.
> >
> > Signed-off-by: Daniel Vetter
> > Cc: Russell King
> > ---
> > drivers/gpu/drm/i2c/tda998x_drv.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
> > b/drivers/gpu/drm/i2c/tda998x_drv.c
> > index a7c39f39793f..f8a1d70a31c7 100644
> > --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> > @@ -1122,7 +1122,6 @@ static void tda998x_connector_destroy(struct
> > drm_connector *connector)
> > }
> >
> > static const struct drm_connector_funcs tda998x_connector_funcs = {
> > - .dpms = drm_helper_connector_dpms,
> > .reset = drm_atomic_helper_connector_reset,
> > .fill_modes = drm_helper_probe_single_connector_modes,
> > .detect = tda998x_connector_detect,
> >
>
> Acked-by: Noralf Trønnes
Thanks for taking a look. The next patch unfortunately needs a lot more
work, and quite some coordination with other trees, due to all the
in-flight drmP.h cleanups. I think I'll wait a bit before resending that
one again.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 6/7] drm/tda998x: Don't set dpms hook
Den 17.12.2018 20.43, skrev Daniel Vetter:
> Doesn't do anything for atomic drivers.
>
> Signed-off-by: Daniel Vetter
> Cc: Russell King
> ---
> drivers/gpu/drm/i2c/tda998x_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
> b/drivers/gpu/drm/i2c/tda998x_drv.c
> index a7c39f39793f..f8a1d70a31c7 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -1122,7 +1122,6 @@ static void tda998x_connector_destroy(struct
> drm_connector *connector)
> }
>
> static const struct drm_connector_funcs tda998x_connector_funcs = {
> - .dpms = drm_helper_connector_dpms,
> .reset = drm_atomic_helper_connector_reset,
> .fill_modes = drm_helper_probe_single_connector_modes,
> .detect = tda998x_connector_detect,
>
Acked-by: Noralf Trønnes
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 6/7] drm/tda998x: Don't set dpms hook
Doesn't do anything for atomic drivers.
Signed-off-by: Daniel Vetter
Cc: Russell King
---
drivers/gpu/drm/i2c/tda998x_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm/i2c/tda998x_drv.c
index a7c39f39793f..f8a1d70a31c7 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1122,7 +1122,6 @@ static void tda998x_connector_destroy(struct
drm_connector *connector)
}
static const struct drm_connector_funcs tda998x_connector_funcs = {
- .dpms = drm_helper_connector_dpms,
.reset = drm_atomic_helper_connector_reset,
.fill_modes = drm_helper_probe_single_connector_modes,
.detect = tda998x_connector_detect,
--
2.20.0.rc1
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
