Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"
On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote:
> On 2017年09月26日 13:12, Daniel Vetter wrote:
> > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote:
> > > On 2017年09月21日 06:29, Thomas Meyer wrote:
> > > > Use vma_pages function on vma object instead of explicit computation.
> > > > Found by coccinelle spatch "api/vma_pages.cocci"
> > > >
> > > > Signed-off-by: Thomas Meyer
> > > > ---
> > > Looks good for me:
> > > Acked-by: Mark Yao
> > Once more a maintainer who acks a patch and doesn't push it. This is
> > really confusing, who exactly do you expect to handle this patch for you?
> >
> > Please push to drm-misc-next (also for future patches), thanks.
> > -Daniel
>
> Hi Daniel
> I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of
> patches and maybe it can pushed by series.
>
> Ok, Pushed it to drm-misc-next.
Hm right, but I only see 7/7 here. Either way, except when the author asks
for a preferred tree it's best if you just pick things up right away. And
if you're unsure, just ask instead of risking that a patch drops through
the cracks.
-Daniel
>
> >
> > > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > > > b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_
> > > >{
> > > > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
> > > > unsigned int i, count = obj->size >> PAGE_SHIFT;
> > > > - unsigned long user_count = (vma->vm_end - vma->vm_start) >>
> > > > PAGE_SHIFT;
> > > > + unsigned long user_count = vma_pages(vma);
> > > > unsigned long uaddr = vma->vm_start;
> > > > unsigned long offset = vma->vm_pgoff;
> > > > unsigned long end = user_count + offset;
> > > >
> > > > ___
> > > > Linux-rockchip mailing list
> > > > linux-rockc...@lists.infradead.org
> > > > http://lists.infradead.org/mailman/listinfo/linux-rockchip
> > > >
> > > >
> > > >
> > > --
> > > Ｍark Yao
> > >
> > >
> > > ___
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
> --
> Ｍark Ya
>
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"
On 2017年09月26日 13:12, Daniel Vetter wrote:
On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote:
On 2017年09月21日 06:29, Thomas Meyer wrote:
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
Looks good for me:
Acked-by: Mark Yao
Once more a maintainer who acks a patch and doesn't push it. This is
really confusing, who exactly do you expect to handle this patch for you?
Please push to drm-misc-next (also for future patches), thanks.
-Daniel
Hi Daniel
I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of
patches and maybe it can pushed by series.
Ok, Pushed it to drm-misc-next.
diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_
{
struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
unsigned int i, count = obj->size >> PAGE_SHIFT;
- unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+ unsigned long user_count = vma_pages(vma);
unsigned long uaddr = vma->vm_start;
unsigned long offset = vma->vm_pgoff;
unsigned long end = user_count + offset;
___
Linux-rockchip mailing list
linux-rockc...@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
--
Ｍark Yao
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ｍark Ya
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"
On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote:
> On 2017年09月21日 06:29, Thomas Meyer wrote:
> > Use vma_pages function on vma object instead of explicit computation.
> > Found by coccinelle spatch "api/vma_pages.cocci"
> >
> > Signed-off-by: Thomas Meyer
> > ---
> Looks good for me:
> Acked-by: Mark Yao
Once more a maintainer who acks a patch and doesn't push it. This is
really confusing, who exactly do you expect to handle this patch for you?
Please push to drm-misc-next (also for future patches), thanks.
-Daniel
>
> >
> > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_
> > {
> > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
> > unsigned int i, count = obj->size >> PAGE_SHIFT;
> > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> > + unsigned long user_count = vma_pages(vma);
> > unsigned long uaddr = vma->vm_start;
> > unsigned long offset = vma->vm_pgoff;
> > unsigned long end = user_count + offset;
> >
> > ___
> > Linux-rockchip mailing list
> > linux-rockc...@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
> >
> >
> >
>
> --
> Ｍark Yao
>
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_
{
struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
unsigned int i, count = obj->size >> PAGE_SHIFT;
- unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+ unsigned long user_count = vma_pages(vma);
unsigned long uaddr = vma->vm_start;
unsigned long offset = vma->vm_pgoff;
unsigned long end = user_count + offset;
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"
On 2017年09月21日 06:29, Thomas Meyer wrote:
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
Looks good for me:
Acked-by: Mark Yao
diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_
{
struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
unsigned int i, count = obj->size >> PAGE_SHIFT;
- unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+ unsigned long user_count = vma_pages(vma);
unsigned long uaddr = vma->vm_start;
unsigned long offset = vma->vm_pgoff;
unsigned long end = user_count + offset;
___
Linux-rockchip mailing list
linux-rockc...@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
--
Ｍark Yao
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
