Re: [PATCH 8/8] drm/ssd130x: Switch preferred_bpp/depth to 1

[Javier Martinez Canillas]

Geert Uytterhoeven  writes:

> The native display format is R1.  Hence change the preferred_depth and
> preferred_bpp to 1, to avoid the overhead of using XR24 and the
> associated conversions when using fbdev emulation and its text console.
>
> Signed-off-by: Geert Uytterhoeven 
> ---

Reviewed-by: Javier Martinez Canillas 

Thanks again for the series!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

[PATCH 8/8] drm/ssd130x: Switch preferred_bpp/depth to 1

[Geert Uytterhoeven]

The native display format is R1.  Hence change the preferred_depth and
preferred_bpp to 1, to avoid the overhead of using XR24 and the
associated conversions when using fbdev emulation and its text console.

Signed-off-by: Geert Uytterhoeven 
---
 drivers/gpu/drm/solomon/ssd130x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/solomon/ssd130x.c 
b/drivers/gpu/drm/solomon/ssd130x.c
index 130e33a1ba3cba00..93af2e5fc816b5f0 100644
--- a/drivers/gpu/drm/solomon/ssd130x.c
+++ b/drivers/gpu/drm/solomon/ssd130x.c
@@ -945,7 +945,7 @@ static int ssd130x_init_modeset(struct ssd130x_device 
*ssd130x)
drm->mode_config.max_width = max_width;
drm->mode_config.min_height = mode->vdisplay;
drm->mode_config.max_height = max_height;
-   drm->mode_config.preferred_depth = 24;
+   drm->mode_config.preferred_depth = 1;
drm->mode_config.funcs = _mode_config_funcs;
 
/* Primary plane */
@@ -1075,7 +1075,7 @@ struct ssd130x_device *ssd130x_probe(struct device *dev, 
struct regmap *regmap)
if (ret)
return ERR_PTR(dev_err_probe(dev, ret, "DRM device register 
failed\n"));
 
-   drm_fbdev_generic_setup(drm, 32);
+   drm_fbdev_generic_setup(drm, 1);
 
return ssd130x;
 }
-- 
2.34.1