[PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c

[Thomas Hellstrom]

On 01/07/2014 11:51 AM, Josh Triplett wrote:
> On Tue, Jan 07, 2014 at 11:21:12AM +0100, Jakob Bornecrantz wrote:
>> On Mon, Jan 6, 2014 at 5:48 PM, Rashika Kheria  
>> wrote:
>>> Mark functions as static because they are not used outside the file
>>> drm/vmwgfx/vmwgfx_kms.c.
>>>
>>> This eliminates the following warnings in drm/vmwgfx/vmwgfx_kms.c:
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:43:6: warning: no previous prototype 
>>> for ?vmw_clip_cliprects? [-Wmissing-prototypes]
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:426:6: warning: no previous prototype 
>>> for ?vmw_framebuffer_surface_destroy? [-Wmissing-prototypes]
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:592:5: warning: no previous prototype 
>>> for ?vmw_framebuffer_surface_dirty? [-Wmissing-prototypes]
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:757:6: warning: no previous prototype 
>>> for ?vmw_framebuffer_dmabuf_destroy? [-Wmissing-prototypes]
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:943:5: warning: no previous prototype 
>>> for ?vmw_framebuffer_dmabuf_dirty? [-Wmissing-prototypes]
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1666:5: warning: no previous prototype 
>>> for ?vmw_du_update_layout? [-Wmissing-prototypes]
>>>
>>> Signed-off-by: Rashika Kheria 
>>> Reviewed-by: Josh Triplett 
>>> ---
>>>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |   12 ++--
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> This and patch 83, 84, 85 are
>> Reviewed-by: Jakob Bornecrantz 
> Can you take them through your tree, or are you expecting them to follow
> another path?

I'll take them through vmwgfx-next. However, patch 83/85 conflicts
heavily with an internal vmwgfx patch series. If applicable, I'll apply
it after resolving those conflicts.

Thanks,

/Thomas



>
> - Josh Triplett
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c

[Jakob Bornecrantz]

On Mon, Jan 6, 2014 at 5:48 PM, Rashika Kheria  
wrote:
> Mark functions as static because they are not used outside the file
> drm/vmwgfx/vmwgfx_kms.c.
>
> This eliminates the following warnings in drm/vmwgfx/vmwgfx_kms.c:
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:43:6: warning: no previous prototype for 
> ?vmw_clip_cliprects? [-Wmissing-prototypes]
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:426:6: warning: no previous prototype for 
> ?vmw_framebuffer_surface_destroy? [-Wmissing-prototypes]
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:592:5: warning: no previous prototype for 
> ?vmw_framebuffer_surface_dirty? [-Wmissing-prototypes]
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:757:6: warning: no previous prototype for 
> ?vmw_framebuffer_dmabuf_destroy? [-Wmissing-prototypes]
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:943:5: warning: no previous prototype for 
> ?vmw_framebuffer_dmabuf_dirty? [-Wmissing-prototypes]
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1666:5: warning: no previous prototype 
> for ?vmw_du_update_layout? [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria 
> Reviewed-by: Josh Triplett 
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |   12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)


This and patch 83, 84, 85 are
Reviewed-by: Jakob Bornecrantz 

Cheers, Jakob.

[PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c

[Josh Triplett]

On Tue, Jan 07, 2014 at 11:21:12AM +0100, Jakob Bornecrantz wrote:
> On Mon, Jan 6, 2014 at 5:48 PM, Rashika Kheria  
> wrote:
> > Mark functions as static because they are not used outside the file
> > drm/vmwgfx/vmwgfx_kms.c.
> >
> > This eliminates the following warnings in drm/vmwgfx/vmwgfx_kms.c:
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:43:6: warning: no previous prototype 
> > for ?vmw_clip_cliprects? [-Wmissing-prototypes]
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:426:6: warning: no previous prototype 
> > for ?vmw_framebuffer_surface_destroy? [-Wmissing-prototypes]
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:592:5: warning: no previous prototype 
> > for ?vmw_framebuffer_surface_dirty? [-Wmissing-prototypes]
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:757:6: warning: no previous prototype 
> > for ?vmw_framebuffer_dmabuf_destroy? [-Wmissing-prototypes]
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:943:5: warning: no previous prototype 
> > for ?vmw_framebuffer_dmabuf_dirty? [-Wmissing-prototypes]
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1666:5: warning: no previous prototype 
> > for ?vmw_du_update_layout? [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria 
> > Reviewed-by: Josh Triplett 
> > ---
> >  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |   12 ++--
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> 
> This and patch 83, 84, 85 are
> Reviewed-by: Jakob Bornecrantz 

Can you take them through your tree, or are you expecting them to follow
another path?

- Josh Triplett

[PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c

[Rashika Kheria]

Mark functions as static because they are not used outside the file
drm/vmwgfx/vmwgfx_kms.c.

This eliminates the following warnings in drm/vmwgfx/vmwgfx_kms.c:
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:43:6: warning: no previous prototype for 
?vmw_clip_cliprects? [-Wmissing-prototypes]
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:426:6: warning: no previous prototype for 
?vmw_framebuffer_surface_destroy? [-Wmissing-prototypes]
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:592:5: warning: no previous prototype for 
?vmw_framebuffer_surface_dirty? [-Wmissing-prototypes]
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:757:6: warning: no previous prototype for 
?vmw_framebuffer_dmabuf_destroy? [-Wmissing-prototypes]
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:943:5: warning: no previous prototype for 
?vmw_framebuffer_dmabuf_dirty? [-Wmissing-prototypes]
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1666:5: warning: no previous prototype for 
?vmw_du_update_layout? [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria 
Reviewed-by: Josh Triplett 
---
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c 
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 03f1c20..6af4816 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -40,7 +40,7 @@ struct vmw_clip_rect {
  * Clip @num_rects number of @rects against @clip storing the
  * results in @out_rects and the number of passed rects in @out_num.
  */
-void vmw_clip_cliprects(struct drm_clip_rect *rects,
+static void vmw_clip_cliprects(struct drm_clip_rect *rects,
int num_rects,
struct vmw_clip_rect clip,
SVGASignedRect *out_rects,
@@ -423,7 +423,7 @@ struct vmw_framebuffer_surface {
struct drm_master *master;
 };

-void vmw_framebuffer_surface_destroy(struct drm_framebuffer *framebuffer)
+static void vmw_framebuffer_surface_destroy(struct drm_framebuffer 
*framebuffer)
 {
struct vmw_framebuffer_surface *vfbs =
vmw_framebuffer_to_vfbs(framebuffer);
@@ -589,7 +589,7 @@ out_free_tmp:
return ret;
 }

-int vmw_framebuffer_surface_dirty(struct drm_framebuffer *framebuffer,
+static int vmw_framebuffer_surface_dirty(struct drm_framebuffer *framebuffer,
  struct drm_file *file_priv,
  unsigned flags, unsigned color,
  struct drm_clip_rect *clips,
@@ -754,7 +754,7 @@ struct vmw_framebuffer_dmabuf {
struct vmw_dma_buffer *buffer;
 };

-void vmw_framebuffer_dmabuf_destroy(struct drm_framebuffer *framebuffer)
+static void vmw_framebuffer_dmabuf_destroy(struct drm_framebuffer *framebuffer)
 {
struct vmw_framebuffer_dmabuf *vfbd =
vmw_framebuffer_to_vfbd(framebuffer);
@@ -940,7 +940,7 @@ static int do_dmabuf_dirty_sou(struct drm_file *file_priv,
return ret;
 }

-int vmw_framebuffer_dmabuf_dirty(struct drm_framebuffer *framebuffer,
+static int vmw_framebuffer_dmabuf_dirty(struct drm_framebuffer *framebuffer,
 struct drm_file *file_priv,
 unsigned flags, unsigned color,
 struct drm_clip_rect *clips,
@@ -1663,7 +1663,7 @@ void vmw_disable_vblank(struct drm_device *dev, int crtc)
  * Small shared kms functions.
  */

-int vmw_du_update_layout(struct vmw_private *dev_priv, unsigned num,
+static int vmw_du_update_layout(struct vmw_private *dev_priv, unsigned num,
 struct drm_vmw_rect *rects)
 {
struct drm_device *dev = dev_priv->dev;
-- 
1.7.9.5