Re: [PATCH RESEND v3 00/15] drm/msm/dp: clear power and parser submodules away
On Fri, 26 Jan 2024 20:26:19 +0200, Dmitry Baryshkov wrote: > Reshuffle code in the DP driver, cleaning up clocks and DT parsing and > dropping the dp_power and dp_parser submodules. > > Initially I started by looking onto stream_pixel clock handling only to > find several wrapping layers around a single clocks. After inlining > and/or dropping them (and thus dp_power submodule), it was more or less > natural to continue cleaning up the dp_parser until it got removed > completely. > > [...] Applied, thanks! [01/15] drm/msm/dp: drop unused parser definitions https://gitlab.freedesktop.org/lumag/msm/-/commit/08c5b691ee54 [02/15] drm/msm/dp: drop unused fields from dp_power_private https://gitlab.freedesktop.org/lumag/msm/-/commit/9aeb50ea0ea9 [03/15] drm/msm/dp: parse DT from dp_parser_get https://gitlab.freedesktop.org/lumag/msm/-/commit/31a01db14b90 [04/15] drm/msm/dp: inline dp_power_(de)init https://gitlab.freedesktop.org/lumag/msm/-/commit/47103b582412 [05/15] drm/msm/dp: fold dp_power into dp_ctrl module https://gitlab.freedesktop.org/lumag/msm/-/commit/17cb153f81df [06/15] drm/msm/dp: simplify stream clocks handling https://gitlab.freedesktop.org/lumag/msm/-/commit/9bd0946d5ca1 [07/15] drm/msm/dp: stop parsing clock names from DT https://gitlab.freedesktop.org/lumag/msm/-/commit/77d0243a3313 [08/15] drm/msm/dp: split dp_ctrl_clk_enable into four functuions https://gitlab.freedesktop.org/lumag/msm/-/commit/e518c27218c6 [09/15] drm/msm/dp: move phy_configure_opts to dp_ctrl https://gitlab.freedesktop.org/lumag/msm/-/commit/b4745f741e79 [10/15] drm/msm/dp: remove PHY handling from dp_catalog.c https://gitlab.freedesktop.org/lumag/msm/-/commit/64eba0d63c70 [11/15] drm/msm/dp: handle PHY directly in dp_ctrl https://gitlab.freedesktop.org/lumag/msm/-/commit/f304bda5bfda [12/15] drm/msm/dp: move all IO handling to dp_catalog https://gitlab.freedesktop.org/lumag/msm/-/commit/1577814118e7 [13/15] drm/msm/dp: move link property handling to dp_panel https://gitlab.freedesktop.org/lumag/msm/-/commit/3ffe15b30a63 [14/15] drm/msm/dp: move next_bridge handling to dp_display https://gitlab.freedesktop.org/lumag/msm/-/commit/b3b1d122a80b [15/15] drm/msm/dp: drop dp_parser https://gitlab.freedesktop.org/lumag/msm/-/commit/6215f1558bab Best regards, -- Dmitry Baryshkov
Re: [PATCH RESEND v3 00/15] drm/msm/dp: clear power and parser submodules away
On Fri, 26 Jan 2024 at 20:26, Dmitry Baryshkov wrote: > > Reshuffle code in the DP driver, cleaning up clocks and DT parsing and > dropping the dp_power and dp_parser submodules. > > Initially I started by looking onto stream_pixel clock handling only to > find several wrapping layers around a single clocks. After inlining > and/or dropping them (and thus dp_power submodule), it was more or less > natural to continue cleaning up the dp_parser until it got removed > completely. I see. I have resent v3 because b4 for some reason didn't pick up R-b tags from v2. I didn't notice that `b4 send --resend` doesn't pick up changes and just resends the previous version. So I must beg your pardon for the spam. I'll push R-B tags via response emails. -- With best wishes Dmitry
[PATCH RESEND v3 00/15] drm/msm/dp: clear power and parser submodules away
Reshuffle code in the DP driver, cleaning up clocks and DT parsing and dropping the dp_power and dp_parser submodules. Initially I started by looking onto stream_pixel clock handling only to find several wrapping layers around a single clocks. After inlining and/or dropping them (and thus dp_power submodule), it was more or less natural to continue cleaning up the dp_parser until it got removed completely. --- Changes in v3: - Fixed crash in the DP when there is no next bridge (Kuogee) - Removed excess documentation for the removed dp_parser::io field - Link to v2: https://lore.kernel.org/r/20231231-dp-power-parser-cleanup-v2-0-fc3e902a6...@linaro.org Changes in v2: - Fixed unrelated power->ctrl change in comment (Konrad) - Made sure that all functions use reverse-Christmas-tree flow (Konrad) - Fixed indents in several moved functions - Added a patch splitting dp_ctlr_clk_enable - Link to v1: https://lore.kernel.org/r/20231229225650.912751-1-dmitry.barysh...@linaro.org --- Dmitry Baryshkov (15): drm/msm/dp: drop unused parser definitions drm/msm/dp: drop unused fields from dp_power_private drm/msm/dp: parse DT from dp_parser_get drm/msm/dp: inline dp_power_(de)init drm/msm/dp: fold dp_power into dp_ctrl module drm/msm/dp: simplify stream clocks handling drm/msm/dp: stop parsing clock names from DT drm/msm/dp: split dp_ctrl_clk_enable into four functuions drm/msm/dp: move phy_configure_opts to dp_ctrl drm/msm/dp: remove PHY handling from dp_catalog.c drm/msm/dp: handle PHY directly in dp_ctrl drm/msm/dp: move all IO handling to dp_catalog drm/msm/dp: move link property handling to dp_panel drm/msm/dp: move next_bridge handling to dp_display drm/msm/dp: drop dp_parser drivers/gpu/drm/msm/Makefile| 2 - drivers/gpu/drm/msm/dp/dp_aux.c | 9 +- drivers/gpu/drm/msm/dp/dp_aux.h | 2 + drivers/gpu/drm/msm/dp/dp_catalog.c | 156 +++- drivers/gpu/drm/msm/dp/dp_catalog.h | 6 +- drivers/gpu/drm/msm/dp/dp_ctrl.c| 358 drivers/gpu/drm/msm/dp/dp_ctrl.h| 17 +- drivers/gpu/drm/msm/dp/dp_debug.c | 1 - drivers/gpu/drm/msm/dp/dp_display.c | 102 +++--- drivers/gpu/drm/msm/dp/dp_display.h | 3 +- drivers/gpu/drm/msm/dp/dp_panel.c | 66 +++ drivers/gpu/drm/msm/dp/dp_parser.c | 327 drivers/gpu/drm/msm/dp/dp_parser.h | 155 drivers/gpu/drm/msm/dp/dp_power.c | 183 -- drivers/gpu/drm/msm/dp/dp_power.h | 95 -- 15 files changed, 465 insertions(+), 1017 deletions(-) --- base-commit: 39676dfe52331dba909c617f213fdb21015c8d10 change-id: 20231231-dp-power-parser-cleanup-9e3a5f9a6821 Best regards, -- Dmitry Baryshkov
