Re: [PATCH RFC 2/7] drm/panel: boe-tv101wum-nl6: use wrapped MIPI DCS functions

2024-05-10 Thread Doug Anderson 
Hi,

On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov
 wrote:
>
> Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to
> simplify driver's init/exit code.
>
> Signed-off-by: Dmitry Baryshkov 
> ---
>  drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 73 
> --
>  1 file changed, 21 insertions(+), 52 deletions(-)

Please CC Cong Yang (CCed here) on your next version since he's also
touching this file and your changes will conflict with his.


> @@ -1508,20 +1483,14 @@ static inline struct boe_panel *to_boe_panel(struct 
> drm_panel *panel)
>
>  static int boe_panel_enter_sleep_mode(struct boe_panel *boe)
>  {
> -   struct mipi_dsi_device *dsi = boe->dsi;
> -   int ret;
> -
> -   dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
> +   struct mipi_dsi_multi_context ctx = { .dsi = boe->dsi };
>
> -   ret = mipi_dsi_dcs_set_display_off(dsi);
> -   if (ret < 0)
> -   return ret;
> +   boe->dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
>
> -   ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
> -   if (ret < 0)
> -   return ret;
> +   mipi_dsi_dcs_set_display_off_multi(&ctx);
> +   mipi_dsi_dcs_enter_sleep_mode_multi(&ctx);
>
> -   return 0;
> +   return ctx.accum_err;
>  }

nit: since the "multi" functions print errors for you, you can get rid
of the (now duplicate) error print in the caller. I guess if you
really wanted to you could actually just inline
boe_panel_enter_sleep_mode() into its one caller and that would make
it easy to use the "_multi" version of msleep() there...

In any case, I think this looks nice:

Reviewed-by: Douglas Anderson

[PATCH RFC 2/7] drm/panel: boe-tv101wum-nl6: use wrapped MIPI DCS functions

2024-05-09 Thread Dmitry Baryshkov 
Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to
simplify driver's init/exit code.

Signed-off-by: Dmitry Baryshkov 
---
 drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 73 --
 1 file changed, 21 insertions(+), 52 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c 
b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
index aab60cec0603..456c1a5a2110 100644
--- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
@@ -448,22 +448,16 @@ static int boe_tv110c9m_init(struct boe_panel *boe)
mipi_dsi_dcs_write_seq_multi(&ctx, 0x55, 0x00);
mipi_dsi_dcs_write_seq_multi(&ctx, 0xbb, 0x13);
mipi_dsi_dcs_write_seq_multi(&ctx, 0x3b, 0x03, 0x96, 0x1a, 0x04, 0x04);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(100);
+   mipi_dsi_msleep(&ctx, 100);
 
mipi_dsi_dcs_write_seq_multi(&ctx, 0x11);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(200);
+   mipi_dsi_msleep(&ctx, 200);
 
mipi_dsi_dcs_write_seq_multi(&ctx, 0x29);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(100);
+   mipi_dsi_msleep(&ctx, 100);
 
return 0;
 };
@@ -893,22 +887,16 @@ static int inx_hj110iz_init(struct boe_panel *boe)
mipi_dsi_dcs_write_seq_multi(&ctx, 0xb0, 0x01);
mipi_dsi_dcs_write_seq_multi(&ctx, 0x35, 0x00);
mipi_dsi_dcs_write_seq_multi(&ctx, 0x3b, 0x03, 0xae, 0x1a, 0x04, 0x04);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(100);
+   mipi_dsi_msleep(&ctx, 100);
 
mipi_dsi_dcs_write_seq_multi(&ctx, 0x11);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(200);
+   mipi_dsi_msleep(&ctx, 200);
 
mipi_dsi_dcs_write_seq_multi(&ctx, 0x29);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(100);
+   mipi_dsi_msleep(&ctx, 100);
 
return 0;
 };
@@ -1207,10 +1195,8 @@ static int boe_init(struct boe_panel *boe)
mipi_dsi_dcs_write_seq_multi(&ctx, 0xb3, 0x08);
mipi_dsi_dcs_write_seq_multi(&ctx, 0xb0, 0x04);
mipi_dsi_dcs_write_seq_multi(&ctx, 0xb8, 0x68);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(150);
+   mipi_dsi_msleep(&ctx, 150);
 
return 0;
 };
@@ -1222,16 +1208,12 @@ static int auo_kd101n80_45na_init(struct boe_panel *boe)
msleep(24);
 
mipi_dsi_dcs_write_seq_multi(&ctx, 0x11);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(120);
+   mipi_dsi_msleep(&ctx, 120);
 
mipi_dsi_dcs_write_seq_multi(&ctx, 0x29);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(120);
+   mipi_dsi_msleep(&ctx, 120);
 
return 0;
 };
@@ -1283,10 +1265,8 @@ static int auo_b101uan08_3_init(struct boe_panel *boe)
mipi_dsi_dcs_write_seq_multi(&ctx, 0xe5, 0x4f);
mipi_dsi_dcs_write_seq_multi(&ctx, 0xe6, 0x41);
mipi_dsi_dcs_write_seq_multi(&ctx, 0xe7, 0x41);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(150);
+   mipi_dsi_msleep(&ctx, 150);
 
return 0;
 };
@@ -1385,16 +1365,12 @@ static int starry_qfh032011_53g_init(struct boe_panel 
*boe)
mipi_dsi_dcs_write_seq_multi(&ctx, 0xe1, 0x23);
mipi_dsi_dcs_write_seq_multi(&ctx, 0xe2, 0x07);
mipi_dsi_dcs_write_seq_multi(&ctx, 0X11);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(120);
+   mipi_dsi_msleep(&ctx, 120);
 
mipi_dsi_dcs_write_seq_multi(&ctx, 0X29);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(80);
+   mipi_dsi_msleep(&ctx, 80);
 
return 0;
 };
@@ -1490,13 +1466,12 @@ static int starry_himax83102_j02_init(struct boe_panel 
*boe)
mipi_dsi_dcs_write_seq_multi(&ctx, 0xba, 0x4f);
mipi_dsi_dcs_write_seq_multi(&ctx, 0xe9, 0x3f);
mipi_dsi_dcs_write_seq_multi(&ctx, 0xbd, 0x00);
-   mipi_dsi_dcs_write_seq_multi(&ctx, 0x11);
-   if (ctx.accum_err)
-   return ctx.accum_err;
 
-   msleep(120);
+   mipi_dsi_dcs_exit_sleep_mode_multi(&ctx);
 
-   mipi_dsi_dcs_write_seq_multi(&ctx, 0x29);
+   mipi_dsi_msleep(&ctx, 120);
+
+   mipi_dsi_dcs_set_display_on_multi(&ctx);
 
return ctx.accum_err;
 };
@@ -1508,20 +1483,14 @@ static inline struct boe_panel *to_boe_panel(struct 
drm_panel *panel)
 
 static int boe_panel_enter_sleep_mode(struct boe_panel *boe)
 {
-   struct mipi_dsi_device *dsi = boe->dsi;
-   int ret;
-
-   dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
+   struct mipi_dsi_multi_context ctx = { .dsi = boe->dsi };
 
-   ret = mipi_dsi_dcs_set_display_off(dsi);
-   if (ret < 0)
-   return ret;
+   boe->dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
 
-