Re: [PATCH drm-misc-next v4 0/4] drm/arm/hdlcd: use drm managed resources
On Tue, Nov 08, 2022 at 08:57:55PM +0100, Danilo Krummrich wrote: > Hi Liviu, Hi, > > > The only issue that I'm seeing that is not critical is that at > > reboot/shutdown time > > I'm getting an "Unexpected global fault, this could be serious" from the > > smmu: > > > > [ 6893.467910] arm-smmu 7fb3.iommu: disabling translation > > [ 6893.473550] ohci-platform 7ffb.usb: Removing from iommu group 1 > > [ 6893.479909] ehci-platform 7ffc.usb: Removing from iommu group 1 > > [ 6893.486931] arm-smmu 7fb1.iommu: disabling translation > > [ 6893.492521] hdlcd 7ff5.hdlcd: Removing from iommu group 3 > > [ 6893.492650] arm-smmu 7fb1.iommu: Unexpected global fault, this could > > be serious > > [ 6893.505959] arm-smmu 7fb1.iommu: GFSR 0x8001, GFSYNR0 > > 0x, GFSYNR1 0x, GFSYNR2 0x > > [ 6893.516511] arm-smmu 7fb0.iommu: disabling translation > > [ 6893.522195] dma-pl330 7ff0.dma-controller: Removing from iommu group > > 2 > > [ 6893.529607] arm-smmu 2b50.iommu: disabling translation > > [ 6893.535221] pcieport :00:00.0: Removing from iommu group 0 > > [ 6893.541135] pci :01:00.0: Removing from iommu group 0 > > [ 6893.546604] pcieport :02:01.0: Removing from iommu group 0 > > [ 6893.552511] pcieport :02:02.0: Removing from iommu group 0 > > [ 6893.558418] pcieport :02:03.0: Removing from iommu group 0 > > [ 6893.564329] pcieport :02:0c.0: Removing from iommu group 0 > > [ 6893.570393] pcieport :02:10.0: Removing from iommu group 0 > > [ 6893.576314] pcieport :02:1f.0: Removing from iommu group 0 > > [ 6893.582214] sata_sil24 :03:00.0: Removing from iommu group 0 > > [ 6893.588270] sky2 :08:00.0: Removing from iommu group 0 > > [ 6893.594616] reboot: Power down > > > > > > The reboot/shutdown succeeds, so I'm not too worried about it for now, but > > hope that > > this is something you'll keep in mind in the later series when you do > > drm_dev_unplug(). > > Yes, I'd expect this to be related to the missing protection of platform > device bound resources. > > > > > With that, for the whole series: > > > > Acked-by: Liviu Dudau > > > > Thanks for the patience and going through the series iterations with me. > > > > I can pull this series into drm-misc-next on Monday if you don't have any > > other plans. > Thanks, I saw you already applied the series. > > Have you had a look on the same series for malidp? Yes, I've looked at the code and it looks reasonable, I just wanted to run it once through the minimum of tests that I use, which involves switching some FPGA images around. Hope to do that today or tomorrow. Best regards, Liviu > > - Danilo > > > > > Best regards, > > Liviu > -- | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --- ¯\_(ツ)_/¯
Re: [PATCH drm-misc-next v4 0/4] drm/arm/hdlcd: use drm managed resources
Hi Liviu, The only issue that I'm seeing that is not critical is that at reboot/shutdown time I'm getting an "Unexpected global fault, this could be serious" from the smmu: [ 6893.467910] arm-smmu 7fb3.iommu: disabling translation [ 6893.473550] ohci-platform 7ffb.usb: Removing from iommu group 1 [ 6893.479909] ehci-platform 7ffc.usb: Removing from iommu group 1 [ 6893.486931] arm-smmu 7fb1.iommu: disabling translation [ 6893.492521] hdlcd 7ff5.hdlcd: Removing from iommu group 3 [ 6893.492650] arm-smmu 7fb1.iommu: Unexpected global fault, this could be serious [ 6893.505959] arm-smmu 7fb1.iommu: GFSR 0x8001, GFSYNR0 0x, GFSYNR1 0x, GFSYNR2 0x [ 6893.516511] arm-smmu 7fb0.iommu: disabling translation [ 6893.522195] dma-pl330 7ff0.dma-controller: Removing from iommu group 2 [ 6893.529607] arm-smmu 2b50.iommu: disabling translation [ 6893.535221] pcieport :00:00.0: Removing from iommu group 0 [ 6893.541135] pci :01:00.0: Removing from iommu group 0 [ 6893.546604] pcieport :02:01.0: Removing from iommu group 0 [ 6893.552511] pcieport :02:02.0: Removing from iommu group 0 [ 6893.558418] pcieport :02:03.0: Removing from iommu group 0 [ 6893.564329] pcieport :02:0c.0: Removing from iommu group 0 [ 6893.570393] pcieport :02:10.0: Removing from iommu group 0 [ 6893.576314] pcieport :02:1f.0: Removing from iommu group 0 [ 6893.582214] sata_sil24 :03:00.0: Removing from iommu group 0 [ 6893.588270] sky2 :08:00.0: Removing from iommu group 0 [ 6893.594616] reboot: Power down The reboot/shutdown succeeds, so I'm not too worried about it for now, but hope that this is something you'll keep in mind in the later series when you do drm_dev_unplug(). Yes, I'd expect this to be related to the missing protection of platform device bound resources. With that, for the whole series: Acked-by: Liviu Dudau Thanks for the patience and going through the series iterations with me. I can pull this series into drm-misc-next on Monday if you don't have any other plans. Thanks, I saw you already applied the series. Have you had a look on the same series for malidp? - Danilo Best regards, Liviu
Re: [PATCH drm-misc-next v4 0/4] drm/arm/hdlcd: use drm managed resources
On Wed, Oct 26, 2022 at 05:34:27PM +0200, Danilo Krummrich wrote:
> Hi,
Hi Danilo,
>
> This patch series converts the driver to use drm managed resources to prevent
> potential use-after-free issues on driver unbind/rebind and to get rid of the
> usage of deprecated APIs.
>
> Changes in v2:
> - drop patch "drm/arm/hdlcd: crtc: use drmm_crtc_init_with_planes()"
>
> Changes in v3:
> - Fix alternate return paths in srcu read-side critical sections causing a
> stall when unregistering the driver.
> - Fix potential null pointer dereference in hdlcd_crtc_cleanup() introduced
> dropping the patch in v2.
> - Add a patch to remove explicit calls to drm_mode_config_cleanup().
>
> Changes in v4:
> - Remove patches to protect platform device bound resources with
> drm_dev_{enter,exit}, since this would leave the hardware enabled when
> regularly unloading the driver e.g. via rmmod.
> Instead do this in a later series, once we got drm_dev_unplug() in place
> to deal with a regular driver shutdown.
This series is in a much better shape compared to the existing status quo. rmmod
works without any issue and I can re-insmod the driver again.
The only issue that I'm seeing that is not critical is that at reboot/shutdown
time
I'm getting an "Unexpected global fault, this could be serious" from the smmu:
[ 6893.467910] arm-smmu 7fb3.iommu: disabling translation
[ 6893.473550] ohci-platform 7ffb.usb: Removing from iommu group 1
[ 6893.479909] ehci-platform 7ffc.usb: Removing from iommu group 1
[ 6893.486931] arm-smmu 7fb1.iommu: disabling translation
[ 6893.492521] hdlcd 7ff5.hdlcd: Removing from iommu group 3
[ 6893.492650] arm-smmu 7fb1.iommu: Unexpected global fault, this could be
serious
[ 6893.505959] arm-smmu 7fb1.iommu: GFSR 0x8001, GFSYNR0
0x, GFSYNR1 0x, GFSYNR2 0x
[ 6893.516511] arm-smmu 7fb0.iommu: disabling translation
[ 6893.522195] dma-pl330 7ff0.dma-controller: Removing from iommu group 2
[ 6893.529607] arm-smmu 2b50.iommu: disabling translation
[ 6893.535221] pcieport :00:00.0: Removing from iommu group 0
[ 6893.541135] pci :01:00.0: Removing from iommu group 0
[ 6893.546604] pcieport :02:01.0: Removing from iommu group 0
[ 6893.552511] pcieport :02:02.0: Removing from iommu group 0
[ 6893.558418] pcieport :02:03.0: Removing from iommu group 0
[ 6893.564329] pcieport :02:0c.0: Removing from iommu group 0
[ 6893.570393] pcieport :02:10.0: Removing from iommu group 0
[ 6893.576314] pcieport :02:1f.0: Removing from iommu group 0
[ 6893.582214] sata_sil24 :03:00.0: Removing from iommu group 0
[ 6893.588270] sky2 :08:00.0: Removing from iommu group 0
[ 6893.594616] reboot: Power down
The reboot/shutdown succeeds, so I'm not too worried about it for now, but hope
that
this is something you'll keep in mind in the later series when you do
drm_dev_unplug().
With that, for the whole series:
Acked-by: Liviu Dudau
Thanks for the patience and going through the series iterations with me.
I can pull this series into drm-misc-next on Monday if you don't have any other
plans.
Best regards,
Liviu
>
> Danilo Krummrich (4):
> drm/arm/hdlcd: use drmm_* to allocate driver structures
> drm/arm/hdlcd: replace drm->dev_private with drm_to_hdlcd_priv()
> drm/arm/hdlcd: plane: use drm managed resources
> drm/arm/hdlcd: remove calls to drm_mode_config_cleanup()
>
> drivers/gpu/drm/arm/hdlcd_crtc.c | 24 +++
> drivers/gpu/drm/arm/hdlcd_drv.c | 41
> drivers/gpu/drm/arm/hdlcd_drv.h | 2 ++
> 3 files changed, 32 insertions(+), 35 deletions(-)
>
>
> base-commit: e1e7bc481d49c3e3ada11029ce0d9b85a0a539d7
> --
> 2.37.3
>
--
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---
¯\_(ツ)_/¯
[PATCH drm-misc-next v4 0/4] drm/arm/hdlcd: use drm managed resources
Hi,
This patch series converts the driver to use drm managed resources to prevent
potential use-after-free issues on driver unbind/rebind and to get rid of the
usage of deprecated APIs.
Changes in v2:
- drop patch "drm/arm/hdlcd: crtc: use drmm_crtc_init_with_planes()"
Changes in v3:
- Fix alternate return paths in srcu read-side critical sections causing a
stall when unregistering the driver.
- Fix potential null pointer dereference in hdlcd_crtc_cleanup() introduced
dropping the patch in v2.
- Add a patch to remove explicit calls to drm_mode_config_cleanup().
Changes in v4:
- Remove patches to protect platform device bound resources with
drm_dev_{enter,exit}, since this would leave the hardware enabled when
regularly unloading the driver e.g. via rmmod.
Instead do this in a later series, once we got drm_dev_unplug() in place
to deal with a regular driver shutdown.
Danilo Krummrich (4):
drm/arm/hdlcd: use drmm_* to allocate driver structures
drm/arm/hdlcd: replace drm->dev_private with drm_to_hdlcd_priv()
drm/arm/hdlcd: plane: use drm managed resources
drm/arm/hdlcd: remove calls to drm_mode_config_cleanup()
drivers/gpu/drm/arm/hdlcd_crtc.c | 24 +++
drivers/gpu/drm/arm/hdlcd_drv.c | 41
drivers/gpu/drm/arm/hdlcd_drv.h | 2 ++
3 files changed, 32 insertions(+), 35 deletions(-)
base-commit: e1e7bc481d49c3e3ada11029ce0d9b85a0a539d7
--
2.37.3
