Re: [PATCH hwc] Android: add CleanSpec.mk

[Rob Herring]

On Mon, Nov 6, 2017 at 5:16 AM, Robert Foss  wrote:
> Hey Rob,
>
> On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote:
>> On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang > org> wrote:
>> > The file contains rules that are executed on incremental builds.
>> > Since commit 4f7dc9b6 the library was moved to /vendor so
>> > the old file must be removed.
>> >
>> > Signed-off-by: Chih-Wei Huang 
>> > ---
>> >  CleanSpec.mk | 1 +
>> >  1 file changed, 1 insertion(+)
>> >  create mode 100644 CleanSpec.mk
>> >
>> > diff --git a/CleanSpec.mk b/CleanSpec.mk
>> > new file mode 100644
>> > index 000..99dcecd
>> > --- /dev/null
>> > +++ b/CleanSpec.mk
>> > @@ -0,0 +1 @@
>> > +$(call add-clean-step, rm -rf
>> > $(TARGET_OUT)/lib*/hw/hwcomposer.drm.so)
>>
>> Seems a bit silly to add forever an explicit file to clean for a
>> transient problem.
>>
> While transient, if maintaining multuple Android versions it may still
> stick around for quite some time.

That's not the issue. Once you do a clean build, the problem is gone
regardless of version.

Rob
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH hwc] Android: add CleanSpec.mk

[Robert Foss]

Hey Rob,

On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote:
> On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang  org> wrote:
> > The file contains rules that are executed on incremental builds.
> > Since commit 4f7dc9b6 the library was moved to /vendor so
> > the old file must be removed.
> > 
> > Signed-off-by: Chih-Wei Huang 
> > ---
> >  CleanSpec.mk | 1 +
> >  1 file changed, 1 insertion(+)
> >  create mode 100644 CleanSpec.mk
> > 
> > diff --git a/CleanSpec.mk b/CleanSpec.mk
> > new file mode 100644
> > index 000..99dcecd
> > --- /dev/null
> > +++ b/CleanSpec.mk
> > @@ -0,0 +1 @@
> > +$(call add-clean-step, rm -rf
> > $(TARGET_OUT)/lib*/hw/hwcomposer.drm.so)
> 
> Seems a bit silly to add forever an explicit file to clean for a
> transient problem.
> 
While transient, if maintaining multuple Android versions it may still
stick around for quite some time.

That being said, I don't have much of an opinion about this.


Rob.

signature.asc
Description: This is a digitally signed message part
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH hwc] Android: add CleanSpec.mk

[Chih-Wei Huang]

2017-11-03 20:35 GMT+08:00 Rob Herring :
> On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang  
> wrote:
>> The file contains rules that are executed on incremental builds.
>> Since commit 4f7dc9b6 the library was moved to /vendor so
>> the old file must be removed.
>>
>> Signed-off-by: Chih-Wei Huang 
>> ---
>>  CleanSpec.mk | 1 +
>>  1 file changed, 1 insertion(+)
>>  create mode 100644 CleanSpec.mk
>>
>> diff --git a/CleanSpec.mk b/CleanSpec.mk
>> new file mode 100644
>> index 000..99dcecd
>> --- /dev/null
>> +++ b/CleanSpec.mk
>> @@ -0,0 +1 @@
>> +$(call add-clean-step, rm -rf $(TARGET_OUT)/lib*/hw/hwcomposer.drm.so)
>
> Seems a bit silly to add forever an explicit file to clean for a
> transient problem.

The problem is people usually won't notice
the libraries have been moved to /vendor.
In an incremental build the old files still
exist in /system that may cause issues.

It's necessary unless you have a better idea
to tell people "hey, you need to do a clean build".


-- 
Chih-Wei
Android-x86 project
http://www.android-x86.org
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH hwc] Android: add CleanSpec.mk

[Rob Herring]

On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang  wrote:
> The file contains rules that are executed on incremental builds.
> Since commit 4f7dc9b6 the library was moved to /vendor so
> the old file must be removed.
>
> Signed-off-by: Chih-Wei Huang 
> ---
>  CleanSpec.mk | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 CleanSpec.mk
>
> diff --git a/CleanSpec.mk b/CleanSpec.mk
> new file mode 100644
> index 000..99dcecd
> --- /dev/null
> +++ b/CleanSpec.mk
> @@ -0,0 +1 @@
> +$(call add-clean-step, rm -rf $(TARGET_OUT)/lib*/hw/hwcomposer.drm.so)

Seems a bit silly to add forever an explicit file to clean for a
transient problem.

Rob
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH hwc] Android: add CleanSpec.mk

[Chih-Wei Huang]

The file contains rules that are executed on incremental builds.
Since commit 4f7dc9b6 the library was moved to /vendor so
the old file must be removed.

Signed-off-by: Chih-Wei Huang 
---
 CleanSpec.mk | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 CleanSpec.mk

diff --git a/CleanSpec.mk b/CleanSpec.mk
new file mode 100644
index 000..99dcecd
--- /dev/null
+++ b/CleanSpec.mk
@@ -0,0 +1 @@
+$(call add-clean-step, rm -rf $(TARGET_OUT)/lib*/hw/hwcomposer.drm.so)
-- 
2.13.6

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel