Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU
On Sun, Jun 23, 2024 at 02:40:14PM +0200, Krzysztof Kozlowski wrote: > On 23/06/2024 13:06, Akhil P Oommen wrote: > > Document Adreno X185 GMU in the dt-binding specification. > > > > Signed-off-by: Akhil P Oommen > > --- > > > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml > > b/Documentation/devicetree/bindings/display/msm/gmu.yaml > > index b3837368a260..9aa7151fd66f 100644 > > --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml > > @@ -23,6 +23,9 @@ properties: > >- items: > >- pattern: '^qcom,adreno-gmu-[67][0-9][0-9]\.[0-9]$' > >- const: qcom,adreno-gmu > > + - items: > > + - pattern: '^qcom,adreno-gmu-[x][1-9][0-9][0-9]\.[0-9]$' > > '[x]' is odd. Should be just 'x'. Ack -Akhil > > > Best regards, > Krzysztof >
Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU
On 23/06/2024 13:06, Akhil P Oommen wrote: > Document Adreno X185 GMU in the dt-binding specification. > > Signed-off-by: Akhil P Oommen > --- > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml > b/Documentation/devicetree/bindings/display/msm/gmu.yaml > index b3837368a260..9aa7151fd66f 100644 > --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml > +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml > @@ -23,6 +23,9 @@ properties: >- items: >- pattern: '^qcom,adreno-gmu-[67][0-9][0-9]\.[0-9]$' >- const: qcom,adreno-gmu > + - items: > + - pattern: '^qcom,adreno-gmu-[x][1-9][0-9][0-9]\.[0-9]$' '[x]' is odd. Should be just 'x'. Best regards, Krzysztof
Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU
On 23/06/2024 13:06, Akhil P Oommen wrote: > Document Adreno X185 GMU in the dt-binding specification. > > Signed-off-by: Akhil P Oommen > --- > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof
[PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU
Document Adreno X185 GMU in the dt-binding specification. Signed-off-by: Akhil P Oommen --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml index b3837368a260..9aa7151fd66f 100644 --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml @@ -23,6 +23,9 @@ properties: - items: - pattern: '^qcom,adreno-gmu-[67][0-9][0-9]\.[0-9]$' - const: qcom,adreno-gmu + - items: + - pattern: '^qcom,adreno-gmu-[x][1-9][0-9][0-9]\.[0-9]$' + - const: qcom,adreno-gmu - const: qcom,adreno-gmu-wrapper reg: @@ -225,6 +228,7 @@ allOf: - qcom,adreno-gmu-730.1 - qcom,adreno-gmu-740.1 - qcom,adreno-gmu-750.1 + - qcom,adreno-gmu-x185.1 then: properties: reg: -- 2.45.1
