Re: [PATCH v1 10/11] drm/dri1: Move Kconfig logic to drm/dri1

2022-07-17 Thread Javier Martinez Canillas
On 7/16/22 20:17, Sam Ravnborg wrote:
> Move the DRI1 section from drm/Kconfig to a new Kconfig
> file that lives in the dri1/ directory.
> This isolates more of the DRI1 functionality.
> 
> Signed-off-by: Sam Ravnborg 
> ---

Reviewed-by: Javier Martinez Canillas 

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat



[PATCH v1 10/11] drm/dri1: Move Kconfig logic to drm/dri1

2022-07-16 Thread Sam Ravnborg
Move the DRI1 section from drm/Kconfig to a new Kconfig
file that lives in the dri1/ directory.
This isolates more of the DRI1 functionality.

Signed-off-by: Sam Ravnborg 
---
 drivers/gpu/drm/Kconfig  | 77 +--
 drivers/gpu/drm/dri1/Kconfig | 79 
 2 files changed, 80 insertions(+), 76 deletions(-)
 create mode 100644 drivers/gpu/drm/dri1/Kconfig

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 024081480fcf..fd2684c7481f 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -403,82 +403,7 @@ config DRM_HYPERV
 If M is selected the module will be called hyperv_drm.
 
 # Keep legacy DRI1 drivers last
-
-menuconfig DRM_DRI1
-   bool "Enable legacy DRI1 drivers (DANGEROUS)"
-   depends on DRM && MMU
-   help
- Enable legacy DRI1 drivers. Those drivers expose unsafe and dangerous
- APIs to user-space, which can be used to circumvent access
- restrictions and other security measures. For backwards compatibility
- those drivers are still available, but their use is highly
- inadvisable and might harm your system.
-
- You are recommended to use the safe modeset-only drivers instead, and
- perform 3D emulation in user-space.
-
- Unless you have strong reasons to go rogue, say "N".
-
-if DRM_DRI1
-
-config DRM_TDFX
-   tristate "3dfx Banshee/Voodoo3+"
-   depends on DRM && PCI
-   help
- Choose this option if you have a 3dfx Banshee or Voodoo3 (or later),
- graphics card.  If M is selected, the module will be called tdfx.
-
-config DRM_R128
-   tristate "ATI Rage 128"
-   depends on DRM && PCI
-   select FW_LOADER
-   help
- Choose this option if you have an ATI Rage 128 graphics card.  If M
- is selected, the module will be called r128.  AGP support for
- this card is strongly suggested (unless you have a PCI version).
-
-config DRM_I810
-   tristate "Intel I810"
-   # !PREEMPTION because of missing ioctl locking
-   depends on DRM && AGP && AGP_INTEL && (!PREEMPTION || BROKEN)
-   help
- Choose this option if you have an Intel I810 graphics card.  If M is
- selected, the module will be called i810.  AGP support is required
- for this driver to work.
-
-config DRM_MGA
-   tristate "Matrox g200/g400"
-   depends on DRM && PCI
-   select FW_LOADER
-   help
- Choose this option if you have a Matrox G200, G400 or G450 graphics
- card.  If M is selected, the module will be called mga.  AGP
- support is required for this driver to work.
-
-config DRM_SIS
-   tristate "SiS video cards"
-   depends on DRM && AGP
-   depends on FB_SIS || FB_SIS=n
-   help
- Choose this option if you have a SiS 630 or compatible video
- chipset. If M is selected the module will be called sis. AGP
- support is required for this driver to work.
-
-config DRM_VIA
-   tristate "Via unichrome video cards"
-   depends on DRM && PCI
-   help
- Choose this option if you have a Via unichrome or compatible video
- chipset. If M is selected the module will be called via.
-
-config DRM_SAVAGE
-   tristate "Savage video cards"
-   depends on DRM && PCI
-   help
- Choose this option if you have a Savage3D/4/SuperSavage/Pro/Twister
- chipset. If M is selected the module will be called savage.
-
-endif # DRM_DRI1
+source "drivers/gpu/drm/dri1/Kconfig"
 
 config DRM_EXPORT_FOR_TESTS
bool
diff --git a/drivers/gpu/drm/dri1/Kconfig b/drivers/gpu/drm/dri1/Kconfig
new file mode 100644
index ..424b9a142aa2
--- /dev/null
+++ b/drivers/gpu/drm/dri1/Kconfig
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: GPL-2.0-only
+#
+# DRI1 drm device drivers
+
+menuconfig DRM_DRI1
+   bool "Enable legacy DRI1 drivers (DANGEROUS)"
+   depends on DRM && MMU
+   help
+ Enable legacy DRI1 drivers. Those drivers expose unsafe and dangerous
+ APIs to user-space, which can be used to circumvent access
+ restrictions and other security measures. For backwards compatibility
+ those drivers are still available, but their use is highly
+ inadvisable and might harm your system.
+
+ You are recommended to use the safe modeset-only drivers instead, and
+ perform 3D emulation in user-space.
+
+ Unless you have strong reasons to go rogue, say "N".
+
+if DRM_DRI1
+
+config DRM_TDFX
+   tristate "3dfx Banshee/Voodoo3+"
+   depends on DRM && PCI
+   help
+ Choose this option if you have a 3dfx Banshee or Voodoo3 (or later),
+ graphics card.  If M is selected, the module will be called tdfx.
+
+config DRM_R128
+   tristate "ATI Rage 128"
+   depends on DRM && PCI
+   select FW_LOADER
+   help
+ Choose this option if you have an