Re: [PATCH v1 2/3] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-10-11 Thread Sam Ravnborg 
Hi Oleksij,
On Mon, Oct 11, 2021 at 11:01:48AM +0200, Oleksij Rempel wrote:
> On Sat, Oct 09, 2021 at 05:12:44PM +0200, Sam Ravnborg wrote:
> > Hi Oleksij, Robin,
> > 
> > On Thu, Sep 30, 2021 at 12:05:00PM +0200, Oleksij Rempel wrote:
> > > Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7"
> > > WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit.
> > > 
> > > Co-Developed-by: Robin van der Gracht 
> > > Signed-off-by: Robin van der Gracht 
> > > Signed-off-by: Oleksij Rempel 
> > > ---
> > >  drivers/gpu/drm/panel/panel-simple.c | 16 
> > >  1 file changed, 16 insertions(+)
> > > 
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c 
> > > b/drivers/gpu/drm/panel/panel-simple.c
> > > index 9b6c4e6c38a1..a03b60f6fa99 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -2524,6 +2524,19 @@ static const struct panel_desc innolux_g070y2_l01 
> > > = {
> > >   .connector_type = DRM_MODE_CONNECTOR_LVDS,
> > >  };
> > >  
> > > +static const struct panel_desc innolux_g070y2_t02 = {
> > > + .modes = &innolux_at070tn92_mode,
> > 
> > It is suprising to see that the innolux_g070y2_t02 uses the mode
> > innolux_at070tn92_mode.
> > Is it on purpose?
> 
> yes.
> 
> > If yes then I would expect the changelog to say so.
> > 
> > In most (all?) other cases the panel provide their own mode.
> 
> It works with same timing values. What is the preferred way, add own
> mode or extend the changelog?

Both works for me, but I would duplicate the timings.
Only because I do not trust anyone that comes later to see that the
timings are used twice.

Sam

Re: [PATCH v1 2/3] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-10-11 Thread Oleksij Rempel 
On Sat, Oct 09, 2021 at 05:12:44PM +0200, Sam Ravnborg wrote:
> Hi Oleksij, Robin,
> 
> On Thu, Sep 30, 2021 at 12:05:00PM +0200, Oleksij Rempel wrote:
> > Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7"
> > WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit.
> > 
> > Co-Developed-by: Robin van der Gracht 
> > Signed-off-by: Robin van der Gracht 
> > Signed-off-by: Oleksij Rempel 
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 16 
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c 
> > b/drivers/gpu/drm/panel/panel-simple.c
> > index 9b6c4e6c38a1..a03b60f6fa99 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -2524,6 +2524,19 @@ static const struct panel_desc innolux_g070y2_l01 = {
> > .connector_type = DRM_MODE_CONNECTOR_LVDS,
> >  };
> >  
> > +static const struct panel_desc innolux_g070y2_t02 = {
> > +   .modes = &innolux_at070tn92_mode,
> 
> It is suprising to see that the innolux_g070y2_t02 uses the mode
> innolux_at070tn92_mode.
> Is it on purpose?

yes.

> If yes then I would expect the changelog to say so.
> 
> In most (all?) other cases the panel provide their own mode.

It works with same timing values. What is the preferred way, add own
mode or extend the changelog?

Regards,
Oleksij
-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

Re: [PATCH v1 2/3] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-10-09 Thread Sam Ravnborg 
Hi Oleksij, Robin,

On Thu, Sep 30, 2021 at 12:05:00PM +0200, Oleksij Rempel wrote:
> Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7"
> WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit.
> 
> Co-Developed-by: Robin van der Gracht 
> Signed-off-by: Robin van der Gracht 
> Signed-off-by: Oleksij Rempel 
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 16 
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c 
> b/drivers/gpu/drm/panel/panel-simple.c
> index 9b6c4e6c38a1..a03b60f6fa99 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2524,6 +2524,19 @@ static const struct panel_desc innolux_g070y2_l01 = {
>   .connector_type = DRM_MODE_CONNECTOR_LVDS,
>  };
>  
> +static const struct panel_desc innolux_g070y2_t02 = {
> + .modes = &innolux_at070tn92_mode,

It is suprising to see that the innolux_g070y2_t02 uses the mode
innolux_at070tn92_mode.
Is it on purpose? If yes then I would expect the changelog to say so.

In most (all?) other cases the panel provide their own mode.

Sam

> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 152,
> + .height = 92,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> + .connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
>  static const struct display_timing innolux_g101ice_l01_timing = {
>   .pixelclock = { 6040, 7110, 7470 },
>   .hactive = { 1280, 1280, 1280 },
> @@ -4663,6 +4676,9 @@ static const struct of_device_id platform_of_match[] = {
>   }, {
>   .compatible = "innolux,g070y2-l01",
>   .data = &innolux_g070y2_l01,
> + }, {
> + .compatible = "innolux,g070y2-t02",
> + .data = &innolux_g070y2_t02,
>   }, {
>   .compatible = "innolux,g101ice-l01",
>   .data = &innolux_g101ice_l01
> -- 
> 2.30.2

[PATCH v1 2/3] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-09-30 Thread Oleksij Rempel 
Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7"
WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit.

Co-Developed-by: Robin van der Gracht 
Signed-off-by: Robin van der Gracht 
Signed-off-by: Oleksij Rempel 
---
 drivers/gpu/drm/panel/panel-simple.c | 16 
 1 file changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index 9b6c4e6c38a1..a03b60f6fa99 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2524,6 +2524,19 @@ static const struct panel_desc innolux_g070y2_l01 = {
.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
+static const struct panel_desc innolux_g070y2_t02 = {
+   .modes = &innolux_at070tn92_mode,
+   .num_modes = 1,
+   .bpc = 8,
+   .size = {
+   .width = 152,
+   .height = 92,
+   },
+   .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+   .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
+   .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
 static const struct display_timing innolux_g101ice_l01_timing = {
.pixelclock = { 6040, 7110, 7470 },
.hactive = { 1280, 1280, 1280 },
@@ -4663,6 +4676,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "innolux,g070y2-l01",
.data = &innolux_g070y2_l01,
+   }, {
+   .compatible = "innolux,g070y2-t02",
+   .data = &innolux_g070y2_t02,
}, {
.compatible = "innolux,g101ice-l01",
.data = &innolux_g101ice_l01
-- 
2.30.2

[PATCH v1 2/3] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-05-18 Thread Oleksij Rempel 
Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7"
WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit.

Co-Developed-by: Robin van der Gracht 
Signed-off-by: Robin van der Gracht 
Signed-off-by: Oleksij Rempel 
---
 drivers/gpu/drm/panel/panel-simple.c | 16 
 1 file changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index be312b5c04dd..f79d97115f8f 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2323,6 +2323,19 @@ static const struct panel_desc innolux_g070y2_l01 = {
.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
+static const struct panel_desc innolux_g070y2_t02 = {
+   .modes = &innolux_at070tn92_mode,
+   .num_modes = 1,
+   .bpc = 8,
+   .size = {
+   .width = 152,
+   .height = 92,
+   },
+   .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+   .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
+   .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
 static const struct display_timing innolux_g101ice_l01_timing = {
.pixelclock = { 6040, 7110, 7470 },
.hactive = { 1280, 1280, 1280 },
@@ -4344,6 +4357,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "innolux,g070y2-l01",
.data = &innolux_g070y2_l01,
+   }, {
+   .compatible = "innolux,g070y2-t02",
+   .data = &innolux_g070y2_t02,
}, {
.compatible = "innolux,g101ice-l01",
.data = &innolux_g101ice_l01
-- 
2.29.2