Re: [PATCH v1 8/8] ARM: dts: imx6qdl-victgo: add CAN termination support

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:12AM +0100, Oleksij Rempel wrote:
> From: David Jander 
> 
> The gpio1 0 pin is controlling CAN termination, not USB H1 VBUS. So,
> remove wrong regulator and assign this gpio to new DT CAN termination
> property.
> 
> Signed-off-by: David Jander 
> Signed-off-by: Oleksij Rempel 

Applied, thanks!


[PATCH v1 8/8] ARM: dts: imx6qdl-victgo: add CAN termination support

2022-02-21 Thread Oleksij Rempel
From: David Jander 

The gpio1 0 pin is controlling CAN termination, not USB H1 VBUS. So,
remove wrong regulator and assign this gpio to new DT CAN termination
property.

Signed-off-by: David Jander 
Signed-off-by: Oleksij Rempel 
---
 arch/arm/boot/dts/imx6dl-victgo.dts | 12 ++--
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/imx6dl-victgo.dts 
b/arch/arm/boot/dts/imx6dl-victgo.dts
index 7839021bc3eb..d66da630e0af 100644
--- a/arch/arm/boot/dts/imx6dl-victgo.dts
+++ b/arch/arm/boot/dts/imx6dl-victgo.dts
@@ -160,15 +160,6 @@ reg_3v3: regulator-3v3 {
regulator-max-microvolt = <330>;
};
 
-   reg_h1_vbus: regulator-h1-vbus {
-   compatible = "regulator-fixed";
-   regulator-name = "h1-vbus";
-   regulator-min-microvolt = <500>;
-   regulator-max-microvolt = <500>;
-   gpio = <&gpio1 0 GPIO_ACTIVE_HIGH>;
-   enable-active-high;
-   };
-
reg_otg_vbus: regulator-otg-vbus {
compatible = "regulator-fixed";
regulator-name = "otg-vbus";
@@ -312,6 +303,8 @@ IMX_AUDMUX_V2_PTCR_SYN  
IMX_AUDMUX_V2_PDCR_RXDSEL(0)
 &can1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_can1>;
+   termination-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
+   termination-ohms = <150>;
status = "okay";
 };
 
@@ -646,7 +639,6 @@ &uart5 {
 };
 
 &usbh1 {
-   vbus-supply = <®_h1_vbus>;
pinctrl-names = "default";
phy_type = "utmi";
dr_mode = "host";
-- 
2.30.2