[PATCH v12][ 06/12] ARM: dts: imx5*, imx6*: correct display-timings nodes.
Hi, Shawn Guo wrote: > On Mon, Apr 07, 2014 at 02:44:45PM +0200, Denis Carikli wrote: > > The imx-drm driver can't use the de-active and > > pixelclk-active display-timings properties yet. > > > > Instead the data-enable and the pixel data clock > > polarity are hardcoded in the imx-drm driver. > > > > So theses properties are now set to keep > > the same behaviour when imx-drm will start > > using them. > > > > Signed-off-by: Denis Carikli > > --- > > ChangeLog v9->v10: > > - New patch that was splitted out of: > > "staging imx-drm: Use de-active and pixelclk-active > > display-timings." > > --- > > arch/arm/boot/dts/imx51-babbage.dts |2 ++ > > arch/arm/boot/dts/imx53-m53evk.dts|2 ++ > > arch/arm/boot/dts/imx53-tx53-x03x.dts |2 +- > > arch/arm/boot/dts/imx6qdl-gw53xx.dtsi |2 ++ > > arch/arm/boot/dts/imx6qdl-gw54xx.dtsi |2 ++ > > arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi |2 ++ > > arch/arm/boot/dts/imx6qdl-sabreauto.dtsi |2 ++ > > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi |2 ++ > > arch/arm/boot/dts/imx6qdl-sabresd.dtsi|2 ++ > > 9 files changed, 17 insertions(+), 1 deletion(-) > > ... > > > diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts > > b/arch/arm/boot/dts/imx53-tx53-x03x.dts > > index 0217dde3..4092a81 100644 > > --- a/arch/arm/boot/dts/imx53-tx53-x03x.dts > > +++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts > > @@ -93,7 +93,7 @@ > > hsync-active = <0>; > > vsync-active = <0>; > > de-active = <1>; > > - pixelclk-active = <1>; > > + pixelclk-active = <0>; > > @Lothar, is this change correct? > No, the ET0430 display which is affected by this patch actually has an inverted clock wrt the other displays of the family. 'pixelclk-active = <1>' is the correct setting for this display! Thanks, Shawn for the reminder. Lothar Wa?mann -- ___ Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch?ftsf?hrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info at karo-electronics.de ___
[PATCH v12][ 06/12] ARM: dts: imx5*, imx6*: correct display-timings nodes.
On Mon, Apr 07, 2014 at 02:44:45PM +0200, Denis Carikli wrote:
> The imx-drm driver can't use the de-active and
> pixelclk-active display-timings properties yet.
>
> Instead the data-enable and the pixel data clock
> polarity are hardcoded in the imx-drm driver.
>
> So theses properties are now set to keep
> the same behaviour when imx-drm will start
> using them.
>
> Signed-off-by: Denis Carikli
> ---
> ChangeLog v9->v10:
> - New patch that was splitted out of:
> "staging imx-drm: Use de-active and pixelclk-active
> display-timings."
> ---
> arch/arm/boot/dts/imx51-babbage.dts |2 ++
> arch/arm/boot/dts/imx53-m53evk.dts|2 ++
> arch/arm/boot/dts/imx53-tx53-x03x.dts |2 +-
> arch/arm/boot/dts/imx6qdl-gw53xx.dtsi |2 ++
> arch/arm/boot/dts/imx6qdl-gw54xx.dtsi |2 ++
> arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi |2 ++
> arch/arm/boot/dts/imx6qdl-sabreauto.dtsi |2 ++
> arch/arm/boot/dts/imx6qdl-sabrelite.dtsi |2 ++
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi|2 ++
> 9 files changed, 17 insertions(+), 1 deletion(-)
...
> diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts
> b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> index 0217dde3..4092a81 100644
> --- a/arch/arm/boot/dts/imx53-tx53-x03x.dts
> +++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> @@ -93,7 +93,7 @@
> hsync-active = <0>;
> vsync-active = <0>;
> de-active = <1>;
> - pixelclk-active = <1>;
> + pixelclk-active = <0>;
@Lothar, is this change correct?
Shawn
> };
>
> ET0500 {
[PATCH v12][ 06/12] ARM: dts: imx5*, imx6*: correct display-timings nodes.
The imx-drm driver can't use the de-active and
pixelclk-active display-timings properties yet.
Instead the data-enable and the pixel data clock
polarity are hardcoded in the imx-drm driver.
So theses properties are now set to keep
the same behaviour when imx-drm will start
using them.
Signed-off-by: Denis Carikli
---
ChangeLog v9->v10:
- New patch that was splitted out of:
"staging imx-drm: Use de-active and pixelclk-active
display-timings."
---
arch/arm/boot/dts/imx51-babbage.dts |2 ++
arch/arm/boot/dts/imx53-m53evk.dts|2 ++
arch/arm/boot/dts/imx53-tx53-x03x.dts |2 +-
arch/arm/boot/dts/imx6qdl-gw53xx.dtsi |2 ++
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi |2 ++
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi |2 ++
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi |2 ++
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi |2 ++
arch/arm/boot/dts/imx6qdl-sabresd.dtsi|2 ++
9 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx51-babbage.dts
b/arch/arm/boot/dts/imx51-babbage.dts
index 2dda06b..91ef454 100644
--- a/arch/arm/boot/dts/imx51-babbage.dts
+++ b/arch/arm/boot/dts/imx51-babbage.dts
@@ -38,6 +38,8 @@
vfront-porch = <7>;
hsync-len = <60>;
vsync-len = <10>;
+ de-active = <1>;
+ pixelclk-active = <0>;
};
};
diff --git a/arch/arm/boot/dts/imx53-m53evk.dts
b/arch/arm/boot/dts/imx53-m53evk.dts
index 4b036b4..d03ced7 100644
--- a/arch/arm/boot/dts/imx53-m53evk.dts
+++ b/arch/arm/boot/dts/imx53-m53evk.dts
@@ -41,6 +41,8 @@
vfront-porch = <9>;
vsync-len = <3>;
vsync-active = <1>;
+ de-active = <1>;
+ pixelclk-active = <0>;
};
};
};
diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts
b/arch/arm/boot/dts/imx53-tx53-x03x.dts
index 0217dde3..4092a81 100644
--- a/arch/arm/boot/dts/imx53-tx53-x03x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts
@@ -93,7 +93,7 @@
hsync-active = <0>;
vsync-active = <0>;
de-active = <1>;
- pixelclk-active = <1>;
+ pixelclk-active = <0>;
};
ET0500 {
diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
index c8e5ae0..43f48f2 100644
--- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
@@ -494,6 +494,8 @@
vfront-porch = <7>;
hsync-len = <60>;
vsync-len = <10>;
+ de-active = <1>;
+ pixelclk-active = <0>;
};
};
};
diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
index 2795dfc..59ecfd1 100644
--- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
@@ -516,6 +516,8 @@
vfront-porch = <7>;
hsync-len = <60>;
vsync-len = <10>;
+ de-active = <1>;
+ pixelclk-active = <0>;
};
};
};
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index 99be301..e9419a2 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -349,6 +349,8 @@
vfront-porch = <7>;
hsync-len = <60>;
vsync-len = <10>;
+ de-active = <1>;
+ pixelclk-active = <0>;
};
};
};
diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
index 009abd6..230bbc6 100644
--- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
@@ -405,6 +405,8 @@
vfront-porch = <7>;
hsync-len = <60>;
vsync-len = <10>;
+ de-active = <1>;
+ pixelclk-active = <0>;
};
};
};
diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
