Re: [PATCH v12 5/5] dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings
On 2018-07-05 15:48, Andrzej Hajda wrote:
On 05.07.2018 08:38, spa...@codeaurora.org wrote:
On 2018-06-29 17:44, Andrzej Hajda wrote:
On 21.06.2018 14:32, Sandeep Panda wrote:
Innolux TV123WAM is a 12.3" eDP display panel with
2160x1440 resolution, which can be supported by simple
panel driver.
Are you sure this is Innolux? Quick grep on Internet finds only BOE
panel with this TV123WAM[1].
[1]:
https://e2e.ti.com/cfs-file/__key/communityserver-discussions-components-files/138/TV123WAM_2D00_ND0_5F00_Product-spec_5F00_BOE_5F00_20161115_2D00_A00.pdf
The panel used here is innolux, which is a 2k panel. Where the BOE one
is a 1080p panel.
My doubts comes from the fact that Innolux uses different convention
for
panel naming, see for example [1].
According to this convention your panel should have name starting with:
N123ZDG-
TV123WAM follows BOE's convention.
Do you have datasheet, physical panel or something to ensure the name
is
correct?
[1]:
http://www.panelook.com/bramodlist.php?st==[]=63_type_category=70
Regards
Andrzej
The data sheet i have does not mention any version info/id of innolux
panel, so i took the
version name from a down stream patch we had earlier used to bring up
this panel.
Unfortunately i can not share the data sheet also as it is water marked
as confidential.
This panel patches are already merged in drm-misc, will upload a new
patch to remove tv123* name
and put some generic innolux panel name like innolux,2k
Regards
Andrzej
Changes in v1:
- Make use of simple panel driver instead of creating
a new driver for this panel (Sean Paul).
- Combine dt-binding and driver changes into one patch
as done by other existing panel support changes.
Changes in v2:
- Separate driver change from dt-binding documentation (Rob
Herring).
- Add the properties from simple-panel binding that are applicable
to
this panel (Rob Herring).
Signed-off-by: Sandeep Panda
Reviewed-by: Rob Herring
---
.../bindings/display/panel/innolux,tv123wam.txt | 20
1 file changed, 20 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
diff --git
a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
new file mode 100644
index ..a9b35265fa13
--- /dev/null
+++
b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
@@ -0,0 +1,20 @@
+Innolux TV123WAM 12.3 inch eDP 2K display panel
+
+This binding is compatible with the simple-panel binding, which is
specified
+in simple-panel.txt in this directory.
+
+Required properties:
+- compatible: should be "innolux,tv123wam"
+- power-supply: regulator to provide the supply voltage
+
+Optional properties:
+- enable-gpios: GPIO pin to enable or disable the panel
+- backlight: phandle of the backlight device attached to the panel
+
+Example:
+ panel_edp: panel-edp {
+ compatible = "innolux,tv123wam";
+ enable-gpios = < 31 GPIO_ACTIVE_LOW>;
+ power-supply = <_l2>;
+ backlight = <>;
+ };
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v12 5/5] dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings
On 2018-06-29 17:44, Andrzej Hajda wrote:
On 21.06.2018 14:32, Sandeep Panda wrote:
Innolux TV123WAM is a 12.3" eDP display panel with
2160x1440 resolution, which can be supported by simple
panel driver.
Are you sure this is Innolux? Quick grep on Internet finds only BOE
panel with this TV123WAM[1].
[1]:
https://e2e.ti.com/cfs-file/__key/communityserver-discussions-components-files/138/TV123WAM_2D00_ND0_5F00_Product-spec_5F00_BOE_5F00_20161115_2D00_A00.pdf
The panel used here is innolux, which is a 2k panel. Where the BOE one
is a 1080p panel.
Regards
Andrzej
Changes in v1:
- Make use of simple panel driver instead of creating
a new driver for this panel (Sean Paul).
- Combine dt-binding and driver changes into one patch
as done by other existing panel support changes.
Changes in v2:
- Separate driver change from dt-binding documentation (Rob Herring).
- Add the properties from simple-panel binding that are applicable to
this panel (Rob Herring).
Signed-off-by: Sandeep Panda
Reviewed-by: Rob Herring
---
.../bindings/display/panel/innolux,tv123wam.txt | 20
1 file changed, 20 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
diff --git
a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
new file mode 100644
index ..a9b35265fa13
--- /dev/null
+++
b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
@@ -0,0 +1,20 @@
+Innolux TV123WAM 12.3 inch eDP 2K display panel
+
+This binding is compatible with the simple-panel binding, which is
specified
+in simple-panel.txt in this directory.
+
+Required properties:
+- compatible: should be "innolux,tv123wam"
+- power-supply: regulator to provide the supply voltage
+
+Optional properties:
+- enable-gpios: GPIO pin to enable or disable the panel
+- backlight: phandle of the backlight device attached to the panel
+
+Example:
+ panel_edp: panel-edp {
+ compatible = "innolux,tv123wam";
+ enable-gpios = < 31 GPIO_ACTIVE_LOW>;
+ power-supply = <_l2>;
+ backlight = <>;
+ };
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v12 5/5] dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings
On 05.07.2018 08:38, spa...@codeaurora.org wrote:
> On 2018-06-29 17:44, Andrzej Hajda wrote:
>> On 21.06.2018 14:32, Sandeep Panda wrote:
>>> Innolux TV123WAM is a 12.3" eDP display panel with
>>> 2160x1440 resolution, which can be supported by simple
>>> panel driver.
>> Are you sure this is Innolux? Quick grep on Internet finds only BOE
>> panel with this TV123WAM[1].
>>
>> [1]:
>> https://e2e.ti.com/cfs-file/__key/communityserver-discussions-components-files/138/TV123WAM_2D00_ND0_5F00_Product-spec_5F00_BOE_5F00_20161115_2D00_A00.pdf
>>
> The panel used here is innolux, which is a 2k panel. Where the BOE one
> is a 1080p panel.
My doubts comes from the fact that Innolux uses different convention for
panel naming, see for example [1].
According to this convention your panel should have name starting with:
N123ZDG-
TV123WAM follows BOE's convention.
Do you have datasheet, physical panel or something to ensure the name is
correct?
[1]:
http://www.panelook.com/bramodlist.php?st==[]=63_type_category=70
Regards
Andrzej
>
>> Regards
>> Andrzej
>>> Changes in v1:
>>> - Make use of simple panel driver instead of creating
>>>a new driver for this panel (Sean Paul).
>>> - Combine dt-binding and driver changes into one patch
>>>as done by other existing panel support changes.
>>>
>>> Changes in v2:
>>> - Separate driver change from dt-binding documentation (Rob Herring).
>>> - Add the properties from simple-panel binding that are applicable to
>>>this panel (Rob Herring).
>>>
>>> Signed-off-by: Sandeep Panda
>>> Reviewed-by: Rob Herring
>>> ---
>>> .../bindings/display/panel/innolux,tv123wam.txt | 20
>>>
>>> 1 file changed, 20 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
>>> b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
>>> new file mode 100644
>>> index ..a9b35265fa13
>>> --- /dev/null
>>> +++
>>> b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
>>> @@ -0,0 +1,20 @@
>>> +Innolux TV123WAM 12.3 inch eDP 2K display panel
>>> +
>>> +This binding is compatible with the simple-panel binding, which is
>>> specified
>>> +in simple-panel.txt in this directory.
>>> +
>>> +Required properties:
>>> +- compatible: should be "innolux,tv123wam"
>>> +- power-supply: regulator to provide the supply voltage
>>> +
>>> +Optional properties:
>>> +- enable-gpios: GPIO pin to enable or disable the panel
>>> +- backlight: phandle of the backlight device attached to the panel
>>> +
>>> +Example:
>>> + panel_edp: panel-edp {
>>> + compatible = "innolux,tv123wam";
>>> + enable-gpios = < 31 GPIO_ACTIVE_LOW>;
>>> + power-supply = <_l2>;
>>> + backlight = <>;
>>> + };
>
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v12 5/5] dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings
On 21.06.2018 14:32, Sandeep Panda wrote:
> Innolux TV123WAM is a 12.3" eDP display panel with
> 2160x1440 resolution, which can be supported by simple
> panel driver.
Are you sure this is Innolux? Quick grep on Internet finds only BOE
panel with this TV123WAM[1].
[1]:
https://e2e.ti.com/cfs-file/__key/communityserver-discussions-components-files/138/TV123WAM_2D00_ND0_5F00_Product-spec_5F00_BOE_5F00_20161115_2D00_A00.pdf
Regards
Andrzej
>
> Changes in v1:
> - Make use of simple panel driver instead of creating
>a new driver for this panel (Sean Paul).
> - Combine dt-binding and driver changes into one patch
>as done by other existing panel support changes.
>
> Changes in v2:
> - Separate driver change from dt-binding documentation (Rob Herring).
> - Add the properties from simple-panel binding that are applicable to
>this panel (Rob Herring).
>
> Signed-off-by: Sandeep Panda
> Reviewed-by: Rob Herring
> ---
> .../bindings/display/panel/innolux,tv123wam.txt | 20
>
> 1 file changed, 20 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
> b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
> new file mode 100644
> index ..a9b35265fa13
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
> @@ -0,0 +1,20 @@
> +Innolux TV123WAM 12.3 inch eDP 2K display panel
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
> +
> +Required properties:
> +- compatible: should be "innolux,tv123wam"
> +- power-supply: regulator to provide the supply voltage
> +
> +Optional properties:
> +- enable-gpios: GPIO pin to enable or disable the panel
> +- backlight: phandle of the backlight device attached to the panel
> +
> +Example:
> + panel_edp: panel-edp {
> + compatible = "innolux,tv123wam";
> + enable-gpios = < 31 GPIO_ACTIVE_LOW>;
> + power-supply = <_l2>;
> + backlight = <>;
> + };
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v12 5/5] dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings
Innolux TV123WAM is a 12.3" eDP display panel with
2160x1440 resolution, which can be supported by simple
panel driver.
Changes in v1:
- Make use of simple panel driver instead of creating
a new driver for this panel (Sean Paul).
- Combine dt-binding and driver changes into one patch
as done by other existing panel support changes.
Changes in v2:
- Separate driver change from dt-binding documentation (Rob Herring).
- Add the properties from simple-panel binding that are applicable to
this panel (Rob Herring).
Signed-off-by: Sandeep Panda
Reviewed-by: Rob Herring
---
.../bindings/display/panel/innolux,tv123wam.txt | 20
1 file changed, 20 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
diff --git
a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
new file mode 100644
index ..a9b35265fa13
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
@@ -0,0 +1,20 @@
+Innolux TV123WAM 12.3 inch eDP 2K display panel
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
+
+Required properties:
+- compatible: should be "innolux,tv123wam"
+- power-supply: regulator to provide the supply voltage
+
+Optional properties:
+- enable-gpios: GPIO pin to enable or disable the panel
+- backlight: phandle of the backlight device attached to the panel
+
+Example:
+ panel_edp: panel-edp {
+ compatible = "innolux,tv123wam";
+ enable-gpios = < 31 GPIO_ACTIVE_LOW>;
+ power-supply = <_l2>;
+ backlight = <>;
+ };
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
