Re: [PATCH v2] drm/i915: Fix memory leaks in i915 selftests

[Andi Shyti]

On Sat, Apr 15, 2023 at 12:41:09AM +0200, Andi Shyti wrote:
> From: Cong Liu 
> 
> This patch fixes memory leaks on error escapes in function fake_get_pages
> 
> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist 
> creation")
> Signed-off-by: Cong Liu 
> Reviewed-by: Andrzej Hajda 
> Reviewed-by: Andi Shyti 
> Signed-off-by: Andi Shyti 

pushed to drm-intel-gt-next.

Thanks Cong for your fix,
Andi

[PATCH v2] drm/i915: Fix memory leaks in i915 selftests

[Andi Shyti]

From: Cong Liu 

This patch fixes memory leaks on error escapes in function fake_get_pages

Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist 
creation")
Signed-off-by: Cong Liu 
Reviewed-by: Andrzej Hajda 
Reviewed-by: Andi Shyti 
Signed-off-by: Andi Shyti 
---
Hi,

just resending this patch as I don't see it in our patchwork.

Andi

Changelong
==
v1 -> v2
 - Add r-b tags

 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c 
b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index 5361ce70d3f29..154801f1c4685 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj)
 
rem = round_up(obj->base.size, BIT(31)) >> 31;
/* restricted by sg_alloc_table */
-   if (overflows_type(rem, unsigned int))
+   if (overflows_type(rem, unsigned int)) {
+   kfree(pages);
return -E2BIG;
+   }
 
if (sg_alloc_table(pages, rem, GFP)) {
kfree(pages);
-- 
2.39.2