Re: [PATCH v2] drm/panfrost: Prefix interrupt handlers' names

2020-01-21 Thread Rob Herring 
On Mon, Jan 20, 2020 at 11:56 AM Ezequiel Garcia  wrote:
>
> On Sat, 2019-12-14 at 01:59 -0300, Ezequiel Garcia wrote:
> > Currently, the interrupt lines requested by Panfrost
> > use unmeaningful names, which adds some obscurity
> > to interrupt introspection (i.e. any tool based
> > on procfs' interrupts file).
> >
> > In order to improve this, prefix each requested
> > interrupt with the module name: panfrost-{gpu,job,mmu}.
> >
> > Signed-off-by: Ezequiel Garcia 
>
> Gentle ping.

Applied.

Rob
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/panfrost: Prefix interrupt handlers' names

2020-01-21 Thread Ezequiel Garcia 
On Sat, 2019-12-14 at 01:59 -0300, Ezequiel Garcia wrote:
> Currently, the interrupt lines requested by Panfrost
> use unmeaningful names, which adds some obscurity
> to interrupt introspection (i.e. any tool based
> on procfs' interrupts file).
> 
> In order to improve this, prefix each requested
> interrupt with the module name: panfrost-{gpu,job,mmu}.
> 
> Signed-off-by: Ezequiel Garcia 

Gentle ping.

Thanks,
Ezequiel

> ---
> v2:
> * Use consistent naming, as suggested by Alyssa, Neil and Robin.
> 
>  drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +-
>  drivers/gpu/drm/panfrost/panfrost_job.c | 2 +-
>  drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 --
>  3 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c 
> b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> index f67ed925c0ef..af2aa6b3bce3 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> @@ -348,7 +348,7 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)
>   return -ENODEV;
>  
>   err = devm_request_irq(pfdev->dev, irq, panfrost_gpu_irq_handler,
> -IRQF_SHARED, "gpu", pfdev);
> +IRQF_SHARED, KBUILD_MODNAME "-gpu", pfdev);
>   if (err) {
>   dev_err(pfdev->dev, "failed to request gpu irq");
>   return err;
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c 
> b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 05c85f45a0de..3bd79ebb6c40 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -480,7 +480,7 @@ int panfrost_job_init(struct panfrost_device *pfdev)
>   return -ENODEV;
>  
>   ret = devm_request_irq(pfdev->dev, irq, panfrost_job_irq_handler,
> -IRQF_SHARED, "job", pfdev);
> +IRQF_SHARED, KBUILD_MODNAME "-job", pfdev);
>   if (ret) {
>   dev_err(pfdev->dev, "failed to request job irq");
>   return ret;
> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c 
> b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> index 842bdd7cf6be..806958434726 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> @@ -612,9 +612,11 @@ int panfrost_mmu_init(struct panfrost_device *pfdev)
>   if (irq <= 0)
>   return -ENODEV;
>  
> - err = devm_request_threaded_irq(pfdev->dev, irq, 
> panfrost_mmu_irq_handler,
> + err = devm_request_threaded_irq(pfdev->dev, irq,
> + panfrost_mmu_irq_handler,
>   panfrost_mmu_irq_handler_thread,
> - IRQF_SHARED, "mmu", pfdev);
> + IRQF_SHARED, KBUILD_MODNAME "-mmu",
> + pfdev);
>  
>   if (err) {
>   dev_err(pfdev->dev, "failed to request mmu irq");


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/panfrost: Prefix interrupt handlers' names

2019-12-17 Thread Alyssa Rosenzweig 
Reviewed-by: Alyssa Rosenzweig 


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/panfrost: Prefix interrupt handlers' names

2019-12-16 Thread Steven Price 
On 14/12/2019 04:59, Ezequiel Garcia wrote:
> Currently, the interrupt lines requested by Panfrost
> use unmeaningful names, which adds some obscurity
> to interrupt introspection (i.e. any tool based
> on procfs' interrupts file).
> 
> In order to improve this, prefix each requested
> interrupt with the module name: panfrost-{gpu,job,mmu}.
> 
> Signed-off-by: Ezequiel Garcia 

LGTM

Reviewed-by: Steven Price 

> ---
> v2:
> * Use consistent naming, as suggested by Alyssa, Neil and Robin.
> 
>  drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +-
>  drivers/gpu/drm/panfrost/panfrost_job.c | 2 +-
>  drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 --
>  3 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c 
> b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> index f67ed925c0ef..af2aa6b3bce3 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> @@ -348,7 +348,7 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)
>   return -ENODEV;
>  
>   err = devm_request_irq(pfdev->dev, irq, panfrost_gpu_irq_handler,
> -IRQF_SHARED, "gpu", pfdev);
> +IRQF_SHARED, KBUILD_MODNAME "-gpu", pfdev);
>   if (err) {
>   dev_err(pfdev->dev, "failed to request gpu irq");
>   return err;
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c 
> b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 05c85f45a0de..3bd79ebb6c40 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -480,7 +480,7 @@ int panfrost_job_init(struct panfrost_device *pfdev)
>   return -ENODEV;
>  
>   ret = devm_request_irq(pfdev->dev, irq, panfrost_job_irq_handler,
> -IRQF_SHARED, "job", pfdev);
> +IRQF_SHARED, KBUILD_MODNAME "-job", pfdev);
>   if (ret) {
>   dev_err(pfdev->dev, "failed to request job irq");
>   return ret;
> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c 
> b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> index 842bdd7cf6be..806958434726 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> @@ -612,9 +612,11 @@ int panfrost_mmu_init(struct panfrost_device *pfdev)
>   if (irq <= 0)
>   return -ENODEV;
>  
> - err = devm_request_threaded_irq(pfdev->dev, irq, 
> panfrost_mmu_irq_handler,
> + err = devm_request_threaded_irq(pfdev->dev, irq,
> + panfrost_mmu_irq_handler,
>   panfrost_mmu_irq_handler_thread,
> - IRQF_SHARED, "mmu", pfdev);
> + IRQF_SHARED, KBUILD_MODNAME "-mmu",
> + pfdev);
>  
>   if (err) {
>   dev_err(pfdev->dev, "failed to request mmu irq");
> 

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2] drm/panfrost: Prefix interrupt handlers' names

2019-12-13 Thread Ezequiel Garcia 
Currently, the interrupt lines requested by Panfrost
use unmeaningful names, which adds some obscurity
to interrupt introspection (i.e. any tool based
on procfs' interrupts file).

In order to improve this, prefix each requested
interrupt with the module name: panfrost-{gpu,job,mmu}.

Signed-off-by: Ezequiel Garcia 
---
v2:
* Use consistent naming, as suggested by Alyssa, Neil and Robin.

 drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +-
 drivers/gpu/drm/panfrost/panfrost_job.c | 2 +-
 drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 --
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c 
b/drivers/gpu/drm/panfrost/panfrost_gpu.c
index f67ed925c0ef..af2aa6b3bce3 100644
--- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
@@ -348,7 +348,7 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)
return -ENODEV;
 
err = devm_request_irq(pfdev->dev, irq, panfrost_gpu_irq_handler,
-  IRQF_SHARED, "gpu", pfdev);
+  IRQF_SHARED, KBUILD_MODNAME "-gpu", pfdev);
if (err) {
dev_err(pfdev->dev, "failed to request gpu irq");
return err;
diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c 
b/drivers/gpu/drm/panfrost/panfrost_job.c
index 05c85f45a0de..3bd79ebb6c40 100644
--- a/drivers/gpu/drm/panfrost/panfrost_job.c
+++ b/drivers/gpu/drm/panfrost/panfrost_job.c
@@ -480,7 +480,7 @@ int panfrost_job_init(struct panfrost_device *pfdev)
return -ENODEV;
 
ret = devm_request_irq(pfdev->dev, irq, panfrost_job_irq_handler,
-  IRQF_SHARED, "job", pfdev);
+  IRQF_SHARED, KBUILD_MODNAME "-job", pfdev);
if (ret) {
dev_err(pfdev->dev, "failed to request job irq");
return ret;
diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c 
b/drivers/gpu/drm/panfrost/panfrost_mmu.c
index 842bdd7cf6be..806958434726 100644
--- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
@@ -612,9 +612,11 @@ int panfrost_mmu_init(struct panfrost_device *pfdev)
if (irq <= 0)
return -ENODEV;
 
-   err = devm_request_threaded_irq(pfdev->dev, irq, 
panfrost_mmu_irq_handler,
+   err = devm_request_threaded_irq(pfdev->dev, irq,
+   panfrost_mmu_irq_handler,
panfrost_mmu_irq_handler_thread,
-   IRQF_SHARED, "mmu", pfdev);
+   IRQF_SHARED, KBUILD_MODNAME "-mmu",
+   pfdev);
 
if (err) {
dev_err(pfdev->dev, "failed to request mmu irq");
-- 
2.22.0

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel