Re: [PATCH v2 -next] drm/komeda: remove set but not used variable 'old'

2019-07-23 Thread Daniel Vetter
On Mon, Jul 22, 2019 at 01:56:27PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c:
>  In function komeda_plane_atomic_duplicate_state:
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c:161:35:
>  warning: variable old set but not used [-Wunused-but-set-variable
> 
> It is not used since commit 990dee3aa456 ("drm/komeda:
> Computing image enhancer internally")
> 
> Reported-by: Hulk Robot 
> Signed-off-by: YueHaibing 
> ---
> v2: fix compile err

Ok this one worked, applied.

Thanks, Daniel

> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c 
> b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index c095af1..98e915e 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -158,7 +158,7 @@ static void komeda_plane_reset(struct drm_plane *plane)
>  static struct drm_plane_state *
>  komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
>  {
> - struct komeda_plane_state *new, *old;
> + struct komeda_plane_state *new;
>  
>   if (WARN_ON(!plane->state))
>   return NULL;
> @@ -169,8 +169,6 @@ komeda_plane_atomic_duplicate_state(struct drm_plane 
> *plane)
>  
>   __drm_atomic_helper_plane_duplicate_state(plane, >base);
>  
> - old = to_kplane_st(plane->state);
> -
>   return >base;
>  }
>  
> -- 
> 2.7.4
> 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 -next] drm/komeda: remove set but not used variable 'old'

2019-07-21 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/arm/display/komeda/komeda_plane.c:
 In function komeda_plane_atomic_duplicate_state:
drivers/gpu/drm/arm/display/komeda/komeda_plane.c:161:35:
 warning: variable old set but not used [-Wunused-but-set-variable

It is not used since commit 990dee3aa456 ("drm/komeda:
Computing image enhancer internally")

Reported-by: Hulk Robot 
Signed-off-by: YueHaibing 
---
v2: fix compile err
---
 drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c 
b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
index c095af1..98e915e 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
@@ -158,7 +158,7 @@ static void komeda_plane_reset(struct drm_plane *plane)
 static struct drm_plane_state *
 komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
 {
-   struct komeda_plane_state *new, *old;
+   struct komeda_plane_state *new;
 
if (WARN_ON(!plane->state))
return NULL;
@@ -169,8 +169,6 @@ komeda_plane_atomic_duplicate_state(struct drm_plane *plane)
 
__drm_atomic_helper_plane_duplicate_state(plane, >base);
 
-   old = to_kplane_st(plane->state);
-
return >base;
 }
 
-- 
2.7.4