[PATCH v2 0/4] drm/exynos, intel: fix locking for flip/vbl event list

2012-11-08 Thread Inki Dae 
2012/11/8 Rob Clark 

> On Wed, Nov 7, 2012 at 10:25 AM, Inki Dae  wrote:
> >
> >
> > 2012/11/7 Imre Deak 
> >>
> >> On Wed, 2012-11-07 at 18:31 +0900, Inki Dae wrote:
> >> > 2012/11/2 Imre Deak 
> >> > The patchset adds the missing event_lock when accessing the
> >> > vblank_event_list in drm_vblank_off() and as preparation for
> >> > this
> >> > also fixes a few other issues in the exynos driver.
> >> > This is also a dependency for Rob Clark's
> >> > drm_send_vblank_event()
> >> > rework as that would trigger a warning for the unhold
> >> > event_lock without
> >> > this changeset.
> >> > The exynos changes are only compile tested, the rest is tested
> >> > on an
> >> > Intel IVB machine on top of drm-intel-nightly +
> >> > drm_send_vblank_event()
> >> > rework, with i-g-t/flip_test.
> >> > Hi Imre,
> >> > Works fine. But we should wait for Rob's patch set to be merged to
> >> > -next, and this may be rebased on top of latest Rob's patch set again.
> >>
> >> Ok, thanks for checking this. I assume then that this patchset will get
> >> merged through your tree.
> >>
> >> I think Rob's patchset depends on this, so ideally this should go first.
> >> Otherwise the i915 driver would trigger the WARN in his patchset due to
> >> the unheld event_lock.
> >
> >
> > Ok, but I merge it first, shouldn't Rob's patch set be rebased? Anyway
> this
> > is minor issue so I could resolve it. And it seems like that your patch
> set
> > has no dependency of Rob's. I mean that your patch set worked fine
> without
> > Rob's.
>
> I think there should be no hard dependency on my patch set.. the only
> connection is that my patchset without this patch will start showing
> the WARN_ON() traces
>
>
Right, My concern was just merge conflict.


> BR,
> -R
>
> > Thanks,
> > Inki Dae
> >
> >>
> >>
> >> --Imre
> >>
> >>
> >> ___
> >> dri-devel mailing list
> >> dri-devel at lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> >
> >
> > ___
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
-- next part --
An HTML attachment was scrubbed...
URL:

[PATCH v2 0/4] drm/exynos, intel: fix locking for flip/vbl event list

2012-11-08 Thread Inki Dae 
2012/11/7 Imre Deak 

> On Wed, 2012-11-07 at 18:31 +0900, Inki Dae wrote:
> > 2012/11/2 Imre Deak 
> > The patchset adds the missing event_lock when accessing the
> > vblank_event_list in drm_vblank_off() and as preparation for
> > this
> > also fixes a few other issues in the exynos driver.
> > This is also a dependency for Rob Clark's
> > drm_send_vblank_event()
> > rework as that would trigger a warning for the unhold
> > event_lock without
> > this changeset.
> > The exynos changes are only compile tested, the rest is tested
> > on an
> > Intel IVB machine on top of drm-intel-nightly +
> > drm_send_vblank_event()
> > rework, with i-g-t/flip_test.
> > Hi Imre,
> > Works fine. But we should wait for Rob's patch set to be merged to
> > -next, and this may be rebased on top of latest Rob's patch set again.
>
> Ok, thanks for checking this. I assume then that this patchset will get
> merged through your tree.
>
> I think Rob's patchset depends on this, so ideally this should go first.
> Otherwise the i915 driver would trigger the WARN in his patchset due to
> the unheld event_lock.
>

Ok, but I merge it first, shouldn't Rob's patch set be rebased? Anyway this
is minor issue so I could resolve it. And it seems like that your patch set
has no dependency of Rob's. I mean that your patch set worked
fine without Rob's.

Thanks,
Inki Dae


>
> --Imre
>
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
-- next part --
An HTML attachment was scrubbed...
URL:

[PATCH v2 0/4] drm/exynos,intel: fix locking for flip/vbl event list

2012-11-07 Thread Imre Deak 
On Wed, 2012-11-07 at 18:31 +0900, Inki Dae wrote:
> 2012/11/2 Imre Deak 
> The patchset adds the missing event_lock when accessing the
> vblank_event_list in drm_vblank_off() and as preparation for
> this
> also fixes a few other issues in the exynos driver.
> This is also a dependency for Rob Clark's
> drm_send_vblank_event()
> rework as that would trigger a warning for the unhold
> event_lock without
> this changeset.
> The exynos changes are only compile tested, the rest is tested
> on an
> Intel IVB machine on top of drm-intel-nightly +
> drm_send_vblank_event()
> rework, with i-g-t/flip_test.
> Hi Imre,
> Works fine. But we should wait for Rob's patch set to be merged to
> -next, and this may be rebased on top of latest Rob's patch set again.

Ok, thanks for checking this. I assume then that this patchset will get
merged through your tree.

I think Rob's patchset depends on this, so ideally this should go first.
Otherwise the i915 driver would trigger the WARN in his patchset due to
the unheld event_lock.

--Imre

[PATCH v2 0/4] drm/exynos, intel: fix locking for flip/vbl event list

2012-11-07 Thread Rob Clark 
On Wed, Nov 7, 2012 at 10:25 AM, Inki Dae  wrote:
>
>
> 2012/11/7 Imre Deak 
>>
>> On Wed, 2012-11-07 at 18:31 +0900, Inki Dae wrote:
>> > 2012/11/2 Imre Deak 
>> > The patchset adds the missing event_lock when accessing the
>> > vblank_event_list in drm_vblank_off() and as preparation for
>> > this
>> > also fixes a few other issues in the exynos driver.
>> > This is also a dependency for Rob Clark's
>> > drm_send_vblank_event()
>> > rework as that would trigger a warning for the unhold
>> > event_lock without
>> > this changeset.
>> > The exynos changes are only compile tested, the rest is tested
>> > on an
>> > Intel IVB machine on top of drm-intel-nightly +
>> > drm_send_vblank_event()
>> > rework, with i-g-t/flip_test.
>> > Hi Imre,
>> > Works fine. But we should wait for Rob's patch set to be merged to
>> > -next, and this may be rebased on top of latest Rob's patch set again.
>>
>> Ok, thanks for checking this. I assume then that this patchset will get
>> merged through your tree.
>>
>> I think Rob's patchset depends on this, so ideally this should go first.
>> Otherwise the i915 driver would trigger the WARN in his patchset due to
>> the unheld event_lock.
>
>
> Ok, but I merge it first, shouldn't Rob's patch set be rebased? Anyway this
> is minor issue so I could resolve it. And it seems like that your patch set
> has no dependency of Rob's. I mean that your patch set worked fine without
> Rob's.

I think there should be no hard dependency on my patch set.. the only
connection is that my patchset without this patch will start showing
the WARN_ON() traces

BR,
-R

> Thanks,
> Inki Dae
>
>>
>>
>> --Imre
>>
>>
>> ___
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>

Re: [PATCH v2 0/4] drm/exynos, intel: fix locking for flip/vbl event list

2012-11-07 Thread Inki Dae 
2012/11/2 Imre Deak imre.d...@intel.com

 The patchset adds the missing event_lock when accessing the
 vblank_event_list in drm_vblank_off() and as preparation for this
 also fixes a few other issues in the exynos driver.

 This is also a dependency for Rob Clark's drm_send_vblank_event()
 rework as that would trigger a warning for the unhold event_lock without
 this changeset.

 The exynos changes are only compile tested, the rest is tested on an
 Intel IVB machine on top of drm-intel-nightly + drm_send_vblank_event()
 rework, with i-g-t/flip_test.


Hi Imre,

Works fine. But we should wait for Rob's patch set to be merged to -next,
and this may be rebased on top of latest Rob's patch set again.

Thanks,
Inki Dae


 In v2:
 - Instead of fixing the event_lock vs. vblank_time_lock lockdep issue in
   drm_handle_vblank(), fix it in the exynos driver. This looks like the
   more logical thing to do and this way we also have a smaller impact on
   the rest of DRM code.

 Imre Deak (4):
   drm/exynos: hold event_lock while accessing pageflip_event_list
   drm/exynos: call drm_vblank_put for each queued flip event
   drm/exynos: fix lockdep for event_lock wrt. vbl_time_lock
   drm: hold event_lock while accessing vblank_event_list

  drivers/gpu/drm/drm_irq.c|3 +++
  drivers/gpu/drm/exynos/exynos_drm_crtc.c |5 +
  drivers/gpu/drm/exynos/exynos_drm_fimd.c |   20 +---
  drivers/gpu/drm/exynos/exynos_drm_vidi.c |   20 +---
  drivers/gpu/drm/exynos/exynos_mixer.c|   11 +--
  5 files changed, 11 insertions(+), 48 deletions(-)

 --
 1.7.9.5

 ___
 dri-devel mailing list
 dri-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/dri-devel

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 0/4] drm/exynos,intel: fix locking for flip/vbl event list

2012-11-07 Thread Imre Deak 
On Wed, 2012-11-07 at 18:31 +0900, Inki Dae wrote:
 2012/11/2 Imre Deak imre.d...@intel.com
 The patchset adds the missing event_lock when accessing the
 vblank_event_list in drm_vblank_off() and as preparation for
 this
 also fixes a few other issues in the exynos driver.
 This is also a dependency for Rob Clark's
 drm_send_vblank_event()
 rework as that would trigger a warning for the unhold
 event_lock without
 this changeset.
 The exynos changes are only compile tested, the rest is tested
 on an
 Intel IVB machine on top of drm-intel-nightly +
 drm_send_vblank_event()
 rework, with i-g-t/flip_test.
 Hi Imre,
 Works fine. But we should wait for Rob's patch set to be merged to
 -next, and this may be rebased on top of latest Rob's patch set again.

Ok, thanks for checking this. I assume then that this patchset will get
merged through your tree.

I think Rob's patchset depends on this, so ideally this should go first.
Otherwise the i915 driver would trigger the WARN in his patchset due to
the unheld event_lock.

--Imre


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 0/4] drm/exynos, intel: fix locking for flip/vbl event list

2012-11-07 Thread Inki Dae 
2012/11/7 Imre Deak imre.d...@intel.com

 On Wed, 2012-11-07 at 18:31 +0900, Inki Dae wrote:
  2012/11/2 Imre Deak imre.d...@intel.com
  The patchset adds the missing event_lock when accessing the
  vblank_event_list in drm_vblank_off() and as preparation for
  this
  also fixes a few other issues in the exynos driver.
  This is also a dependency for Rob Clark's
  drm_send_vblank_event()
  rework as that would trigger a warning for the unhold
  event_lock without
  this changeset.
  The exynos changes are only compile tested, the rest is tested
  on an
  Intel IVB machine on top of drm-intel-nightly +
  drm_send_vblank_event()
  rework, with i-g-t/flip_test.
  Hi Imre,
  Works fine. But we should wait for Rob's patch set to be merged to
  -next, and this may be rebased on top of latest Rob's patch set again.

 Ok, thanks for checking this. I assume then that this patchset will get
 merged through your tree.

 I think Rob's patchset depends on this, so ideally this should go first.
 Otherwise the i915 driver would trigger the WARN in his patchset due to
 the unheld event_lock.


Ok, but I merge it first, shouldn't Rob's patch set be rebased? Anyway this
is minor issue so I could resolve it. And it seems like that your patch set
has no dependency of Rob's. I mean that your patch set worked
fine without Rob's.

Thanks,
Inki Dae



 --Imre


 ___
 dri-devel mailing list
 dri-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/dri-devel

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 0/4] drm/exynos, intel: fix locking for flip/vbl event list

2012-11-07 Thread Rob Clark 
On Wed, Nov 7, 2012 at 10:25 AM, Inki Dae inki@samsung.com wrote:


 2012/11/7 Imre Deak imre.d...@intel.com

 On Wed, 2012-11-07 at 18:31 +0900, Inki Dae wrote:
  2012/11/2 Imre Deak imre.d...@intel.com
  The patchset adds the missing event_lock when accessing the
  vblank_event_list in drm_vblank_off() and as preparation for
  this
  also fixes a few other issues in the exynos driver.
  This is also a dependency for Rob Clark's
  drm_send_vblank_event()
  rework as that would trigger a warning for the unhold
  event_lock without
  this changeset.
  The exynos changes are only compile tested, the rest is tested
  on an
  Intel IVB machine on top of drm-intel-nightly +
  drm_send_vblank_event()
  rework, with i-g-t/flip_test.
  Hi Imre,
  Works fine. But we should wait for Rob's patch set to be merged to
  -next, and this may be rebased on top of latest Rob's patch set again.

 Ok, thanks for checking this. I assume then that this patchset will get
 merged through your tree.

 I think Rob's patchset depends on this, so ideally this should go first.
 Otherwise the i915 driver would trigger the WARN in his patchset due to
 the unheld event_lock.


 Ok, but I merge it first, shouldn't Rob's patch set be rebased? Anyway this
 is minor issue so I could resolve it. And it seems like that your patch set
 has no dependency of Rob's. I mean that your patch set worked fine without
 Rob's.

I think there should be no hard dependency on my patch set.. the only
connection is that my patchset without this patch will start showing
the WARN_ON() traces

BR,
-R

 Thanks,
 Inki Dae



 --Imre


 ___
 dri-devel mailing list
 dri-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/dri-devel



 ___
 dri-devel mailing list
 dri-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/dri-devel

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 0/4] drm/exynos, intel: fix locking for flip/vbl event list

2012-11-07 Thread Inki Dae 
2012/11/8 Rob Clark rob.cl...@linaro.org

 On Wed, Nov 7, 2012 at 10:25 AM, Inki Dae inki@samsung.com wrote:
 
 
  2012/11/7 Imre Deak imre.d...@intel.com
 
  On Wed, 2012-11-07 at 18:31 +0900, Inki Dae wrote:
   2012/11/2 Imre Deak imre.d...@intel.com
   The patchset adds the missing event_lock when accessing the
   vblank_event_list in drm_vblank_off() and as preparation for
   this
   also fixes a few other issues in the exynos driver.
   This is also a dependency for Rob Clark's
   drm_send_vblank_event()
   rework as that would trigger a warning for the unhold
   event_lock without
   this changeset.
   The exynos changes are only compile tested, the rest is tested
   on an
   Intel IVB machine on top of drm-intel-nightly +
   drm_send_vblank_event()
   rework, with i-g-t/flip_test.
   Hi Imre,
   Works fine. But we should wait for Rob's patch set to be merged to
   -next, and this may be rebased on top of latest Rob's patch set again.
 
  Ok, thanks for checking this. I assume then that this patchset will get
  merged through your tree.
 
  I think Rob's patchset depends on this, so ideally this should go first.
  Otherwise the i915 driver would trigger the WARN in his patchset due to
  the unheld event_lock.
 
 
  Ok, but I merge it first, shouldn't Rob's patch set be rebased? Anyway
 this
  is minor issue so I could resolve it. And it seems like that your patch
 set
  has no dependency of Rob's. I mean that your patch set worked fine
 without
  Rob's.

 I think there should be no hard dependency on my patch set.. the only
 connection is that my patchset without this patch will start showing
 the WARN_ON() traces


Right, My concern was just merge conflict.


 BR,
 -R

  Thanks,
  Inki Dae
 
 
 
  --Imre
 
 
  ___
  dri-devel mailing list
  dri-devel@lists.freedesktop.org
  http://lists.freedesktop.org/mailman/listinfo/dri-devel
 
 
 
  ___
  dri-devel mailing list
  dri-devel@lists.freedesktop.org
  http://lists.freedesktop.org/mailman/listinfo/dri-devel
 
 ___
 dri-devel mailing list
 dri-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/dri-devel

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 0/4] drm/exynos,intel: fix locking for flip/vbl event list

2012-11-02 Thread Imre Deak 
The patchset adds the missing event_lock when accessing the
vblank_event_list in drm_vblank_off() and as preparation for this
also fixes a few other issues in the exynos driver.

This is also a dependency for Rob Clark's drm_send_vblank_event()
rework as that would trigger a warning for the unhold event_lock without
this changeset.

The exynos changes are only compile tested, the rest is tested on an
Intel IVB machine on top of drm-intel-nightly + drm_send_vblank_event()
rework, with i-g-t/flip_test.

In v2:
- Instead of fixing the event_lock vs. vblank_time_lock lockdep issue in
  drm_handle_vblank(), fix it in the exynos driver. This looks like the
  more logical thing to do and this way we also have a smaller impact on
  the rest of DRM code.

Imre Deak (4):
  drm/exynos: hold event_lock while accessing pageflip_event_list
  drm/exynos: call drm_vblank_put for each queued flip event
  drm/exynos: fix lockdep for event_lock wrt. vbl_time_lock
  drm: hold event_lock while accessing vblank_event_list

 drivers/gpu/drm/drm_irq.c|3 +++
 drivers/gpu/drm/exynos/exynos_drm_crtc.c |5 +
 drivers/gpu/drm/exynos/exynos_drm_fimd.c |   20 +---
 drivers/gpu/drm/exynos/exynos_drm_vidi.c |   20 +---
 drivers/gpu/drm/exynos/exynos_mixer.c|   11 +--
 5 files changed, 11 insertions(+), 48 deletions(-)

-- 
1.7.9.5

[PATCH v2 0/4] drm/exynos,intel: fix locking for flip/vbl event list

2012-11-02 Thread Imre Deak 
The patchset adds the missing event_lock when accessing the
vblank_event_list in drm_vblank_off() and as preparation for this
also fixes a few other issues in the exynos driver.

This is also a dependency for Rob Clark's drm_send_vblank_event()
rework as that would trigger a warning for the unhold event_lock without
this changeset.

The exynos changes are only compile tested, the rest is tested on an
Intel IVB machine on top of drm-intel-nightly + drm_send_vblank_event()
rework, with i-g-t/flip_test.

In v2:
- Instead of fixing the event_lock vs. vblank_time_lock lockdep issue in
  drm_handle_vblank(), fix it in the exynos driver. This looks like the
  more logical thing to do and this way we also have a smaller impact on
  the rest of DRM code.

Imre Deak (4):
  drm/exynos: hold event_lock while accessing pageflip_event_list
  drm/exynos: call drm_vblank_put for each queued flip event
  drm/exynos: fix lockdep for event_lock wrt. vbl_time_lock
  drm: hold event_lock while accessing vblank_event_list

 drivers/gpu/drm/drm_irq.c|3 +++
 drivers/gpu/drm/exynos/exynos_drm_crtc.c |5 +
 drivers/gpu/drm/exynos/exynos_drm_fimd.c |   20 +---
 drivers/gpu/drm/exynos/exynos_drm_vidi.c |   20 +---
 drivers/gpu/drm/exynos/exynos_mixer.c|   11 +--
 5 files changed, 11 insertions(+), 48 deletions(-)

-- 
1.7.9.5

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel