Re: [PATCH v2 1/6] drm/i915/ttm: fix sparse warning

[Das, Nirmoy]

On 1/30/2023 1:06 PM, Matthew Auld wrote:

Sparse complains with:

drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1066:21: sparse:
expected restricted vm_fault_t [assigned] [usertype] ret
drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1066:21: sparse: got int

Fixes: 516198d317d8 ("drm/i915: audit bo->resource usage v3")
Reported-by: kernel test robot 
Signed-off-by: Matthew Auld 
Cc: Christian König 
Reviewed-by: Andrzej Hajda 

Reviewed-by: Nirmoy Das 

---
  drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c 
b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 7420276827a5..4758f21c91e1 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -1067,11 +1067,12 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
.interruptible = true,
.no_wait_gpu = true, /* should be idle already */
};
+   int err;
  
  		GEM_BUG_ON(!bo->ttm || !(bo->ttm->page_flags & TTM_TT_FLAG_SWAPPED));
  
-		ret = ttm_bo_validate(bo, i915_ttm_sys_placement(), &ctx);

-   if (ret) {
+   err = ttm_bo_validate(bo, i915_ttm_sys_placement(), &ctx);
+   if (err) {
dma_resv_unlock(bo->base.resv);
return VM_FAULT_SIGBUS;
}

[PATCH v2 1/6] drm/i915/ttm: fix sparse warning

[Matthew Auld]

Sparse complains with:

drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1066:21: sparse:
expected restricted vm_fault_t [assigned] [usertype] ret
drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1066:21: sparse: got int

Fixes: 516198d317d8 ("drm/i915: audit bo->resource usage v3")
Reported-by: kernel test robot 
Signed-off-by: Matthew Auld 
Cc: Christian König 
Reviewed-by: Andrzej Hajda 
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c 
b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 7420276827a5..4758f21c91e1 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -1067,11 +1067,12 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
.interruptible = true,
.no_wait_gpu = true, /* should be idle already */
};
+   int err;
 
GEM_BUG_ON(!bo->ttm || !(bo->ttm->page_flags & 
TTM_TT_FLAG_SWAPPED));
 
-   ret = ttm_bo_validate(bo, i915_ttm_sys_placement(), &ctx);
-   if (ret) {
+   err = ttm_bo_validate(bo, i915_ttm_sys_placement(), &ctx);
+   if (err) {
dma_resv_unlock(bo->base.resv);
return VM_FAULT_SIGBUS;
}
-- 
2.39.1