Re: [PATCH v2 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards
[...]
> > + reg_vcc_mmc_io: regulator-vcc-mmc-io {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_vcc_mmc_io>;
> > + compatible = "regulator-gpio";
> > + vin-supply = <®_5v0>;
> > + regulator-name = "mmc_io_supply";
> > + regulator-type = "voltage";
> > + regulator-min-microvolt = <180>;
> > + regulator-max-microvolt = <330>;
> > + gpios = <&gpio7 13 GPIO_ACTIVE_HIGH>;
>
> enable-active-high?
right, thx!
> > + states = <180 0x1>, <330 0x0>;
>
> Hmm, I do not see this 'states' in fixed-regulator.yaml.
It is in gpio-regulator.yaml
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
Re: [PATCH v2 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards
On Wed, Jul 14, 2021 at 06:53:49AM +0200, Oleksij Rempel wrote:
> From: Sam Ravnborg
>
> Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards.
>
> Signed-off-by: Sam Ravnborg
> Signed-off-by: Søren Andersen
> Signed-off-by: Juergen Borleis
> Signed-off-by: Ulrich Ölmann
> Signed-off-by: Michael Grzeschik
> Signed-off-by: Marco Felsch
> Signed-off-by: Lucas Stach
> Signed-off-by: Oleksij Rempel
> ---
> arch/arm/boot/dts/Makefile| 5 +
> arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts| 13 +
> arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts| 108
> arch/arm/boot/dts/imx6q-skov-revc-lt2.dts | 36 ++
> arch/arm/boot/dts/imx6q-skov-revc-lt6.dts | 128 +
> .../dts/imx6q-skov-reve-mi1010ait-1cp1.dts| 127 +
> arch/arm/boot/dts/imx6qdl-skov-cpu-revc.dtsi | 54 ++
> arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi | 475 ++
> 8 files changed, 946 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts
> create mode 100644 arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts
> create mode 100644 arch/arm/boot/dts/imx6q-skov-revc-lt2.dts
> create mode 100644 arch/arm/boot/dts/imx6q-skov-revc-lt6.dts
> create mode 100644 arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts
> create mode 100644 arch/arm/boot/dts/imx6qdl-skov-cpu-revc.dtsi
> create mode 100644 arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index a2389b17026a..66aef5c6526d 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -473,6 +473,8 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> imx6dl-sabrelite.dtb \
> imx6dl-sabresd.dtb \
> imx6dl-savageboard.dtb \
> + imx6dl-skov-revc-lt2.dtb \
> + imx6dl-skov-revc-lt6.dtb \
> imx6dl-ts4900.dtb \
> imx6dl-ts7970.dtb \
> imx6dl-tx6dl-comtft.dtb \
> @@ -573,6 +575,9 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> imx6q-sabresd.dtb \
> imx6q-savageboard.dtb \
> imx6q-sbc6x.dtb \
> + imx6q-skov-revc-lt2.dtb \
> + imx6q-skov-revc-lt6.dtb \
> + imx6q-skov-reve-mi1010ait-1cp1.dtb \
> imx6q-tbs2910.dtb \
> imx6q-ts4900.dtb \
> imx6q-ts7970.dtb \
> diff --git a/arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts
> b/arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts
> new file mode 100644
> index ..667b8faa1807
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts
> @@ -0,0 +1,13 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Copyright (C) 2020 Pengutronix, Ulrich Oelmann
> +
> +/dts-v1/;
> +#include "imx6dl.dtsi"
> +#include "imx6qdl-skov-cpu.dtsi"
> +#include "imx6qdl-skov-cpu-revc.dtsi"
> +
> +/ {
> + model = "SKOV IMX6 CPU SoloCore";
> + compatible = "skov,imx6dl-skov-revc-lt2", "fsl,imx6dl";
> +};
> diff --git a/arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts
> b/arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts
> new file mode 100644
> index ..25071c7c4e29
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts
> @@ -0,0 +1,108 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Copyright (C) 2020 Pengutronix, Ulrich Oelmann
> +
> +/dts-v1/;
> +#include "imx6dl.dtsi"
> +#include "imx6qdl-skov-cpu.dtsi"
> +#include "imx6qdl-skov-cpu-revc.dtsi"
> +
> +/ {
> + model = "SKOV IMX6 CPU SoloCore";
> + compatible = "skov,imx6dl-skov-revc-lt6", "fsl,imx6dl";
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_backlight>;
> + enable-gpios = <&gpio6 23 GPIO_ACTIVE_LOW>;
> + pwms = <&pwm2 0 2 0>;
> + brightness-levels = <0 255>;
> + num-interpolated-steps = <17>;
> + default-brightness-level = <8>;
> + power-supply = <®_24v0>;
> + };
> +
> + display {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + compatible = "fsl,imx-parallel-display";
Drop the newline and start with compatible.
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ipu1>;
> +
> + port@0 {
> + reg = <0>;
> +
> + display0_in: endpoint {
> + remote-endpoint = <&ipu1_di0_disp0>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + display0_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> + };
> +
> +
One newline is good enough.
> + panel {
> + compatible = "logictechno,lttd800480070-l6wh-rt";
> + backlight = <&backlight>;
> + power-supply = <®_3v3>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&display0_out>;
> +
Re: [PATCH v2 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards
On Sun, Jul 18, 2021 at 10:22:14PM +0200, Sam Ravnborg wrote: > Hi Oleksij, > On Wed, Jul 14, 2021 at 06:53:49AM +0200, Oleksij Rempel wrote: > > From: Sam Ravnborg > > The real author one these dts files are Juergen Borleis IIRC. > I made some internal refactoring / renaming which is why I thing git > says otherwise. > So onless Juergen says otherwise we should give him the author credit. > > Arnd - would it be OK if I take the bindings patches through > drm-misc-next, and then you can take the DTS files via arm-soc? Yeah, it makes sense to send panel-simple.yaml change (patch #1) via drm tree. Shawn
Re: [PATCH v2 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards
Hi Oleksij, On Wed, Jul 14, 2021 at 06:53:49AM +0200, Oleksij Rempel wrote: > From: Sam Ravnborg The real author one these dts files are Juergen Borleis IIRC. I made some internal refactoring / renaming which is why I thing git says otherwise. So onless Juergen says otherwise we should give him the author credit. Arnd - would it be OK if I take the bindings patches through drm-misc-next, and then you can take the DTS files via arm-soc? Sam > > Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards. > > Signed-off-by: Sam Ravnborg > Signed-off-by: Søren Andersen > Signed-off-by: Juergen Borleis > Signed-off-by: Ulrich Ölmann > Signed-off-by: Michael Grzeschik > Signed-off-by: Marco Felsch > Signed-off-by: Lucas Stach > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/Makefile| 5 + > arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts| 13 + > arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts| 108 > arch/arm/boot/dts/imx6q-skov-revc-lt2.dts | 36 ++ > arch/arm/boot/dts/imx6q-skov-revc-lt6.dts | 128 + > .../dts/imx6q-skov-reve-mi1010ait-1cp1.dts| 127 + > arch/arm/boot/dts/imx6qdl-skov-cpu-revc.dtsi | 54 ++ > arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi | 475 ++ > 8 files changed, 946 insertions(+) > create mode 100644 arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts > create mode 100644 arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts > create mode 100644 arch/arm/boot/dts/imx6q-skov-revc-lt2.dts > create mode 100644 arch/arm/boot/dts/imx6q-skov-revc-lt6.dts > create mode 100644 arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts > create mode 100644 arch/arm/boot/dts/imx6qdl-skov-cpu-revc.dtsi > create mode 100644 arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi ...
[PATCH v2 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards
From: Sam Ravnborg
Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards.
Signed-off-by: Sam Ravnborg
Signed-off-by: Søren Andersen
Signed-off-by: Juergen Borleis
Signed-off-by: Ulrich Ölmann
Signed-off-by: Michael Grzeschik
Signed-off-by: Marco Felsch
Signed-off-by: Lucas Stach
Signed-off-by: Oleksij Rempel
---
arch/arm/boot/dts/Makefile| 5 +
arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts| 13 +
arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts| 108
arch/arm/boot/dts/imx6q-skov-revc-lt2.dts | 36 ++
arch/arm/boot/dts/imx6q-skov-revc-lt6.dts | 128 +
.../dts/imx6q-skov-reve-mi1010ait-1cp1.dts| 127 +
arch/arm/boot/dts/imx6qdl-skov-cpu-revc.dtsi | 54 ++
arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi | 475 ++
8 files changed, 946 insertions(+)
create mode 100644 arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts
create mode 100644 arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts
create mode 100644 arch/arm/boot/dts/imx6q-skov-revc-lt2.dts
create mode 100644 arch/arm/boot/dts/imx6q-skov-revc-lt6.dts
create mode 100644 arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts
create mode 100644 arch/arm/boot/dts/imx6qdl-skov-cpu-revc.dtsi
create mode 100644 arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a2389b17026a..66aef5c6526d 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -473,6 +473,8 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6dl-sabrelite.dtb \
imx6dl-sabresd.dtb \
imx6dl-savageboard.dtb \
+ imx6dl-skov-revc-lt2.dtb \
+ imx6dl-skov-revc-lt6.dtb \
imx6dl-ts4900.dtb \
imx6dl-ts7970.dtb \
imx6dl-tx6dl-comtft.dtb \
@@ -573,6 +575,9 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6q-sabresd.dtb \
imx6q-savageboard.dtb \
imx6q-sbc6x.dtb \
+ imx6q-skov-revc-lt2.dtb \
+ imx6q-skov-revc-lt6.dtb \
+ imx6q-skov-reve-mi1010ait-1cp1.dtb \
imx6q-tbs2910.dtb \
imx6q-ts4900.dtb \
imx6q-ts7970.dtb \
diff --git a/arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts
b/arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts
new file mode 100644
index ..667b8faa1807
--- /dev/null
+++ b/arch/arm/boot/dts/imx6dl-skov-revc-lt2.dts
@@ -0,0 +1,13 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Copyright (C) 2020 Pengutronix, Ulrich Oelmann
+
+/dts-v1/;
+#include "imx6dl.dtsi"
+#include "imx6qdl-skov-cpu.dtsi"
+#include "imx6qdl-skov-cpu-revc.dtsi"
+
+/ {
+ model = "SKOV IMX6 CPU SoloCore";
+ compatible = "skov,imx6dl-skov-revc-lt2", "fsl,imx6dl";
+};
diff --git a/arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts
b/arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts
new file mode 100644
index ..25071c7c4e29
--- /dev/null
+++ b/arch/arm/boot/dts/imx6dl-skov-revc-lt6.dts
@@ -0,0 +1,108 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Copyright (C) 2020 Pengutronix, Ulrich Oelmann
+
+/dts-v1/;
+#include "imx6dl.dtsi"
+#include "imx6qdl-skov-cpu.dtsi"
+#include "imx6qdl-skov-cpu-revc.dtsi"
+
+/ {
+ model = "SKOV IMX6 CPU SoloCore";
+ compatible = "skov,imx6dl-skov-revc-lt6", "fsl,imx6dl";
+
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_backlight>;
+ enable-gpios = <&gpio6 23 GPIO_ACTIVE_LOW>;
+ pwms = <&pwm2 0 2 0>;
+ brightness-levels = <0 255>;
+ num-interpolated-steps = <17>;
+ default-brightness-level = <8>;
+ power-supply = <®_24v0>;
+ };
+
+ display {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ compatible = "fsl,imx-parallel-display";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ipu1>;
+
+ port@0 {
+ reg = <0>;
+
+ display0_in: endpoint {
+ remote-endpoint = <&ipu1_di0_disp0>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ display0_out: endpoint {
+ remote-endpoint = <&panel_in>;
+ };
+ };
+ };
+
+
+ panel {
+ compatible = "logictechno,lttd800480070-l6wh-rt";
+ backlight = <&backlight>;
+ power-supply = <®_3v3>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&display0_out>;
+ };
+ };
+ };
+};
+
+&ipu1_di0_disp0 {
+ remote-endpoint = <&display0_in>;
+};
+
+&iomuxc {
+ pinctrl_backlight: backlightgrp {
+ fsl,pins = <
+ MX6QDL_PAD_RGMII_TD3__GPIO6_IO230x58
+ >;
+
