[PATCH v2 5/5] dt-bindings: add documentation for Rockchip rk3399 display controllers

2016-06-02 Thread Tomasz Figa 
Hi Mark,

Mark Yao  rock-chips.com> writes:

> 
> Cc: Rob Herring  kernel.org>
> Cc: Pawel Moll  arm.com>
> Cc: Mark Rutland  arm.com>
> Cc: Ian Campbell  hellion.org.uk>
> Cc: Kumar Gala  codeaurora.org>
> 
> Signed-off-by: Mark Yao  rock-chips.com>
> ---
>  .../bindings/display/rockchip/rockchip-vop.txt |5 +
>  1 file changed, 5 insertions(+)

Please see my comment inline.

> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-
vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-
vop.txt
> index 196121f..6bf8473 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>  -8,6 +8,11  Required properties:
>  - compatible: value should be one of the following
>   "rockchip,rk3036-vop";
>   "rockchip,rk3288-vop";
> + "rockchip,rk3399-vop-big";
> + "rockchip,rk3399-vop-lit";
> +Document compatible values for rk3399 display controllers.
> +Big and little display controllers are not identical and have differing
> +feature sets on the rk3399.

I think this doesn't really need any explanation. If two separate 
compatible strings are given, it means that the hardware is different. :)

Other than that,

Reviewed-by: Tomasz Figa 

Best regards,
Tomasz

[PATCH v2 5/5] dt-bindings: add documentation for Rockchip rk3399 display controllers

2016-04-20 Thread Mark Yao 
Cc: Rob Herring 
Cc: Pawel Moll 
Cc: Mark Rutland 
Cc: Ian Campbell 
Cc: Kumar Gala 

Signed-off-by: Mark Yao 
---
 .../bindings/display/rockchip/rockchip-vop.txt |5 +
 1 file changed, 5 insertions(+)

diff --git 
a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt 
b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
index 196121f..6bf8473 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
@@ -8,6 +8,11 @@ Required properties:
 - compatible: value should be one of the following
"rockchip,rk3036-vop";
"rockchip,rk3288-vop";
+   "rockchip,rk3399-vop-big";
+   "rockchip,rk3399-vop-lit";
+Document compatible values for rk3399 display controllers.
+Big and little display controllers are not identical and have differing
+feature sets on the rk3399.

 - interrupts: should contain a list of all VOP IP block interrupts in the
 order: VSYNC, LCD_SYSTEM. The interrupt specifier
-- 
1.7.9.5