Re: [PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function

[Jagan Teki]

On Wed, Dec 22, 2021 at 2:36 PM José Expósito  wrote:
>
> The "drm_plane_funcs.format_mod_supported" can be removed in favor of
> the default implementation.
>
> Signed-off-by: José Expósito 
> ---

Reviewed-by: Jagan Teki 
Tested-by: Jagan Teki  # i.Core STM32MP1

Re: [PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function

[yannick Fertre]

Hello José,
thanks for your patch.

Reviewed-by: Yannick Fertre 
Tested-by: Yannick Fertre 


On 12/22/21 10:05 AM, José Expósito wrote:

The "drm_plane_funcs.format_mod_supported" can be removed in favor of
the default implementation.

Signed-off-by: José Expósito 
---
  drivers/gpu/drm/stm/ltdc.c | 11 ---
  1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index dbdee954692a..ef909e50f0e4 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -925,16 +925,6 @@ static void ltdc_plane_atomic_print_state(struct 
drm_printer *p,
fpsi->counter = 0;
  }
  
-static bool ltdc_plane_format_mod_supported(struct drm_plane *plane,

-   u32 format,
-   u64 modifier)
-{
-   if (modifier == DRM_FORMAT_MOD_LINEAR)
-   return true;
-
-   return false;
-}
-
  static const struct drm_plane_funcs ltdc_plane_funcs = {
.update_plane = drm_atomic_helper_update_plane,
.disable_plane = drm_atomic_helper_disable_plane,
@@ -943,7 +933,6 @@ static const struct drm_plane_funcs ltdc_plane_funcs = {
.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
.atomic_print_state = ltdc_plane_atomic_print_state,
-   .format_mod_supported = ltdc_plane_format_mod_supported,
  };
  
  static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs = {

[PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function

[José Expósito]

The "drm_plane_funcs.format_mod_supported" can be removed in favor of
the default implementation.

Signed-off-by: José Expósito 
---
 drivers/gpu/drm/stm/ltdc.c | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index dbdee954692a..ef909e50f0e4 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -925,16 +925,6 @@ static void ltdc_plane_atomic_print_state(struct 
drm_printer *p,
fpsi->counter = 0;
 }
 
-static bool ltdc_plane_format_mod_supported(struct drm_plane *plane,
-   u32 format,
-   u64 modifier)
-{
-   if (modifier == DRM_FORMAT_MOD_LINEAR)
-   return true;
-
-   return false;
-}
-
 static const struct drm_plane_funcs ltdc_plane_funcs = {
.update_plane = drm_atomic_helper_update_plane,
.disable_plane = drm_atomic_helper_disable_plane,
@@ -943,7 +933,6 @@ static const struct drm_plane_funcs ltdc_plane_funcs = {
.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
.atomic_print_state = ltdc_plane_atomic_print_state,
-   .format_mod_supported = ltdc_plane_format_mod_supported,
 };
 
 static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs = {
-- 
2.25.1