Re: (subset) [PATCH v3 0/6] drm/rockchip: vop2: add support for the rgb output block
On Tue, 24 Jan 2023 06:47:00 +0100, Michael Riesch wrote:
> This series adds support for the RGB output block that can be found in the
> Rockchip Video Output Processor (VOP) 2. Version 2 of this series
> incorporates the feedback by Dan Carpenter and Sascha Hauer. Version 3
> fixes a dumb mistake pointed out by Sascha :-) Thanks for your comments!
>
> Patches 1-4 clean up the code and make it more general.
>
> [...]
Applied, thanks!
[1/6] drm/rockchip: vop2: initialize possible_crtcs properly
commit: 368419a2d429e2438bef333959732c640310bdc7
[2/6] drm/rockchip: rgb: embed drm_encoder into rockchip_encoder
commit: f8a852f1f86391127ab57b1c41fe0e62bc14f27c
[3/6] drm/rockchip: rgb: add video_port parameter to init function
commit: 03db8f25cf16c579fe75fd2230bbe64c221bfe25
[4/6] drm/rockchip: vop2: use symmetric function pair
vop2_{create,destroy}_crtcs
commit: cc066b056e7bb629a8c4d99c9c4a8ca70a6a
[5/6] drm/rockchip: vop2: add support for the rgb output block
commit: c66c6d7c47058a72a00b50d7f5c4538e3fa49b1c
Best regards,
--
Heiko Stuebner
Re: (subset) [PATCH v3 0/6] drm/rockchip: vop2: add support for the rgb output block
On Tue, 24 Jan 2023 06:47:00 +0100, Michael Riesch wrote: > This series adds support for the RGB output block that can be found in the > Rockchip Video Output Processor (VOP) 2. Version 2 of this series > incorporates the feedback by Dan Carpenter and Sascha Hauer. Version 3 > fixes a dumb mistake pointed out by Sascha :-) Thanks for your comments! > > Patches 1-4 clean up the code and make it more general. > > [...] Applied, thanks! [6/6] arm64: dts: rockchip: add pinctrls for 16-bit/18-bit rgb interface to rk356x commit: 381b6d432f6eb00e1faff763f55e67519af9fa23 Best regards, -- Heiko Stuebner
Re: [PATCH v3 0/6] drm/rockchip: vop2: add support for the rgb output block
On Tue, Jan 24, 2023 at 06:47:00AM +0100, Michael Riesch wrote: > Hi all, > > This series adds support for the RGB output block that can be found in the > Rockchip Video Output Processor (VOP) 2. Version 2 of this series > incorporates the feedback by Dan Carpenter and Sascha Hauer. Version 3 > fixes a dumb mistake pointed out by Sascha :-) Thanks for your comments! > > Patches 1-4 clean up the code and make it more general. > > Patch 5 activates the support for the RGB output block in the VOP2 driver. > > Patch 6 adds pinctrls for the 16-bit and 18-bit RGB data lines. > > Tested on a custom board featuring the RK3568 SoC with a 18-bit RGB > display. > > Looking forward to your comments! For the series: Reviewed-by: Sascha Hauer Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
[PATCH v3 0/6] drm/rockchip: vop2: add support for the rgb output block
Hi all,
This series adds support for the RGB output block that can be found in the
Rockchip Video Output Processor (VOP) 2. Version 2 of this series
incorporates the feedback by Dan Carpenter and Sascha Hauer. Version 3
fixes a dumb mistake pointed out by Sascha :-) Thanks for your comments!
Patches 1-4 clean up the code and make it more general.
Patch 5 activates the support for the RGB output block in the VOP2 driver.
Patch 6 adds pinctrls for the 16-bit and 18-bit RGB data lines.
Tested on a custom board featuring the RK3568 SoC with a 18-bit RGB
display.
Looking forward to your comments!
Best regards,
Michael
Michael Riesch (6):
drm/rockchip: vop2: initialize possible_crtcs properly
drm/rockchip: rgb: embed drm_encoder into rockchip_encoder
drm/rockchip: rgb: add video_port parameter to init function
drm/rockchip: vop2: use symmetric function pair
vop2_{create,destroy}_crtcs
drm/rockchip: vop2: add support for the rgb output block
arm64: dts: rockchip: add pinctrls for 16-bit/18-bit rgb interface to
rk356x
.../boot/dts/rockchip/rk3568-pinctrl.dtsi | 94 +++
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 80
drivers/gpu/drm/rockchip/rockchip_rgb.c | 19 ++--
drivers/gpu/drm/rockchip/rockchip_rgb.h | 6 +-
5 files changed, 172 insertions(+), 29 deletions(-)
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
--
2.30.2
