Re: [PATCH v3 1/6] dma-buf: Remove the signaled bit status check

[Christian König]

Am 09.09.22 um 19:08 schrieb Arvind Yadav:

Remove the signaled bit status check because it is returning
early when the fence is already signaled and
__dma_fence_enable_signaling is checking the status of signaled
bit again.

Signed-off-by: Arvind Yadav 


Reviewed-by: Christian König 


---

Changes in v1, v2: This new patch was not part of previous series.

---
  drivers/dma-buf/dma-fence.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
index 066400ed8841..64c99739ad23 100644
--- a/drivers/dma-buf/dma-fence.c
+++ b/drivers/dma-buf/dma-fence.c
@@ -601,9 +601,6 @@ void dma_fence_enable_sw_signaling(struct dma_fence *fence)
  {
unsigned long flags;
  
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))

-   return;
-
spin_lock_irqsave(fence->lock, flags);
__dma_fence_enable_signaling(fence);
spin_unlock_irqrestore(fence->lock, flags);

[PATCH v3 1/6] dma-buf: Remove the signaled bit status check

[Arvind Yadav]

Remove the signaled bit status check because it is returning
early when the fence is already signaled and
__dma_fence_enable_signaling is checking the status of signaled
bit again.

Signed-off-by: Arvind Yadav 
---

Changes in v1, v2: This new patch was not part of previous series.

---
 drivers/dma-buf/dma-fence.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
index 066400ed8841..64c99739ad23 100644
--- a/drivers/dma-buf/dma-fence.c
+++ b/drivers/dma-buf/dma-fence.c
@@ -601,9 +601,6 @@ void dma_fence_enable_sw_signaling(struct dma_fence *fence)
 {
unsigned long flags;
 
-   if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
-   return;
-
spin_lock_irqsave(fence->lock, flags);
__dma_fence_enable_signaling(fence);
spin_unlock_irqrestore(fence->lock, flags);
-- 
2.25.1